Re: [PATCH v5 2/4] ARM: dts: at91: sama5d2: add AIC node

[<Claudiu.Beznea@microchip.com>]

On 04.03.2022 13:05, Clément Léger wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> When using interrupts property, a global interrupt controller needs to
> be added to avoid warnings when compiling device-tree:
> 
>  arch/arm/dts/at91-sama5d2_xplained.dtb: Warning (interrupts_property):
>     /ahb/apb/timer@f800c000: Missing interrupt-parent
> 
> Add AIC node as the sama5d2 global interrupt controller.
> 
> Signed-off-by: Clément Léger <clement.leger@bootlin.com>
> ---
>  arch/arm/dts/sama5d2.dtsi | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm/dts/sama5d2.dtsi b/arch/arm/dts/sama5d2.dtsi
> index 038cd73c03..dee68dc022 100644
> --- a/arch/arm/dts/sama5d2.dtsi
> +++ b/arch/arm/dts/sama5d2.dtsi
> @@ -3,6 +3,7 @@
>  / {
>         model = "Atmel SAMA5D2 family SoC";
>         compatible = "atmel,sama5d2";
> +       interrupt-parent = <&aic>;
> 
>         aliases {
>                 spi0 = &spi0;
> @@ -700,6 +701,15 @@
>                                 clocks = <&h32ck>;
>                         };
> 
> +                       aic: interrupt-controller@fc020000 {
> +                               #interrupt-cells = <3>;
> +                               compatible = "atmel,sama5d2-aic";
> +                               interrupt-controller;
> +                               reg = <0xfc020000 0x200>;

Most of the nodes in this DT has compatible and reg at the beginning. For
clarity would be good to keep the rule for this one as well.

> +                               atmel,external-irqs = <49>;
> +                               status = "disabled";
> +                       };
> +
>                         watchdog@f8048040 {
>                                 compatible = "atmel,sama5d4-wdt";
>                                 reg = <0xf8048040 0x10>;
> --
> 2.34.1
>