public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Sean Anderson <seanga2@gmail.com>
To: Marek Vasut <marex@denx.de>, u-boot@lists.denx.de
Cc: Angus Ainslie <angus@akkea.ca>, Bin Meng <bmeng.cn@gmail.com>,
	Fabio Estevam <festevam@gmail.com>,
	Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
	Michal Simek <michal.simek@xilinx.com>,
	Peng Fan <peng.fan@nxp.com>,
	Sean Anderson <sean.anderson@seco.com>,
	Stefano Babic <sbabic@denx.de>
Subject: Re: [PATCH v2 5/5] usb: dwc3: Drop support for "snps, ref-clock-period-ns" DT property
Date: Mon, 7 Nov 2022 20:43:40 -0500	[thread overview]
Message-ID: <df073f97-6e7d-147c-1bcb-e34ac18a8355@gmail.com> (raw)
In-Reply-To: <20221108014013.750292-5-marex@denx.de>

On 11/7/22 20:40, Marek Vasut wrote:
> Drop support for quickly deprecated DT property "snps,ref-clock-period-ns"
> to prevent its proliferation.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: Angus Ainslie <angus@akkea.ca>
> Cc: Bin Meng <bmeng.cn@gmail.com>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Cc: Peng Fan <peng.fan@nxp.com>
> Cc: Sean Anderson <sean.anderson@seco.com>
> Cc: Stefano Babic <sbabic@denx.de>
> ---
> V2: New patch
> ---
>   drivers/usb/dwc3/core.c | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> index fcd062dc898..a0d3a9d5eea 100644
> --- a/drivers/usb/dwc3/core.c
> +++ b/drivers/usb/dwc3/core.c
> @@ -140,9 +140,6 @@ static void dwc3_ref_clk_period(struct dwc3 *dwc)
>   		if (!rate)
>   			return;
>   		period = NSEC_PER_SEC / rate;
> -	} else if (dwc->ref_clk_per) {
> -		period = dwc->ref_clk_per;
> -		rate = NSEC_PER_SEC / period;
>   	} else {
>   		return;
>   	}
> @@ -1120,7 +1117,6 @@ void dwc3_of_parse(struct dwc3 *dwc)
>   		| (dwc->is_utmi_l1_suspend << 4);
>   
>   	dev_read_u32(dev, "snps,quirk-frame-length-adjustment", &dwc->fladj);
> -	dev_read_u32(dev, "snps,ref-clock-period-ns", &dwc->ref_clk_per);
>   
>   	/*
>   	 * Handle property "snps,incr-burst-type-adjustment".

Reviewed-by: Sean Anderson <seanga2@gmail.com>

  reply	other threads:[~2022-11-08  1:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-08  1:40 [PATCH v2 1/5] usb: dwc3: Cache ref_clk pointer in struct dwc3 Marek Vasut
2022-11-08  1:40 ` [PATCH v2 2/5] usb: dwc3: reference clock period configuration Marek Vasut
2022-11-08  1:43   ` Sean Anderson
2022-11-08  1:40 ` [PATCH v2 3/5] usb: dwc3: Calculate REFCLKPER based on reference clock Marek Vasut
2022-11-08  1:40 ` [PATCH v2 4/5] usb: dwc3: Program GFLADJ Marek Vasut
2022-11-08  1:40 ` [PATCH v2 5/5] usb: dwc3: Drop support for "snps, ref-clock-period-ns" DT property Marek Vasut
2022-11-08  1:43   ` Sean Anderson [this message]
2022-11-08  1:42 ` [PATCH v2 1/5] usb: dwc3: Cache ref_clk pointer in struct dwc3 Sean Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=df073f97-6e7d-147c-1bcb-e34ac18a8355@gmail.com \
    --to=seanga2@gmail.com \
    --cc=angus@akkea.ca \
    --cc=bmeng.cn@gmail.com \
    --cc=festevam@gmail.com \
    --cc=hayashi.kunihiko@socionext.com \
    --cc=marex@denx.de \
    --cc=michal.simek@xilinx.com \
    --cc=peng.fan@nxp.com \
    --cc=sbabic@denx.de \
    --cc=sean.anderson@seco.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox