From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Williams Date: Sat, 21 Jan 2006 08:32:55 -0800 Subject: [U-Boot-Users] Re: [Patch] JSE SDRAM size probing In-Reply-To: <20060121101212.56F7E352B1E@atlas.denx.de> References: <20060121101212.56F7E352B1E@atlas.denx.de> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Wolfgang Denk wrote: > In message you wrote: >> Uh, because I can't find it? This board doesn't have an SPD bus, if >> that is what you mean. > > That's not what I mean. I was thinking of common/memsize.c and > post/memory.c, for example. Eventually about CFG_ALT_MEMTEST in > common/cmd_mem.c, too. Oh. Well, besides the point that only 8 lines of my function are the memory size probe (3 writes into memory and 1 read per bank) the get_ram_size function doesn't address mapping of two banks once the sizes are detected. That is where most of my effort went. Also, Stefan Roese points out the cpu/ppc4xx/sdram.c file, but that only handles 1 bank (and so obviously doesn't do mapping, which is largely what I worried about) and uses hard coded timings different from those appropriate for my board. So I'll stick with my code for now, although I'll keep a watch on the changes that Stefan suggests are coming. Thanks, -- Steve Williams "The woods are lovely, dark and deep. steve at icarus.com But I have promises to keep, http://www.icarus.com and lines to code before I sleep, http://www.picturel.com And lines to code before I sleep."