[U-Boot-Users] Re: [Patch] JSE SDRAM size probing

Wolfgang Denk
2006-01-21T17:59:32Z

In message <dqtnno$3c4$1@sea.gmane.org> you wrote:
>
> Oh. Well, besides the point that only 8 lines of my function are the
> memory size probe (3 writes into memory and 1 read per bank) the
> get_ram_size function doesn't address mapping of two banks once the
> sizes are detected. That is where most of my effort went.

I don't understand why you use a static layout which can deal only
with a few predefined sizes but needs such a lot of code. There are
other boards with more than one bank of memory, which IMHO handle
this more flexible and with less "magic" and less code; please study
the sources - and read the README.

> So I'll stick with my code for now, although I'll keep a watch on
> the changes that Stefan suggests are coming.

I don't think I will accept your patch.

Best regards,

Wolfgang Denk

--
Software Engineering: Embedded and Realtime Systems, Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Hi there! This is just a note from me, to you, to tell you, the per-
son reading this note, that I can't think up any more famous quotes,
jokes, nor bizarre stories, so you may as well go home.