From mboxrd@z Thu Jan  1 00:00:00 1970
From: Patrick DELAUNAY <patrick.delaunay@st.com>
Date: Wed, 24 Jun 2020 07:30:35 +0000
Subject: [RESEND PATCH v5 4/4] test: env: add test for env info sub-command
In-Reply-To: <8651f65b-88a9-ac03-dab0-16d4f0d161a2@wwwdotorg.org>
References: <20200619120337.17042-1-patrick.delaunay@st.com>
 <20200619120337.17042-5-patrick.delaunay@st.com>
 <fe00c944-0f54-8c61-ee16-dc97844eba44@wwwdotorg.org>
 <7288c055b63149ce9b9c97035915f57c@SFHDAG6NODE3.st.com>
 <8651f65b-88a9-ac03-dab0-16d4f0d161a2@wwwdotorg.org>
Message-ID: <e10eedda68bc4b3d9ea86f496561b6fa@SFHDAG6NODE3.st.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Stephen,

> From: Stephen Warren <swarren@wwwdotorg.org>
> Sent: mardi 23 juin 2020 22:25
> 
> On 6/23/20 7:25 AM, Patrick DELAUNAY wrote:
> > Hi Stephen,
> >
> >> From: Stephen Warren <swarren@wwwdotorg.org>
> >> Sent: lundi 22 juin 2020 20:51
> >>
> >> On 6/19/20 6:03 AM, Patrick Delaunay wrote:
> >>> Add a pytest for testing the env info sub-command:
> >>>
...
> >
> >>> +def test_env_info(state_test_env):
> >> ...
> >>> +    for l in response.split('\n'):
> >>> +        if 'env_valid = ' in l:
> >>> +            assert '= invalid' in l or '= valid' in l or '= redundant' in l
> >>> +            nb_line += 1
> >>> +        elif 'env_ready =' in l or 'env_use_default =' in l:
> >>> +            assert '= true' in l or '= false' in l
> >>> +            nb_line += 1
> >>> +        else:
> >>> +            assert true
> >>
> >> Those last two lines don't seem terribly useful:-)
> >
> > Not really,
> > beacuse I add the nb_line check,
> > this first check can be removed.
> >
> > Do expect a V6 just for that?
> 
> Probably not.

OK I will keep this remark if I need to update the serie
(or the next planned updates of this test)

Patrick