From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Thu, 15 Oct 2020 14:28:26 +0200
Subject: [PATCH v9] usb: add MediaTek USB3 DRD driver
In-Reply-To: <1602726548.29336.123.camel@mhfsdcap03>
References: <1602665439-16792-1-git-send-email-chunfeng.yun@mediatek.com>
 <7ed34781-0e48-da36-b576-d22688687ac7@denx.de>
 <1602678559.29336.93.camel@mhfsdcap03>
 <a91f2ae2-45dc-9aab-9ca3-59bd60ad404e@denx.de>
 <1602726548.29336.123.camel@mhfsdcap03>
Message-ID: <e1736e96-98b1-e4b1-e314-e5119bdba0d8@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 10/15/20 3:49 AM, Chunfeng Yun wrote:
> Hi Marek,

Hi,

> On Wed, 2020-10-14 at 15:03 +0200, Marek Vasut wrote:
>> On 10/14/20 2:29 PM, Chunfeng Yun wrote:
>>> On Wed, 2020-10-14 at 12:56 +0200, Marek Vasut wrote:
>>>> On 10/14/20 10:50 AM, Chunfeng Yun wrote:
>>>>> This patch adds support for the MediaTek USB3 DRD controller,
>>>>> its host side is based on xHCI, this driver supports device mode
>>>>> and host mode.
>>>>
>>>> This patch doesn't seem to apply to u-boot-usb/next , 
> This may cause u-boot-usb/next build error, due to no gadget driver is
> built, because I enabled the following configs in patch 764751784727
> ("configs: mt8512: enable fastboot and USB host related configs"):
> CONFIG_DM_USB_GADGET=y
> CONFIG_USB_MTU3=y
> CONFIG_USB_GADGET=y
> 
> but the mtu3 driver is not yet applied in u-boot-usb/next (although
> CONFIG_USB_MTU3 is enabled); and
> CONFIG_DM_USB_GADGET requires a gadget driver to define
> dm_usb_gadget_handle_interrupts(), then the build error happened.
> 
>> and also,
>>>> u-boot-usb/next does not build:
>>>
>>> There is error:
>>>  aarch64:  +   mt8512_bm1_emmc
>>> +aarch64-linux-ld.bfd: drivers/usb/gadget/udc/built-in.o: in function
>>> `usb_gadget_handle_interrupts':
>>> +drivers/usb/gadget/udc/udc-uclass.c:56: undefined reference to
>>> `dm_usb_gadget_handle_interrupts'
>>>
>>> It seems that the gadget of mtu3 is not enabled, but the default mode is
>>> gadget mode, not sure why not works.
> I tested it again, and look at the CI pipeline 4997, the mtu3 driver is
> not applied into u-boot-usb/next, so will build error.
> 
> Please apply the following patch to u-boot-usb/next, it will build pass:
> https://patchwork.ozlabs.org/project/uboot/patch/1602681717-20850-1-git-send-email-chunfeng.yun at mediatek.com/
> [RESEND,v9] usb: add MediaTek USB3 DRD driver
> 
> 
> The following patch is not needed anymore, please ignore it
> https://patchwork.ozlabs.org/project/uboot/patch/1602680044-19794-1-git-send-email-chunfeng.yun at mediatek.com/
> [v2] configs: mt8512: enable device mode of mtu3 explicitly

OK, so, please rebase whatever is left on top of usb/next and resend.
This patch does not apply on top of usb/next, sorry.