From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2487C433F5 for ; Wed, 6 Apr 2022 18:31:47 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 474F483DCB; Wed, 6 Apr 2022 20:31:45 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="od9BLAyb"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D415D83DE7; Wed, 6 Apr 2022 20:31:42 +0200 (CEST) Received: from mail-qv1-xf32.google.com (mail-qv1-xf32.google.com [IPv6:2607:f8b0:4864:20::f32]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0854983D97 for ; Wed, 6 Apr 2022 20:31:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qv1-xf32.google.com with SMTP id p8so2952395qvv.5 for ; Wed, 06 Apr 2022 11:31:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=k27RHTRuCrBX/Gj2TfTe0UFIAhqWVhatEWK4DaXIyzc=; b=od9BLAybVpod1HQjqDmabk4vWTEL9M332iJLOjThsypFH07O2hq+1ypkaqWbRC8ceC CU5kxdcJN66gj4wPqVBYq5AX9Lhsrq7p0ftglgmc/YreDrIjebCEuLEBjPthwTan3WJl nM6hpO72UmVTB5AL/hRdrsTj4TOhP/PaXZexxOJ0NA7MMMzLV+6uEH4MPmrVHZqKGOg3 M0MS2oTEbX/r8cufRuoOQQfCCfaHK9koSHV6iNJ6V2PIATsWCzKCccuayo/422IixDBh Y3TnYAopnKXufq8ERRBQpzr4J2eNu7Ouvm+oAj/9NZleRQFo2NX5QbcwhJwKyKt8E/1W Y7yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=k27RHTRuCrBX/Gj2TfTe0UFIAhqWVhatEWK4DaXIyzc=; b=m3qWhjlXGof46e5KCPrfvcuGV+rYa0fP4iZ3QUvp5QxuMva9BAGa7XQiGROYKHUR7Q rGBBI0B6wKNhXCk9ijA2pfrzRoguqadXwscaRQbBATlgLXSVm07bH3QRxPqcuFk5ZgPz JxeD4Byd4ISMzzUOxZVoi2sbil9tYrTErSqgoEKS2BVMUPOmIf1R85ogIg/6wpxqBR0n ObXI84mE4VImA2JncmNtj2bdGY55APi5xsjCwd6FiXtYoiiiWoCdT0jJN1rjdFAbMByT fgbU8hVN04vH+nS1XOg4wuaufnq0TdnAERHqt8hyGfPYH3YJ4Vlly8bQiy3e3ZgN76iX FR3A== X-Gm-Message-State: AOAM531tV5VTFe1t+FgNEJZy+ARQ8M8tFgQPNqhh5C7pkFhvVlZERS0m 1kRaHPBW1g2ljp06RQQPhXQ= X-Google-Smtp-Source: ABdhPJx9Cu5ATuB5c3NFvgas76NOQxtA1o8zICdaiBjTlwfZcl76f5ADvNI7n8p6Pep3Yq74YhZQmA== X-Received: by 2002:a0c:e153:0:b0:443:d5f0:5db8 with SMTP id c19-20020a0ce153000000b00443d5f05db8mr8439407qvl.80.1649269898926; Wed, 06 Apr 2022 11:31:38 -0700 (PDT) Received: from [192.168.1.201] (pool-108-18-137-133.washdc.fios.verizon.net. [108.18.137.133]) by smtp.googlemail.com with ESMTPSA id f8-20020ac859c8000000b002e232e04cafsm14315928qtf.88.2022.04.06.11.31.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Apr 2022 11:31:38 -0700 (PDT) Subject: Re: [PATCH 0/8] Fix misc ASAN reports To: Andrew Scull , u-boot@lists.denx.de Cc: sjg@chromium.org References: <20220403103915.3338027-1-ascull@google.com> From: Sean Anderson Message-ID: Date: Wed, 6 Apr 2022 14:31:37 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20220403103915.3338027-1-ascull@google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 4/3/22 6:39 AM, Andrew Scull wrote: > I've been experimenting with ASAN on sandbox and turned up a few issues > that are fixed in this series. > > Basic ASAN was easy to turn on, but integrating with dlmalloc was > messier and fairly intrusive. Even when I had it working, there was only > a small redzone between allocations which limits the usefulness. Do you have any patches for this? --Sean > I saw another series on the list by Sean Anderson to enable valgrind > which was finding a different set of issues, though there was one > overlap that Sean is fixing with > "[PATCH] IOMUX: Fix access past end of console_devices". > > With these issues fixed, I was able to run the dm tests without any ASAN > issues. There are a couple of leaks reported at the end, but that's for > another day. > > Andrew Scull (8): > doc: Correct position of gdb '--args' parameter > acpi: Fix buffer overflow in do_acpi_dump() > x86: sandbox: Add missing PCI bar to barinfo > usb: sandbox: Check for string end in copy_to_unicode() > usb: sandbox: Bounds check read from buffer > sound: Fix buffer overflow in square wave generation > test: Fix pointer overrun in dm_test_devm_regmap() > test: dm: devres: Remove use-after-free > > cmd/acpi.c | 2 +- > doc/develop/tests_sandbox.rst | 2 +- > drivers/power/acpi_pmc/pmc_emul.c | 1 + > drivers/sound/sound.c | 6 ++---- > drivers/usb/emul/sandbox_flash.c | 2 ++ > drivers/usb/emul/usb-emul-uclass.c | 5 ++--- > test/dm/devres.c | 5 +---- > test/dm/regmap.c | 9 ++++----- > 8 files changed, 14 insertions(+), 18 deletions(-) >