From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 27F0CC6FA99 for ; Wed, 8 Mar 2023 00:35:58 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CC99685C66; Wed, 8 Mar 2023 01:35:55 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 809A085C5F; Wed, 8 Mar 2023 01:35:52 +0100 (CET) Received: from mail-m11874.qiye.163.com (mail-m11874.qiye.163.com [115.236.118.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9EAB285813 for ; Wed, 8 Mar 2023 01:35:48 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=kever.yang@rock-chips.com Received: from [172.16.12.93] (unknown [58.22.7.114]) by mail-m11874.qiye.163.com (Hmail) with ESMTPA id AFC6A3C0189; Wed, 8 Mar 2023 08:35:29 +0800 (CST) Message-ID: Date: Wed, 8 Mar 2023 08:35:29 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 2/2] arm64: dts: rk3568-u-boot: Drop combphy0 assigned-clocks/rates Content-Language: en-US To: Vasily Khoruzhick , Mark Kettenis , zhangqing Cc: sjg@chromium.org, philipp.tomsich@vrull.eu, gajjar04akash@gmail.com, abbaraju.manojsai@amarulasolutions.com, jagan@amarulasolutions.com, john@metanate.com, u-boot@lists.denx.de References: <20230307193748.25712-1-anarsoul@gmail.com> <20230307193748.25712-2-anarsoul@gmail.com> <87o7p4cp8f.fsf@bloch.sibelius.xs4all.nl> <87jzzsclyc.fsf@bloch.sibelius.xs4all.nl> From: Kever Yang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZQ0wZGVYaQ0hITk1PHU1PQh5VEwETFh oSFyQUDg9ZV1kYEgtZQVlOQ1VJSVVMVUpKT1lXWRYaDxIVHRRZQVlPS0hVSkpLSEpMVUpLS1VLWQ Y+ X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6Mj46NCo4Mz0WHzArKDY4Pzwy CDIKCStVSlVKTUxDSUhOTEhLSE9MVTMWGhIXVRAeDR4JVQIaFRw7CRQYEFYYExILCFUYFBZFWVdZ EgtZQVlOQ1VJSVVMVUpKT1lXWQgBWUFOSk5ONwY+ X-HM-Tid: 0a86bea500012eb0kusnafc6a3c0189 X-HM-MType: 1 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Vasily, On 2023/3/8 05:34, Vasily Khoruzhick wrote: > On Tue, Mar 7, 2023 at 1:04 PM Mark Kettenis wrote: > >> And implement support for the CLK_PCIEPHYn_REF clocks in >> drivers/clk/rockchip/clk_rk3568.c:rk3568_pmuclk_set_rate()? >> >> Yes, I'd say so. >> >> If U-Boot doesn't actually need these clocks to run at the frequency >> provided by assigned-clock-rates, that could be as simple as returning >> 0 for these clocks. > Sounds good. I'll send v2 that reverts 5bec4b0de785 and implements > stubs for CLK_PCIEPHYn_REF clocks. > > FWIW, I tried booting linux-6.2.2 with u-boot dtb and these clocks > dropped, and USB works just fine. The assigned-clock is a software set default value, the hardware can works fine because these clocks have a correct default hardware value. So for the PHY,  it works in U-Boot without assigned clock in most case. Returing 0 for those clocks is also OK. Thanks, - Kever > >>>>> commit 5bec4b0de785 ("arm64: dts: rk356x-u-boot: Drop combphy1 assigned-clocks/rates") >>>>> dropped these properties for combphy1, so let's drop them for combphy0 as well. >>>>> >>>>> Signed-off-by: Vasily Khoruzhick >>>>> --- >>>>> arch/arm/dts/rk3568-evb-u-boot.dtsi | 1 + >>>>> arch/arm/dts/rk3568-rock-3a-u-boot.dtsi | 1 + >>>>> arch/arm/dts/rk3568-u-boot.dtsi | 11 +++++++++++ >>>>> 3 files changed, 13 insertions(+) >>>>> create mode 100644 arch/arm/dts/rk3568-u-boot.dtsi >>>>> >>>>> diff --git a/arch/arm/dts/rk3568-evb-u-boot.dtsi b/arch/arm/dts/rk3568-evb-u-boot.dtsi >>>>> index 17503d3d27..77430da3ba 100644 >>>>> --- a/arch/arm/dts/rk3568-evb-u-boot.dtsi >>>>> +++ b/arch/arm/dts/rk3568-evb-u-boot.dtsi >>>>> @@ -4,6 +4,7 @@ >>>>> */ >>>>> >>>>> #include "rk356x-u-boot.dtsi" >>>>> +#include "rk3568-u-boot.dtsi" >>>>> >>>>> / { >>>>> chosen { >>>>> diff --git a/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi b/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi >>>>> index ed47efa44b..44cf33ed4b 100644 >>>>> --- a/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi >>>>> +++ b/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi >>>>> @@ -5,6 +5,7 @@ >>>>> */ >>>>> >>>>> #include "rk356x-u-boot.dtsi" >>>>> +#include "rk3568-u-boot.dtsi" >>>>> >>>>> / { >>>>> chosen { >>>>> diff --git a/arch/arm/dts/rk3568-u-boot.dtsi b/arch/arm/dts/rk3568-u-boot.dtsi >>>>> new file mode 100644 >>>>> index 0000000000..c6776666df >>>>> --- /dev/null >>>>> +++ b/arch/arm/dts/rk3568-u-boot.dtsi >>>>> @@ -0,0 +1,11 @@ >>>>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) >>>>> +/* >>>>> + * Copyright (c) 2023 Vasily Khoruzhick >>>>> + */ >>>>> + >>>>> +#include "rockchip-u-boot.dtsi" >>>>> + >>>>> +&combphy0 { >>>>> + /delete-property/ assigned-clocks; >>>>> + /delete-property/ assigned-clock-rates; >>>>> +}; >>>>> -- >>>>> 2.39.2 >>>>> >>>>>