public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Patrice CHOTARD <patrice.chotard@foss.st.com>
To: Patrick DELAUNAY <patrick.delaunay@foss.st.com>, <u-boot@lists.denx.de>
Cc: U-Boot STM32 <uboot-stm32@st-md-mailman.stormreply.com>,
	Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH v1 13/25] ARM: dts: stm32: Add led-blue for stm32mp157a-dk1-scmi-u-boot
Date: Fri, 19 Apr 2024 14:21:37 +0200	[thread overview]
Message-ID: <e23ea82e-1ff1-41eb-adea-5ffdf7b4e2de@foss.st.com> (raw)
In-Reply-To: <07727744-f8c7-4e88-8fa9-3d8f7dc4b54b@foss.st.com>



On 4/17/24 11:09, Patrick DELAUNAY wrote:
> Hi,
> 
> On 4/9/24 17:02, Patrice Chotard wrote:
>> As indicated in kernel led dt-bindings, label is a deprecated
>> property, so remove it and use blue led node's name instead
>> for u-boot,boot-led property.
>>
>> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
>> ---
>>
>>   arch/arm/dts/stm32mp157a-dk1-scmi-u-boot.dtsi | 6 +++++-
>>   1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/dts/stm32mp157a-dk1-scmi-u-boot.dtsi b/arch/arm/dts/stm32mp157a-dk1-scmi-u-boot.dtsi
>> index e61814fd66e..a5158fec7ef 100644
>> --- a/arch/arm/dts/stm32mp157a-dk1-scmi-u-boot.dtsi
>> +++ b/arch/arm/dts/stm32mp157a-dk1-scmi-u-boot.dtsi
>> @@ -13,7 +13,7 @@
>>       };
>>         config {
>> -        u-boot,boot-led = "heartbeat";
>> +        u-boot,boot-led = "led-blue";
>>           u-boot,error-led = "led-red";
>>           u-boot,mmc-env-partition = "u-boot-env";
>>           st,adc_usb_pd = <&adc1 18>, <&adc1 19>;
>> @@ -36,6 +36,10 @@
>>       };
>>         led {
>> +        led-blue {
>> +            /delete-property/label;
>> +        };
>> +
>>           led-red {
>>               gpios = <&gpioa 13 GPIO_ACTIVE_LOW>;
>>           };
> 
> 
> 
> Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
> 
> Thanks
> Patrick
> 

Applied on u-boot-stm32/master 

  reply	other threads:[~2024-04-19 12:22 UTC|newest]

Thread overview: 79+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-09 15:01 [PATCH v1 00/25] stm32mp: Fix keys & leds management Patrice Chotard
2024-04-09 15:01 ` [PATCH v1 01/25] configs: stm32mp13: Enable FASTBOOT Patrice Chotard
2024-04-17  9:03   ` Patrick DELAUNAY
2024-04-18 11:48   ` Igor Opaniuk
2024-04-19 12:16     ` Patrice CHOTARD
2024-04-09 15:01 ` [PATCH v1 02/25] configs: stm32mp1: Enable BUTTON_GPIO flag for stm32mp15_defconfig Patrice Chotard
2024-04-17  9:03   ` Patrick DELAUNAY
2024-04-19 12:16     ` Patrice CHOTARD
2024-04-09 15:01 ` [PATCH v1 03/25] configs: stm32mp1: Enable BUTTON_GPIO flag for stm32mp15_basic_defconfig Patrice Chotard
2024-04-17  9:04   ` Patrick DELAUNAY
2024-04-19 12:16     ` Patrice CHOTARD
2024-04-09 15:01 ` [PATCH v1 04/25] configs: stm32mp1: Enable BUTTON_GPIO flag for stm32mp15_trusted_defconfig Patrice Chotard
2024-04-17  9:04   ` Patrick DELAUNAY
2024-04-19 12:16     ` Patrice CHOTARD
2024-04-09 15:01 ` [PATCH v1 05/25] configs: stm32mp1: Enable BUTTON_GPIO flag for stm32mp13_defconfig Patrice Chotard
2024-04-17  9:04   ` Patrick DELAUNAY
2024-04-18 11:48   ` Igor Opaniuk
2024-04-19 12:16     ` Patrice CHOTARD
2024-04-09 15:01 ` [PATCH v1 06/25] board: st: stmp32mp1: Use BUTTON UCLASS in board_key_check() Patrice Chotard
2024-04-17  9:05   ` Patrick DELAUNAY
2024-04-19 12:16     ` Patrice CHOTARD
2024-04-09 15:01 ` [PATCH v1 07/25] ARM: dts: stm32: Add gpio-keys for stm32mp135f-dk-u-boot Patrice Chotard
2024-04-17  9:06   ` Patrick DELAUNAY
2024-04-19 12:17     ` Patrice CHOTARD
2024-04-09 15:01 ` [PATCH v1 08/25] ARM: dts: stm32: Don't probe led-red/led-blue at boot " Patrice Chotard
2024-04-17  9:06   ` Patrick DELAUNAY
2024-04-19 12:17     ` Patrice CHOTARD
2024-04-09 15:01 ` [PATCH v1 09/25] ARM: dts: stm32: Clean led-red node " Patrice Chotard
2024-04-17  9:07   ` Patrick DELAUNAY
2024-04-19 12:21     ` Patrice CHOTARD
2024-04-09 15:02 ` [PATCH v1 10/25] ARM: dts: stm32: Add gpio-keys for stm32mp157a-dk1-scmi-u-boot Patrice Chotard
2024-04-17  9:07   ` Patrick DELAUNAY
2024-04-19 12:21     ` Patrice CHOTARD
2024-04-09 15:02 ` [PATCH v1 11/25] ARM: dts: stm32: Don't probe red led at boot " Patrice Chotard
2024-04-17  9:07   ` Patrick DELAUNAY
2024-04-19 12:21     ` Patrice CHOTARD
2024-04-09 15:02 ` [PATCH v1 12/25] ARM: dts: stm32: Update red led node " Patrice Chotard
2024-04-17  9:08   ` Patrick DELAUNAY
2024-04-19 12:21     ` Patrice CHOTARD
2024-04-09 15:02 ` [PATCH v1 13/25] ARM: dts: stm32: Add led-blue " Patrice Chotard
2024-04-17  9:09   ` Patrick DELAUNAY
2024-04-19 12:21     ` Patrice CHOTARD [this message]
2024-04-09 15:02 ` [PATCH v1 14/25] ARM: dts: stm32: Add gpio-keys for stm32mp157a-dk1-u-boot Patrice Chotard
2024-04-17  9:09   ` Patrick DELAUNAY
2024-04-19 12:26     ` Patrice CHOTARD
2024-04-09 15:02 ` [PATCH v1 15/25] ARM: dts: stm32: Don't probe red led at boot " Patrice Chotard
2024-04-17  9:09   ` Patrick DELAUNAY
2024-04-19 12:27     ` Patrice CHOTARD
2024-04-09 15:02 ` [PATCH v1 16/25] ARM: dts: stm32: Update red led node " Patrice Chotard
2024-04-17  9:10   ` Patrick DELAUNAY
2024-04-19 12:27     ` Patrice CHOTARD
2024-04-09 15:02 ` [PATCH v1 17/25] ARM: dts: stm32: Update u-boot, boot-led " Patrice Chotard
2024-04-17  9:10   ` [PATCH v1 17/25] ARM: dts: stm32: Update u-boot,boot-led " Patrick DELAUNAY
2024-04-19 12:27     ` Patrice CHOTARD
2024-04-09 15:02 ` [PATCH v1 18/25] ARM: dts: stm32: Add gpio-keys for stm32mp157c-ed1-u-boot Patrice Chotard
2024-04-17  9:11   ` Patrick DELAUNAY
2024-04-19 12:27     ` Patrice CHOTARD
2024-04-09 15:02 ` [PATCH v1 19/25] ARM: dts: stm32: Don't probe red led at boot " Patrice Chotard
2024-04-17  9:11   ` Patrick DELAUNAY
2024-04-19 12:27     ` Patrice CHOTARD
2024-04-09 15:02 ` [PATCH v1 20/25] ARM: dts: stm32: Update red led node " Patrice Chotard
2024-04-17  9:11   ` Patrick DELAUNAY
2024-04-19 12:27     ` Patrice CHOTARD
2024-04-09 15:02 ` [PATCH v1 21/25] ARM: dts: stm32: Add led-blue " Patrice Chotard
2024-04-17  9:11   ` Patrick DELAUNAY
2024-04-19 12:30     ` Patrice CHOTARD
2024-04-09 15:02 ` [PATCH v1 22/25] ARM: dts: stm32: Add gpio-keys for stm32mp157c-ed1-scmi-u-boot Patrice Chotard
2024-04-17  9:12   ` Patrick DELAUNAY
2024-04-19 12:30     ` Patrice CHOTARD
2024-04-09 15:02 ` [PATCH v1 23/25] ARM: dts: stm32: Don't probe red led at boot " Patrice Chotard
2024-04-17  9:13   ` Patrick DELAUNAY
2024-04-19 12:30     ` Patrice CHOTARD
2024-04-19 12:30   ` Patrice CHOTARD
2024-04-09 15:02 ` [PATCH v1 24/25] ARM: dts: stm32: Update red led node " Patrice Chotard
2024-04-17  9:13   ` Patrick DELAUNAY
2024-04-19 12:30     ` Patrice CHOTARD
2024-04-09 15:02 ` [PATCH v1 25/25] ARM: dts: stm32: Add led-blue " Patrice Chotard
2024-04-17  9:28   ` Patrick DELAUNAY
2024-04-19 12:32     ` Patrice CHOTARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e23ea82e-1ff1-41eb-adea-5ffdf7b4e2de@foss.st.com \
    --to=patrice.chotard@foss.st.com \
    --cc=patrick.delaunay@foss.st.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=uboot-stm32@st-md-mailman.stormreply.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox