From: Sean Anderson <seanga2@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH v4 15/17] common/board_r: Remove initr_serial wrapper
Date: Thu, 13 Aug 2020 21:54:15 -0400 [thread overview]
Message-ID: <e29927be-e506-0f22-69a8-464ef1633ee6@gmail.com> (raw)
In-Reply-To: <fec58610-5826-8a79-4ee5-bcc1c5506b76@gmail.com>
On 8/13/20 9:50 PM, Sean Anderson wrote:
> On 7/24/20 7:12 AM, Ovidiu Panait wrote:
>> Remove the initr_serial->serial_initialize indirection and call
>> serial_initialize directly.
>>
>> Reviewed-by: Simon Glass <sjg@chromium.org>
>> Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com>
>> ---
>>
>> common/board_r.c | 8 +-------
>> 1 file changed, 1 insertion(+), 7 deletions(-)
>>
>> diff --git a/common/board_r.c b/common/board_r.c
>> index 67dc25c7d2..79772135a4 100644
>> --- a/common/board_r.c
>> +++ b/common/board_r.c
>> @@ -187,12 +187,6 @@ static int initr_reloc_global_data(void)
>> return 0;
>> }
>>
>> -static int initr_serial(void)
>> -{
>> - serial_initialize();
>> - return 0;
>> -}
>> -
>> #if defined(CONFIG_PPC) || defined(CONFIG_M68K) || defined(CONFIG_MIPS)
>> static int initr_trap(void)
>> {
>> @@ -705,7 +699,7 @@ static init_fnc_t init_sequence_r[] = {
>> #endif
>> initr_dm_devices,
>> stdio_init_tables,
>> - initr_serial,
>> + serial_initialize,
>> initr_announce,
>> #if CONFIG_IS_ENABLED(WDT)
>> initr_watchdog,
>>
>
> This commit breaks my patch series [1]. I suspect it is the previous
> patch which does the breaking. Here are two versions of my series,
> with the only difference being that one is applied before this patch and
> the other after [2, 3]. As a few additional notes, this patch does *not*
> break booting without my series applied. In addition, setting
> CONFIG_LOGLEVEL to 5 or higher causes the board to start booting again.
>
> I am pretty confused by all this, as I never directly touch any serial
> code in my series. Further, I have no idea why it would start working
> again just by changing the loglevel.
>
> --Sean
>
> [1] https://patchwork.ozlabs.org/project/uboot/list/?series=185489
> [2] https://github.com/Forty-Bot/u-boot/tree/maix_gpio_good
> [2] https://github.com/Forty-Bot/u-boot/tree/maix_gpio_bad
>
+Heinrich can you verify this behavior?
--Sean
next prev parent reply other threads:[~2020-08-14 1:54 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 11:12 [PATCH v4 01/17] Kconfig: Introduce CONFIG_SYS_HAS_SRAM Ovidiu Panait
2020-07-24 11:12 ` [PATCH v4 02/17] Kconfig: Convert CONFIG_SYS_SRAM_BASE to Kconfig Ovidiu Panait
2020-08-07 2:14 ` Tom Rini
2020-07-24 11:12 ` [PATCH v4 03/17] Kconfig: Convert CONFIG_SYS_SRAM_SIZE " Ovidiu Panait
2020-08-07 2:14 ` Tom Rini
2020-07-24 11:12 ` [PATCH v4 04/17] Kconfig: Remove CONFIG_SYS_SRAM_START Ovidiu Panait
2020-08-07 2:14 ` Tom Rini
2020-07-24 11:12 ` [PATCH v4 05/17] cmd: bdinfo: Move sram info prints to generic code Ovidiu Panait
2020-08-07 2:15 ` Tom Rini
2020-07-24 11:12 ` [PATCH v4 06/17] board_f: Introduce setup_bdinfo initcall Ovidiu Panait
2020-08-07 2:15 ` Tom Rini
2020-07-24 11:12 ` [PATCH v4 07/17] board_f: Introduce arch_setup_bdinfo initcall Ovidiu Panait
2020-08-07 2:15 ` Tom Rini
2020-07-24 11:12 ` [PATCH v4 08/17] board_f: Factor out bdinfo bi_mem{start, size} to setup_bdinfo Ovidiu Panait
2020-07-24 12:14 ` Alexey Brodkin
2020-08-04 2:00 ` Simon Glass
2020-08-07 2:15 ` Tom Rini
2020-07-24 11:12 ` [PATCH v4 09/17] board_f: Move sram bdinfo assignments to generic code Ovidiu Panait
2020-08-07 2:15 ` Tom Rini
2020-07-24 11:12 ` [PATCH v4 10/17] board_f: m68k: Factor out m68k-specific bdinfo setup Ovidiu Panait
2020-08-07 2:15 ` Tom Rini
2020-07-24 11:12 ` [PATCH v4 11/17] board_f: ppc: Factor out ppc-specific " Ovidiu Panait
2020-08-07 2:15 ` Tom Rini
2020-07-24 11:12 ` [PATCH v4 12/17] board_f: Remove setup_board_part1 Ovidiu Panait
2020-08-07 2:15 ` Tom Rini
2020-07-24 11:12 ` [PATCH v4 13/17] dm: blk: Use IS_ENABLED() instead of #ifdefs in blk_post_probe Ovidiu Panait
2020-08-07 2:15 ` Tom Rini
2020-07-24 11:12 ` [PATCH v4 14/17] drivers: serial: Make serial_initialize return int Ovidiu Panait
2020-08-07 2:15 ` Tom Rini
2020-07-24 11:12 ` [PATCH v4 15/17] common/board_r: Remove initr_serial wrapper Ovidiu Panait
2020-08-07 2:16 ` Tom Rini
2020-08-14 1:50 ` Sean Anderson
2020-08-14 1:54 ` Sean Anderson [this message]
2020-07-24 11:12 ` [PATCH v4 16/17] blkcache: Extend blkcache_init to cover CONFIG_NEEDS_MANUAL_RELOC Ovidiu Panait
2020-08-07 2:16 ` Tom Rini
2020-07-24 11:12 ` [PATCH v4 17/17] common/board_r: Move blkcache_init call earlier in the boot sequence Ovidiu Panait
2020-08-07 2:16 ` Tom Rini
2020-08-07 2:14 ` [PATCH v4 01/17] Kconfig: Introduce CONFIG_SYS_HAS_SRAM Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e29927be-e506-0f22-69a8-464ef1633ee6@gmail.com \
--to=seanga2@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox