From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97BF1C433F5 for ; Fri, 17 Sep 2021 08:44:36 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8A41660EE0 for ; Fri, 17 Sep 2021 08:44:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8A41660EE0 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9BD0D831DB; Fri, 17 Sep 2021 10:44:33 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=suse.com header.i=@suse.com header.b="aSN2V3Na"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 88519831F7; Fri, 17 Sep 2021 10:44:31 +0200 (CEST) Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5D23F8319C for ; Fri, 17 Sep 2021 10:44:28 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=mbrugger@suse.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1631868268; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m5GEi6kfjI+2A/fibR5yG7wjURAGfRMMwLHUOl6tc9A=; b=aSN2V3NaxQWfm7vM0kh6Cyq+ChnWvMj+VzIqPFip+oj3uG1/Yqexah2coIYCMt2Qq8ne2t 4R/0YJgESVhcttzZUF8wZrz/t2B6cArUlr/4s9HTjvzMLpgkv2FLB8fehrX5yGsZXPcAED rBEEghq3aXPIywiw/XCtcHtraevaJ3k= Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2171.outbound.protection.outlook.com [104.47.17.171]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-39-qf4iC9xiNjSNAnxMXUg2WQ-1; Fri, 17 Sep 2021 10:44:26 +0200 X-MC-Unique: qf4iC9xiNjSNAnxMXUg2WQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mLMMkrF87tX+r8bKWAMPNIgVh+vwhQgHG05EcQsXO4Fdi6Ar+z/gnbLcAuom8T1VfMZzRvo3ETRzM90agKkkZPJtGhD7ZpfIu53QcfpBDhh6rkOP0iJZDC5mePs1qUiLqemPAdysjq4/BqJh+XW1HaVGHCiPY2ZVt57Hv+Sutiik/svpzNYuKsVStJQbG2QWYrEmF3AFEgk4rmBwcUvWhuSXHR/dU712Xm5dyDaMpNSI0SfKj1Mw9dbDPuHkMf7ckn0sPzLjBuxG3V2pBrWE9Li5JK/ukFBkHr56wf287gQrEdGllUbanR7M4Jbb0hJP46JWmdZ0MRrLyVy/2Cr7CA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=46uVUtP5y7HwYZDjx3DLc0eahGyQXUDBD+UUP6ydWyQ=; b=LXKFXvrl3dyr2jw2yzaxc/JoupG9Zbu+MC2ZiwpiZCUdSZZ6nOfnthyyPMwDB8bB+9grllnU2SH3IaYW4HFTerF9QHUaOIUWAwuZIHtEdgpPPXhzEEfAeqnYVSyVULDFrT7eANl3hVeLDTBQvrCBKZiBKHtTGIqAflb9qvfx3cpLT+WHR3RRp7b67Y/MKoUmV9pBjITVMNFY6nzrsVQDl1YWedkonmRsvFEICCxRfUeujNSBwUIG15aCjIlhjGDM5m7ELGxZp6Mx+XnLp0S7SxBwdFDp4gSOZhhfhYZekn64TpbmEx67ohFwCG+STvzagyaW1WdcKXIJedBETZizew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: samsung.com; dkim=none (message not signed) header.d=none;samsung.com; dmarc=none action=none header.from=suse.com; Received: from AM6PR04MB5366.eurprd04.prod.outlook.com (2603:10a6:20b:9d::19) by AM6PR04MB4758.eurprd04.prod.outlook.com (2603:10a6:20b:f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.16; Fri, 17 Sep 2021 08:44:25 +0000 Received: from AM6PR04MB5366.eurprd04.prod.outlook.com ([fe80::e9ae:619b:1fe9:46ce]) by AM6PR04MB5366.eurprd04.prod.outlook.com ([fe80::e9ae:619b:1fe9:46ce%6]) with mapi id 15.20.4500.019; Fri, 17 Sep 2021 08:44:25 +0000 Message-ID: Date: Fri, 17 Sep 2021 10:44:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.0.3 Subject: Re: [PATCH] arm: rpi: perform XHCI firmware upload only once Content-Language: en-US From: Matthias Brugger To: Marek Szyprowski , u-boot@lists.denx.de CC: Nicolas Saenz Julienne , Jaehoon Chung , Bartlomiej Zolnierkiewicz References: <20210917081943.13865-1-m.szyprowski@samsung.com> <1848d18e-c73c-c19f-0a1b-03c89e1ad725@suse.com> In-Reply-To: <1848d18e-c73c-c19f-0a1b-03c89e1ad725@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MR2P264CA0190.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501::29) To AM6PR04MB5366.eurprd04.prod.outlook.com (2603:10a6:20b:9d::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.2.177] (206.204.146.29) by MR2P264CA0190.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14 via Frontend Transport; Fri, 17 Sep 2021 08:44:25 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c4a29177-b64f-4dab-8d45-08d979b75ab1 X-MS-TrafficTypeDiagnostic: AM6PR04MB4758: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1923; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xcZ1WfomhiqlNlInO9Gz7+0Cgxn3uGvaRk4osZAeyqywg8vYidOWa79t7J7lULxO19zEgkX53DxZLhkGSgM6K8yDxgzwcCTGPxEDxBC2l17px8tpPQz5BlIv8GUVHuNagPDOJd0RH/yx6ghJw77iTJcQbf9Br6ldFEVG13yK3yCslRfvViMcTEnsViXI21e/h49IIpCBysNs6uZx6UwA9HdgA3S5gak/5D+yYJVKfaENSmn7A3UpFLBzzlVScW0eIQh8V0qxMr4x79Ot+hPw7zIaEPq8GB1cFgX+RdShDfc62SnVvB/GWWWM8He9vj2DoGAORY9ERtlcyflKXUgrW4USH7e+mR2CdQ1rPlgeU/9K7IHE9V9o54WlRSc1PD2wF+5bg+AxRWy3FPCCriWyPmex6EfFIM+jzVJN0rfxpUHijSVojPRHjT2lmp8sFFqg8EwJ7qIyKrnXcvAXIw0mlV5XfoV5rdEPdpbAgnpLUglHxV/TbI92J/UtRS9pg5VOT1HdvYFBZWRCroYb2KyKwnCL/sal1XUzSz6ZSIFdKV9sIwxqGXZhJi7PnZlKcLtkmYBEeATamUNNJ81mW6tZFtHRDgz770jbItkc+AW41dFRCka0i4qbvs1B8A4ckv1ypa7NbK/ARBa9+h+1solo7HdNFE4nkjVobcZ9KtryrQyv7utm75NaARB5hbkvzlRRf/Q296TiWzwT6PTStS9IxjBUEEVWZ1Ne7KwHLzmURC4= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR04MB5366.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(136003)(396003)(39860400002)(346002)(376002)(5660300002)(53546011)(66556008)(66476007)(66946007)(8936002)(8676002)(186003)(26005)(38100700002)(478600001)(4326008)(2906002)(54906003)(16576012)(316002)(6486002)(956004)(31686004)(36756003)(2616005)(86362001)(31696002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Ba1XOVdOR56eRqLpqHQljnls3eZAnpFjs0BPr4FqBv1CQ8WcKEMarxQ4NAbR?= =?us-ascii?Q?f8HYdacmUYrIpCzQI63Ki9rE5tS+mYVFgX5HpBgBGRvEMiIq0l6ntGsM5unD?= =?us-ascii?Q?rLmx4diCeJvSA2/OK40IXx4LYFnLqETsipJD4240L+DQHR108W6PvwvaVDLI?= =?us-ascii?Q?pgk7pXfMytgSM7ksdHikj0sJj8FdTNkFXPG5JZRbDkZ1Y6oOM69RiUGKa01f?= =?us-ascii?Q?gc5JGNdLWiy1Fah8hrMWWxkEw57PfkzntUNA5nKZL/AYsan15+80KWbzkmrj?= =?us-ascii?Q?h5yn9sdqyVfc0in9T3QimxoQtJ8v1bLAG9zNfQJnRbcNYg0d/DbzRqHQxyDy?= =?us-ascii?Q?5nEBsu8VczTp/EKkIiyJZNxF04t0U6R2gq2/z/1dKS136wxq0845ojkPFxVK?= =?us-ascii?Q?YK3r8mshKhIUmOfzTcef44cX6Lh3KnSmt5+H1GPIuwFCFuPtaNF5qfiSIJuH?= =?us-ascii?Q?FpGiw4IuhbXqO6PoB2IgBQ2Oijiur4bfRLmGfm9NAGU0x7RNKyisf1kfVRyZ?= =?us-ascii?Q?B501e97GkBfYe2A48Ny6FAVjCFF9Idmg+8g4LfcAt9FP5PHgA/QEb5PcHJM6?= =?us-ascii?Q?bhzg8E8NdDl6sLx/Zi83OFR7TOfxURHvx8iVOLUYhW31nibELJSd/EBtALtI?= =?us-ascii?Q?Hm5dgxG1xmINZaNrN6Ax9QxUvrdT64pGJzQJzpeeF5Fo2TBf/pU+ctET/3Ua?= =?us-ascii?Q?98KxQj8llEU85IKDogYevic31HjWqOVRTN+iQv4sW3ENez+itWzLxYnnzCCM?= =?us-ascii?Q?J8RlDnO4/Xm9yt+2behiXE4b2GkN+9cRNnHA1iPHSrX7tFlv46GkJ/qQlZhN?= =?us-ascii?Q?AsDFCPEpeVI2J52WP/fB3mnv3rcdUICeSERtOxYwHYtCV+b4V3/yshFArObk?= =?us-ascii?Q?OeXov9xwiBS4J7hj0bACJUgkaOTZXOpPPqLxAfqErsgC77b5UtRIgMf7En6E?= =?us-ascii?Q?cVwylMnEPJ8TKBYFRLM0xONXOlot1t6YnDiYrcr83c0JbHLstLbsym7Cs7w6?= =?us-ascii?Q?eXb0awVaokOlJdO2hFm9OJ/sgOp3HcfE/cX0HgVvVSuzQPn2CEMaSGdFRS+J?= =?us-ascii?Q?x4+MstDAjR+oRsbplMNm/JApwH0pWEK7K/cgwhrctgD4hxSXr+VSQ7y3Ov0d?= =?us-ascii?Q?kLjXC+n18l+mAAIqSDYtauEAsu05IrYbH7AqjohzyReqgXhFg4qfx+N0WDK+?= =?us-ascii?Q?LQEsuCLRd2xLNRntFrqC/RvJOsb7JdOYVCmha3C6u6O+euHWe8W/+WeJmHcP?= =?us-ascii?Q?eJ3Sv9d5nr7VaZgi55Xk+wVraGYBKrNXRIb89aTsUrB6QgGG44/va43UYv0T?= =?us-ascii?Q?sKQlHagNXORWVz2e78DJwVGl?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c4a29177-b64f-4dab-8d45-08d979b75ab1 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB5366.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Sep 2021 08:44:25.8416 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jN2fjfI10mDMjkUt4H5JkGw8hxGTfSl1xb9Lukh7sSx5XqW1LwbRbHBTnUcd5Q3hBVkAvLmvX1t/FsgEQYctvA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4758 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 17/09/2021 10:42, Matthias Brugger wrote: >=20 >=20 > On 17/09/2021 10:19, Marek Szyprowski wrote: >> XHCI firmware upload must be performed only once after initializing the >> PCI bridge. This fixes USB stack initialization after calling "usb stop; >> usb start" on Raspberry Pi 4B. >> >> Signed-off-by: Marek Szyprowski >=20 > Looks good to me. I'll wait a bit more to see if Nicolas can do a review = as well=20 > before queuing it. >=20 There was a race condition, I'll queque it now :) > Regards, > Matthias >=20 >> --- >> =C2=A0 arch/arm/mach-bcm283x/msg.c | 6 ++++++ >> =C2=A0 1 file changed, 6 insertions(+) >> >> diff --git a/arch/arm/mach-bcm283x/msg.c b/arch/arm/mach-bcm283x/msg.c >> index 347aece3cd..345f7fe2b7 100644 >> --- a/arch/arm/mach-bcm283x/msg.c >> +++ b/arch/arm/mach-bcm283x/msg.c >> @@ -170,6 +170,12 @@ int bcm2711_notify_vl805_reset(void) >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ALLOC_CACHE_ALIGN_BUFFER(struct msg_notif= y_vl805_reset, >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 msg_notify_vl805_reset, 1); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 int ret; >> +=C2=A0=C2=A0=C2=A0 static int done =3D false; >> + >> +=C2=A0=C2=A0=C2=A0 if (done) >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return 0; >> + >> +=C2=A0=C2=A0=C2=A0 done =3D true; >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 BCM2835_MBOX_INIT_HDR(msg_notify_vl805_re= set); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 BCM2835_MBOX_INIT_TAG(&msg_notify_vl805_r= eset->dev_addr, >>