From: "André Przywara" <andre.przywara@arm.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 11/12] Xilinx ZynqMP: fix minimum SDHCI frequency
Date: Wed, 16 Nov 2016 08:14:13 +0000 [thread overview]
Message-ID: <e39bdd72-e121-26cf-cd18-39493e7f29d4@arm.com> (raw)
In-Reply-To: <b17c5b48-c423-d324-640e-3a4b06cfff9c@xilinx.com>
On 16/11/16 06:37, Michal Simek wrote:
Hi Michal,
> On 16.11.2016 07:34, Michal Simek wrote:
>> Hi,
>>
>> On 16.11.2016 01:50, Andre Przywara wrote:
>>> It seems pretty odd that the minimum supported SDHCI frequency is
>>> the maximum frequency shifted _left_ by 9 bits.
>>> Shifting it right by that amount seems to make much more sense.
>>>
>>> Pointed out by GCC 6.2 as the value needs more than 32 bits.
>>>
>>> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
>>> ---
>>> include/configs/xilinx_zynqmp_ep.h | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/include/configs/xilinx_zynqmp_ep.h b/include/configs/xilinx_zynqmp_ep.h
>>> index 8e4b960..d0ce768 100644
>>> --- a/include/configs/xilinx_zynqmp_ep.h
>>> +++ b/include/configs/xilinx_zynqmp_ep.h
>>> @@ -14,7 +14,7 @@
>>> #define __CONFIG_ZYNQMP_EP_H
>>>
>>> #define CONFIG_ZYNQ_SDHCI_MAX_FREQ 52000000
>>> -#define CONFIG_ZYNQ_SDHCI_MIN_FREQ (CONFIG_ZYNQ_SDHCI_MAX_FREQ << 9)
>>> +#define CONFIG_ZYNQ_SDHCI_MIN_FREQ (CONFIG_ZYNQ_SDHCI_MAX_FREQ >> 9)
>>> #define CONFIG_ZYNQ_EEPROM
>>> #define CONFIG_SATA_CEVA
>>> #define CONFIG_ZYNQMP_XHCI_LIST {ZYNQMP_USB0_XHCI_BASEADDR, \
>>>
>>
>> thanks for the patch. We have fixed that in our internal repo but didn't
>> send this out yet.
>>
>> Here is the link
>> https://github.com/Xilinx/u-boot-xlnx/commit/299ceaf77ee6d5a555ecb5f129bd9248aa981837
>>
>> Definitely it is good patch and will apply.
>
> ok - it is already the part of my pull request I sent yesterday
> http://lists.denx.de/pipermail/u-boot/2016-November/272771.html
Even better!
Out of curiosity: How did you spot this? Was is actually causing
problems or was it GCC 6.x as well?
Anyway glad to see it fixed already.
Cheers,
Andre.
next prev parent reply other threads:[~2016-11-16 8:14 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-16 0:50 [U-Boot] [PATCH 00/12] Fix GCC 6.2 compiler warnings Andre Przywara
2016-11-16 0:50 ` [U-Boot] [PATCH 01/12] ls2080aqds: eth: add missing braces Andre Przywara
2016-11-16 18:00 ` york sun
2016-11-16 0:50 ` [U-Boot] [PATCH 02/12] mtd: cfi_flash: fix indentation Andre Przywara
2016-11-16 11:26 ` Stefan Roese
2016-11-16 18:01 ` york sun
2016-12-04 23:00 ` [U-Boot] [U-Boot,02/12] " Tom Rini
2016-11-16 0:50 ` [U-Boot] [PATCH 03/12] net: e1000: " Andre Przywara
2016-11-29 19:00 ` Joe Hershberger
2016-12-04 23:01 ` [U-Boot] [U-Boot,03/12] " Tom Rini
2016-11-16 0:50 ` [U-Boot] [PATCH 04/12] net: ldpaa_eth: add missing braces Andre Przywara
2016-11-16 18:02 ` york sun
2016-11-16 0:50 ` [U-Boot] [PATCH 05/12] net: rtl8169: remove unneeded definition Andre Przywara
2016-11-29 19:01 ` Joe Hershberger
2016-12-04 23:01 ` [U-Boot] [U-Boot, " Tom Rini
2016-11-16 0:50 ` [U-Boot] [PATCH 06/12] marvell: comphy_a3700: fix bitmask Andre Przywara
2016-11-16 11:32 ` Stefan Roese
2016-11-16 12:08 ` Kostya Porotchkin
2016-12-04 23:02 ` [U-Boot] [U-Boot,06/12] " Tom Rini
2016-11-16 0:50 ` [U-Boot] [PATCH 07/12] usb: eth: r8152_fw: fix indentation Andre Przywara
2016-11-16 11:20 ` Marek Vasut
2016-11-29 19:48 ` Joe Hershberger
2016-12-04 23:03 ` [U-Boot] [U-Boot,07/12] " Tom Rini
2016-11-16 0:50 ` [U-Boot] [PATCH 08/12] davinci: da8xxevm: " Andre Przywara
2016-12-04 23:04 ` [U-Boot] [U-Boot,08/12] " Tom Rini
2016-11-16 0:50 ` [U-Boot] [PATCH 09/12] phy: micrel: add missing braces Andre Przywara
2016-11-16 11:20 ` Marek Vasut
2016-11-16 0:50 ` [U-Boot] [PATCH 10/12] cmd: tpm_test: fix indentation Andre Przywara
2016-11-17 19:50 ` Simon Glass
2016-11-16 0:50 ` [U-Boot] [PATCH 11/12] Xilinx ZynqMP: fix minimum SDHCI frequency Andre Przywara
2016-11-16 6:34 ` Michal Simek
2016-11-16 6:37 ` Michal Simek
2016-11-16 8:14 ` André Przywara [this message]
2016-11-16 8:26 ` Michal Simek
2016-11-16 0:50 ` [U-Boot] [PATCH 12/12] usb: gadget: remove unused shortname variable Andre Przywara
2016-11-16 11:20 ` Marek Vasut
2016-11-16 11:49 ` Lukasz Majewski
2016-12-04 23:05 ` [U-Boot] [U-Boot, " Tom Rini
2016-12-04 23:06 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e39bdd72-e121-26cf-cd18-39493e7f29d4@arm.com \
--to=andre.przywara@arm.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox