From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D90B6C432BE for ; Tue, 31 Aug 2021 21:37:28 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0514F6101B for ; Tue, 31 Aug 2021 21:37:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0514F6101B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 49AE9831C7; Tue, 31 Aug 2021 23:37:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (1024-bit key; secure) header.d=walle.cc header.i=@walle.cc header.b="Jzg5tj+9"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id DA22C82F4D; Tue, 31 Aug 2021 23:37:24 +0200 (CEST) Received: from ssl.serverraum.org (ssl.serverraum.org [176.9.125.105]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6A2F3831D8 for ; Tue, 31 Aug 2021 23:37:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=michael@walle.cc Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id E006522234; Tue, 31 Aug 2021 23:37:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1630445839; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JU8da5I8k6H7J3LK9mgpWTPCtyBdrK/EfEocor0+5gQ=; b=Jzg5tj+9bRAdJTwI5SEnUWRWxZrHf1fjY4PCUWN1CurAd4ihokJCcWLgpDzwGWKWSisBaB L42JM8wo4KRLeIlNLzonsABEtPQKsOp1pjOxZKkOF1FIhWq/1CSOqIZnK04Jp/PvevDrUD FgSe1WpbfT8kY/UTSKDAnpKn6SEk9LY= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 31 Aug 2021 23:37:19 +0200 From: Michael Walle To: Vladimir Oltean Cc: u-boot@lists.denx.de, Jagan Teki , Priyanka Jain , Tom Rini , Peter Griffin , Manivannan Sadhasivam Subject: Re: [PATCH 7/9] serial: lpuart: add new compatible fsl, ls1028a-lpuart In-Reply-To: <20210831182851.bbr2zaa27rgoya72@skbuf> References: <20210831154028.1649864-1-michael@walle.cc> <20210831154028.1649864-8-michael@walle.cc> <20210831182851.bbr2zaa27rgoya72@skbuf> User-Agent: Roundcube Webmail/1.4.11 Message-ID: X-Sender: michael@walle.cc X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Am 2021-08-31 20:28, schrieb Vladimir Oltean: > On Tue, Aug 31, 2021 at 05:40:26PM +0200, Michael Walle wrote: >> The offical ls1028a binding of the driver uses the following as >> compatibles: >> compatible = "fsl,ls1028a-lpuart"; > > s/offical/official/ > >> diff --git a/drivers/serial/serial_lpuart.c >> b/drivers/serial/serial_lpuart.c >> index 2b473d70f6..3c9a69598a 100644 >> --- a/drivers/serial/serial_lpuart.c >> +++ b/drivers/serial/serial_lpuart.c >> @@ -553,6 +553,8 @@ static const struct dm_serial_ops >> lpuart_serial_ops = { >> static const struct udevice_id lpuart_serial_ids[] = { >> { .compatible = "fsl,ls1021a-lpuart", .data = >> LPUART_FLAG_REGMAP_32BIT_REG | LPUART_FLAG_REGMAP_ENDIAN_BIG }, >> + { .compatible = "fsl,ls1028a-lpuart", >> + .data = LPUART_FLAG_REGMAP_32BIT_REG }, > > The LS1028A LPUART is identical to LS1021A except for endianness, true. > So the U-Boot driver uses the "little-endian" OF property to clear the > LPUART_FLAG_REGMAP_ENDIAN_BIG flag from LS1021A, while the Linux driver > selects endianness based on compatible string. Yeah, and it seems that parsing of the little-endian flag was introduced just for the ls1028a. If that is true, one could remove that, but I wasn't sure, so I just left it there. >> { .compatible = "fsl,imx7ulp-lpuart", >> .data = LPUART_FLAG_REGMAP_32BIT_REG }, >> { .compatible = "fsl,vf610-lpuart"}, >> -- >> 2.30.2 > > Reviewed-by: Vladimir Oltean -- -michael