From: "Kathpalia, Tanmay" <tanmay.kathpalia@altera.com>
To: Eric Chung <eric.chung@riscstar.com>
Cc: u-boot-spacemit@groups.io, u-boot@lists.denx.de,
Tom Rini <trini@konsulko.com>, Peng Fan <peng.fan@nxp.com>,
Huan Zhou <pericycle.cc@gmail.com>,
Raymond Mao <raymond.mao@riscstar.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
Bhimeswararao Matsa <bhimeswararao.matsa@gmail.com>,
Kaustabh Chakraborty <kauschluss@disroot.org>,
Han Xu <han.xu@nxp.com>, Yanir Levin <yanir.levin@tandemg.com>,
Christoph Stoidner <c.stoidner@phytec.de>,
Balsundar Ponnusamy <balsundar.ponnusamy@altera.com>,
Daniel Palmer <daniel@thingy.jp>, Anshul Dalal <anshuld@ti.com>,
Bastien Curutchet <bastien.curutchet@bootlin.com>,
Angelo Dureghello <angelo@kernel-space.org>,
Johan Jonker <jbx6244@gmail.com>, Rick Chen <rick@andestech.com>,
Leo <ycliang@andestech.com>,
Sam Protsenko <semen.protsenko@linaro.org>,
Guodong Xu <guodong.xu@riscstar.com>,
Tim Ouyang <tim609@andestech.com>,
Leo Liang <leo.liang@sifive.com>
Subject: Re: [PATCH v3 3/9] mmc: sdhci: enable CMD23 for multi-block transfers
Date: Sun, 5 Jul 2026 23:58:22 +0530 [thread overview]
Message-ID: <e4b36ebd-d605-4e27-b3d4-8be6ffa39faa@altera.com> (raw)
In-Reply-To: <CAH22mJwTcvbvoR=Bp2VLm3tgVpVx+wNF9+y-ua37Vw50Qw2O0w@mail.gmail.com>
Hi Eric,
Glad the review feedback was useful.
I have some SD/eMMC spec background that could help make
the CMD23 implementation more complete. If you're
interested, I'd be happy to collaborate on the implementation
before you post v4.
Let me know.
Regards,
Tanmay Kathpalia
On 7/5/2026 8:51 PM, Eric Chung wrote:
> On Sun, Jul 5, 2026 at 5:52 PM Kathpalia, Tanmay
> <tanmay.kathpalia@altera.com> wrote:
>>
>> On 7/5/2026 11:37 AM, Eric Chung wrote:
>>> Enable the host controller's support for the CMD23 (SET_BLOCK_COUNT)
>>> command to manage multi-block read/write operations. This allows the
>>> MMC core to use CMD23 in preference to the legacy CMD18/CMD25 plus
>>> CMD12 sequence, reducing command overhead and improving I/O
>>> performance on multi-block transfers.
>> The commit message claims this enables "host controller" support, but the
>> changes are entirely in the MMC core (mmc.c) and header. No SDHCI host
>> driver sets MMC_CAP_CMD23 in this patch. mmc_write_blocks() in
>> mmc_write.c is not touched. CMD25 still always follows with CMD12.
>>
> Thanks. I'll apply all fixes.
next prev parent reply other threads:[~2026-07-05 18:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-05 6:07 [PATCH v3 0/9] spacemit mmc driver Eric Chung
2026-07-05 6:07 ` [PATCH v3 1/9] spacemit: k1: select boot device via config registers Eric Chung
2026-07-05 6:07 ` [PATCH v3 2/9] pinctrl: k1: add IO power domain configuration support Eric Chung
2026-07-05 6:07 ` [PATCH v3 3/9] mmc: sdhci: enable CMD23 for multi-block transfers Eric Chung
2026-07-05 9:51 ` Kathpalia, Tanmay
2026-07-05 15:21 ` Eric Chung
2026-07-05 18:28 ` Kathpalia, Tanmay [this message]
2026-07-05 6:07 ` [PATCH v3 4/9] mmc: k1: add sdhci platform driver Eric Chung
2026-07-05 10:20 ` Kathpalia, Tanmay
2026-07-05 6:07 ` [PATCH v3 5/9] dts: k1: add SD card support in u-boot overlay Eric Chung
2026-07-05 6:07 ` [PATCH v3 6/9] configs: k1: enable SD and eMMC support Eric Chung
2026-07-05 6:07 ` [PATCH v3 7/9] doc: spacemit: flash on K1 SoC based boards Eric Chung
2026-07-05 6:07 ` [PATCH v3 8/9] config: k1: enable ENV support for eMMC Eric Chung
2026-07-05 6:08 ` [PATCH v3 9/9] spacemit: k1: load product name from environment variable Eric Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4b36ebd-d605-4e27-b3d4-8be6ffa39faa@altera.com \
--to=tanmay.kathpalia@altera.com \
--cc=angelo@kernel-space.org \
--cc=anshuld@ti.com \
--cc=balsundar.ponnusamy@altera.com \
--cc=bastien.curutchet@bootlin.com \
--cc=bhimeswararao.matsa@gmail.com \
--cc=c.stoidner@phytec.de \
--cc=daniel@thingy.jp \
--cc=eric.chung@riscstar.com \
--cc=guodong.xu@riscstar.com \
--cc=han.xu@nxp.com \
--cc=jbx6244@gmail.com \
--cc=jh80.chung@samsung.com \
--cc=kauschluss@disroot.org \
--cc=leo.liang@sifive.com \
--cc=peng.fan@nxp.com \
--cc=pericycle.cc@gmail.com \
--cc=raymond.mao@riscstar.com \
--cc=rick@andestech.com \
--cc=semen.protsenko@linaro.org \
--cc=tim609@andestech.com \
--cc=trini@konsulko.com \
--cc=u-boot-spacemit@groups.io \
--cc=u-boot@lists.denx.de \
--cc=yanir.levin@tandemg.com \
--cc=ycliang@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox