From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andre Heider Date: Wed, 2 Sep 2020 09:11:52 +0200 Subject: [PATCH 2/2] pcie: pcie_advk: move setting of reference clock to the pcie driver In-Reply-To: <20200831075218.qth4f2o3j3jsmmv4@pali> References: <20200831032538.467336-1-a.heider@gmail.com> <20200831032538.467336-2-a.heider@gmail.com> <20200831075218.qth4f2o3j3jsmmv4@pali> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 31/08/2020 09:52, Pali Roh?r wrote: > On Monday 31 August 2020 05:25:38 Andre Heider wrote: >> From: Grzegorz Jaszczyk >> >> The settings of reference clock is done via pcie address space and not >> comphy address space - move the settings in appropriate place. >> >> This aligns hw initialization of pcie advk with Linux and also will allow >> to get rid of not comphy related operation from the comphy driver. >> >> Change-Id: I9cc2e8f3e415a880dfb01d10cc8db73b7e81a605 >> Signed-off-by: Grzegorz Jaszczyk >> Reviewed-on: http://vgitil04.il.marvell.com:8080/59619 >> Reviewed-by: Igal Liberman >> Tested-by: iSoC Platform CI >> [a.heider: adapt to mainline] >> Signed-off-by: Andre Heider >> --- >> Missing downstream patch, noticed while diffing branches: >> https://github.com/MarvellEmbeddedProcessors/u-boot-marvell/commit/e3d9c015d434f755578a86a4b6b3acd17d69238a > > It looks like this patch only moves initialization code from one file to > another. It is fixing some issue? I have tested PCIe on both MOX and > Espressobin and it worked fine. If there is no issue I would rather wait > for Marek comphy patches which should completely remove current marvell > comphy driver from u-boot. I just found out that Marek's patches cover this, so this patch can be dropped: https://patchwork.ozlabs.org/project/uboot/patch/20200419154850.25868-8-marek.behun at nic.cz/ Thanks, Andre