From: Christoph Niedermaier <cniedermaier@dh-electronics.com>
To: Tom Rini <trini@konsulko.com>
Cc: "u-boot@lists.denx.de" <u-boot@lists.denx.de>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Christian Marangi <ansuelsmth@gmail.com>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
"Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
Jerome Forissier <jerome.forissier@linaro.org>,
Joe Hershberger <joe.hershberger@ni.com>,
Marek Vasut <marex@denx.de>, Michal Simek <michal.simek@amd.com>,
"Patrick Delaunay" <patrick.delaunay@foss.st.com>,
Rasmus Villemoes <ravi@prevas.dk>, Simon Glass <sjg@chromium.org>,
Venkatesh Yadav Abbarapu <venkatesh.abbarapu@amd.com>
Subject: RE: [PATCH V4 0/3] cmd: env: select: Add output for available environment targets
Date: Fri, 18 Jul 2025 17:16:41 +0000 [thread overview]
Message-ID: <e7284037388042d089ded45ef18856ef@dh-electronics.com> (raw)
In-Reply-To: <073f00355c2d490ab8242e129d662ecf@dh-electronics.com>
From: Christoph Niedermaier
Sent: Friday, July 11, 2025 10:57 PM
> From: Tom Rini <trini@konsulko.com>
> Sent: Friday, July 11, 2025 7:41 PM
>> On Fri, Jul 11, 2025 at 05:37:55PM +0000, Christoph Niedermaier wrote:
>>> From: Tom Rini <trini@konsulko.com>
>>> Sent: Thursday, July 10, 2025 3:58 AM
>>>> Subject: Re: [PATCH V4 0/3] cmd: env: select: Add output for available environment targets
>>>>
>>>> On Mon, Jun 30, 2025 at 05:12:29PM +0200, Christoph Niedermaier wrote:
>>>>
>>>>> Add the "-l" parameter to the "env select" command to print the available
>>>>> environment targets, convert all argument parsing in the file nvedit.c to
>>>>> getopt() and check that with unit tests.
>>>>>
>>>>> The first patch converts the parsing of arguments to getopt() for all env
>>>>> commands. The second one adds unit tests for checking the env command.
>>>>> These were used to check the env commands before and after the conversion.
>>>>> The third patch adds the actual new parameter "-l" for the "env select"
>>>>> command.
>>>>>
>>>>> Christoph Niedermaier (3):
>>>>> cmd: nvedit: Convert the parsing of arguments to getopt()
>>>>> test: cmd: nvedit: Add basic unit tests
>>>>> cmd: env: select: Add output for available environment targets
>>>>
>>>> Can you please make a v5 that's run through CI? I saw that am64x_evm_a53
>>>> fails to build now and I'm seeing the tests fail too:
>>>> https://source.denx.de/u-boot/u-boot/-/jobs/1196652
>>>
>>> Sorry, I will have a look at it and make a new version.
>>> Are my patches also the cause of the build issue with am64x_evm_a53?
>>
>> Yes, something in the series was leading to at least that platform and
>> likely many others (I saw that in my local board testing, CI failed the
>> pipeline before getting to the world stage so I don't know all of the
>> ones that failed).
>
> OK, then I will also have a look at it.
> Thanks for the clarification.
I have submitted version 5, which should solve the problem with CI. I
could not reproduce the problem when building for am64x_evm_a53. I hope
that it will also be gone with version 5.
Thanks and regards
Christoph
prev parent reply other threads:[~2025-07-18 17:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-30 15:12 [PATCH V4 0/3] cmd: env: select: Add output for available environment targets Christoph Niedermaier
2025-06-30 15:12 ` [PATCH V4 1/3] cmd: nvedit: Convert the parsing of arguments to getopt() Christoph Niedermaier
2025-06-30 15:12 ` [PATCH V4 2/3] test: cmd: nvedit: Add basic unit tests Christoph Niedermaier
2025-06-30 15:12 ` [PATCH V4 3/3] cmd: env: select: Add output for available environment targets Christoph Niedermaier
2025-07-10 1:58 ` [PATCH V4 0/3] " Tom Rini
2025-07-11 17:37 ` Christoph Niedermaier
2025-07-11 17:41 ` Tom Rini
2025-07-11 20:56 ` Christoph Niedermaier
2025-07-18 17:16 ` Christoph Niedermaier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7284037388042d089ded45ef18856ef@dh-electronics.com \
--to=cniedermaier@dh-electronics.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ansuelsmth@gmail.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jerome.forissier@linaro.org \
--cc=joe.hershberger@ni.com \
--cc=marex@denx.de \
--cc=michal.simek@amd.com \
--cc=patrick.delaunay@foss.st.com \
--cc=ravi@prevas.dk \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=venkatesh.abbarapu@amd.com \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox