From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D62D7C7EE2F for ; Wed, 1 Mar 2023 18:35:04 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1151480EB1; Wed, 1 Mar 2023 19:35:02 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.b="SC2ZiTnA"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7B50A85637; Wed, 1 Mar 2023 19:35:00 +0100 (CET) Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C8979809A6 for ; Wed, 1 Mar 2023 19:34:57 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=afd@ti.com Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 321IYunl093736; Wed, 1 Mar 2023 12:34:56 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1677695696; bh=7ikGlw+CiInDADqyMxGVf9nO9Xsy6xh99j3wKsglT3M=; h=Date:Subject:To:References:From:In-Reply-To; b=SC2ZiTnAmCvZvTk2ltBWYkl7bQXBkFNuPqBmMvOybo8ixvJrU6J+mN6DOD7tsniY6 WjnW97+hpinMj2ZB6xN2NOgTfs+z0h+X/yKl/ofiV7TnxCIdVvQRU2J2J3bkQB6/YL 7CtzUftDWftYa4qgSzoq9Qg0XfDmZ1nJqtXOUMzs= Received: from DLEE102.ent.ti.com (dlee102.ent.ti.com [157.170.170.32]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 321IYuoN032544 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 1 Mar 2023 12:34:56 -0600 Received: from DLEE114.ent.ti.com (157.170.170.25) by DLEE102.ent.ti.com (157.170.170.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Wed, 1 Mar 2023 12:34:55 -0600 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE114.ent.ti.com (157.170.170.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Wed, 1 Mar 2023 12:34:56 -0600 Received: from [10.249.33.186] (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 321IYtv8011444; Wed, 1 Mar 2023 12:34:55 -0600 Message-ID: Date: Wed, 1 Mar 2023 12:34:55 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH V7 01/15] board: siemens: iot2050: Split the build for PG1 and PG2 Content-Language: en-US To: Jan Kiszka , U-Boot Mailing List References: <6b4e3ad5fcb37bab55d5ad7e0d9fa7d934bfd580.1677608363.git.jan.kiszka@siemens.com> <35946e9b-061d-930b-835b-a5eee10e2f57@siemens.com> From: Andrew Davis In-Reply-To: <35946e9b-061d-930b-835b-a5eee10e2f57@siemens.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 3/1/23 12:29 PM, Jan Kiszka wrote: > On 01.03.23 18:26, Andrew Davis wrote: >> On 2/28/23 12:19 PM, Jan Kiszka wrote: >>> From: Su Baocheng >>> >>> Due to different signature keys, the PG1 and the PG2 boards can no >>> longer use the same FSBL (tiboot3). This makes it impossible anyway to >>> maintaine a single flash.bin for both variants, so we can also split the >>> build. >>> >> >> Having two defconfigs just to make the small changes needed will be >> more burden than it saves. Keeping them in sync and having your integration >> layer do two different builds just adds more work than it is worth IMHO. >> >> We (TI) are going in that direction for our HS boards and combining the >> defconfigs back together now. The solution is to have the one defconfig >> build both images, one for HS and one for non-HS. For you looks like you >> are already calling the two PG boot images differently so this should work >> (seboot_pg1.bin and seboot_pg2.bin). Just add a new full entry in >> boot-image.dtsi for each (vs that #ifdef check changing the output name). > > How should that work? Will we somehow get two flash.bin out of a single > build then? > Yes if you add two enteries in your image.dtsi file. Then your integration selects the right named one for the board, instead of selecting the right defconfig for the board and doing a completely new build. Andrew