From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mmc: uniphier-sd: Add vqmmc regulator support
Date: Mon, 25 Sep 2017 18:47:58 +0200 [thread overview]
Message-ID: <e8a3cf10-2ef5-14b6-5ed8-8ac6603eb544@gmail.com> (raw)
In-Reply-To: <20170915191054.28337-1-marek.vasut+renesas@gmail.com>
On 09/15/2017 09:10 PM, Marek Vasut wrote:
> Add initial support for setting the vqmmc regulator. Since we do not
> support 1V8 modes, set the regulator to 3V3 and enable it.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
> Cc: Jaehoon Chung <jh80.chung@samsung.com>
Anything ?! I don't see this in the PR ...
> ---
> drivers/mmc/uniphier-sd.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/drivers/mmc/uniphier-sd.c b/drivers/mmc/uniphier-sd.c
> index 3c52161067..0d1203cb76 100644
> --- a/drivers/mmc/uniphier-sd.c
> +++ b/drivers/mmc/uniphier-sd.c
> @@ -14,6 +14,7 @@
> #include <linux/dma-direction.h>
> #include <linux/io.h>
> #include <linux/sizes.h>
> +#include <power/regulator.h>
> #include <asm/unaligned.h>
>
> DECLARE_GLOBAL_DATA_PTR;
> @@ -756,6 +757,9 @@ static int uniphier_sd_probe(struct udevice *dev)
> fdt_addr_t base;
> struct clk clk;
> int ret;
> +#ifdef CONFIG_DM_REGULATOR
> + struct udevice *vqmmc_dev;
> +#endif
>
> base = devfdt_get_addr(dev);
> if (base == FDT_ADDR_T_NONE)
> @@ -765,6 +769,15 @@ static int uniphier_sd_probe(struct udevice *dev)
> if (!priv->regbase)
> return -ENOMEM;
>
> +#ifdef CONFIG_DM_REGULATOR
> + ret = device_get_supply_regulator(dev, "vqmmc-supply", &vqmmc_dev);
> + if (!ret) {
> + /* Set the regulator to 3.3V until we support 1.8V modes */
> + regulator_set_value(vqmmc_dev, 3300000);
> + regulator_set_enable(vqmmc_dev, true);
> + }
> +#endif
> +
> ret = clk_get_by_index(dev, 0, &clk);
> if (ret < 0) {
> dev_err(dev, "failed to get host clock\n");
>
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2017-09-25 16:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-15 19:10 [U-Boot] [PATCH] mmc: uniphier-sd: Add vqmmc regulator support Marek Vasut
2017-09-25 16:47 ` Marek Vasut [this message]
2017-09-26 7:41 ` Jaehoon Chung
2017-09-27 15:19 ` Masahiro Yamada
2017-09-27 15:50 ` Marek Vasut
2017-09-27 16:13 ` Masahiro Yamada
2017-09-27 19:29 ` Marek Vasut
2017-09-29 2:30 ` Jaehoon Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8a3cf10-2ef5-14b6-5ed8-8ac6603eb544@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox