From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D630C47082 for ; Tue, 8 Jun 2021 11:05:07 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9C1FA61289 for ; Tue, 8 Jun 2021 11:05:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C1FA61289 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=xilinx.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7FBBF82D2D; Tue, 8 Jun 2021 13:05:03 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=xilinx.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="dfufNuJ2"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2EF1682D58; Tue, 8 Jun 2021 13:05:01 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2060b.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe59::60b]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E72E58203F for ; Tue, 8 Jun 2021 13:04:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=xilinx.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=michals@xilinx.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i2mf8TRdR6ndEMEVdWEm1wQu2BDBqluhbsglmY8gkcvdT1aU/VLyNkQrGPtoPu1bsFDuqtnJCGcBD2ebLfSA4wJs5edocnlEcbQWYJoItBhsM8D4gGKeC0B4swBXwOYXKoL6ho00tAEAKB/8ofaKDdQo203YJ27Og5AV8jKRHXUEZ+6wIxiXXcftw/mlzBkJj4SfuipUX4ybi4ie+YFpG7AAcWIQ2f3qDtdfSrg3EjcR41HOuCWpo6/ado4cSgGMiCQYu9kz6IlYzLBUSQVJmeVjeF4JyaQgje5eQLD3LJ3mx/QO1v9brKufInNLNyTtlbENJCZlNALmvStpFUcMYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BrxMS6NMQj4kUDJdHhL59vKr/T/FrUHLf7mHSAJgdD8=; b=j5MxRAYe4WrnbcgSi+gvQyuUdAYDjHG5M0eJX0gULfoE9iDSrmYEbszr5lLqPFULQLJf2GrrCXtQuAZfwGEglMt1su1RMp5a9ilrn3jj+TqFoBKyeaDyS8QQHqRyUgRgB8mAasHS5YUNsegWDSkbq7GCHFmhA2Oet0TupXPq0ABkUUUJ0lhvyumkfJoWeZ2+3Gtksj2l0vI6X9lMIrg1hoNlqWjqq8Nvl/pcMR3+rdRCRbtAMY681Nv0sPoHbCHg2+kNLtvBDB9Hvm1Ff/Q/JbQNNZGDQr5C4bb/rtlmXNRLqHGHtwqMN/wDzM+WA9zU5KVmedEUFnN0ibIf+37k4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=lists.denx.de smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BrxMS6NMQj4kUDJdHhL59vKr/T/FrUHLf7mHSAJgdD8=; b=dfufNuJ2R1flTAk+EzpTBAqbdBZAZa5VwkaLs8G9C2HMoFqWPuO8uoyEu7okznVpSN+xGBfUGwYTK4fPEFBQ3PWzabKY0JjZvJsc60S+Phf2SDkioXttP7r2aJmPHz5ihN6i8m8rd7SwZzNsjHSBSbisJM7APE8xxbIFBv1KXBc= Received: from DM6PR02CA0090.namprd02.prod.outlook.com (2603:10b6:5:1f4::31) by DM5PR02MB3784.namprd02.prod.outlook.com (2603:10b6:4:bb::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4195.29; Tue, 8 Jun 2021 11:04:52 +0000 Received: from DM3NAM02FT026.eop-nam02.prod.protection.outlook.com (2603:10b6:5:1f4:cafe::5b) by DM6PR02CA0090.outlook.office365.com (2603:10b6:5:1f4::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.20 via Frontend Transport; Tue, 8 Jun 2021 11:04:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; lists.denx.de; dkim=none (message not signed) header.d=none;lists.denx.de; dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com; Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by DM3NAM02FT026.mail.protection.outlook.com (10.13.5.129) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4195.18 via Frontend Transport; Tue, 8 Jun 2021 11:04:52 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 8 Jun 2021 04:04:48 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.2 via Frontend Transport; Tue, 8 Jun 2021 04:04:48 -0700 Envelope-to: u-boot@lists.denx.de, jorge@foundries.io Received: from [172.30.17.109] (port=37252) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1lqZXL-0003V4-RM; Tue, 08 Jun 2021 04:04:48 -0700 Subject: Re: Zynq UltraScale MPSoC, DMA driver To: "Jorge Ramirez-Ortiz, Foundries" CC: , References: <20210607162748.GA13505@trex> <20210607184142.GA568@trex> From: Michal Simek Message-ID: Date: Tue, 8 Jun 2021 13:04:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210607184142.GA568@trex> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: eebb0ce1-1ad7-4900-2605-08d92a6d3da5 X-MS-TrafficTypeDiagnostic: DM5PR02MB3784: X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mhR55dNv23dniqL9L9sfff2ZIbLdf9MFCqhN1zWQJumOm4F6UlYVSM/aP3F2syYBi+WUcMbHHlalSKBlA+GycyvAzzrmNOTX4cX2gWoOBmyC8VgjaO8l0BhDFtD5GbazG9lqkWWzGy5o/hfQfCf2iH5n/beWl/7VEycaB1cV9TN/SUTf2IxZSC/O57lIvY9m2fDwLetEFeLCP/1w28uynHWcvgeWFYO6E+nexwNsLtYm3/AjWk9feWIATbvQb/1rsZ99ho7f41/B3Vh3I1cJuiETc0fWgnQMt7AGf/QjHHekyCV813UE4hWQzZh6Zm+wwFjyfvKLhVPtyiqm+rs9pcHh1Oz/072pXS98w6FN5WlYeAJq4rW20PU1/lZoDTe9O2vKRJr7rbU1KK6o/6v6mUSu/9WH+o0CZT7RIN9ZnjEXnGPIImMxNQtSZOM6zHEcQNSAAZwl1bsQkMLsZpESkFjWfZ1h63wJs0fKoTWluwJ5YfLWR4ZwpbKCf/1JNsx1Hs5swmJ4+uV7+pxnaqIuuWeeE7/ab4nP87Yr3VWVY/jAtRlwTM6W+i+bPBHUqiGUQc5/crEtjjkbR/bdfnwZF/WLCaOwNt/QtzRUPw2zqQNpbEqeHdu7ZG5VQQsHsD+nKz/ngI6m694F4GQeGSoYiyHQMLn0M5zUMqZ6AxJ/wROVosO0I1mS/tV5ScRk+6B3DTEJsoFmYcqxLxCbBV4mBw== X-Forefront-Antispam-Report: CIP:149.199.62.198; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:xsj-pvapexch02.xlnx.xilinx.com; PTR:unknown-62-198.xilinx.com; CAT:NONE; SFS:(4636009)(346002)(39850400004)(396003)(376002)(136003)(36840700001)(46966006)(83380400001)(36860700001)(82310400003)(53546011)(4326008)(47076005)(336012)(2906002)(426003)(9786002)(186003)(7636003)(44832011)(70206006)(356005)(8676002)(31686004)(478600001)(31696002)(8936002)(54906003)(2616005)(36906005)(26005)(70586007)(6916009)(316002)(5660300002)(36756003)(82740400003)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2021 11:04:52.2771 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: eebb0ce1-1ad7-4900-2605-08d92a6d3da5 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.62.198]; Helo=[xsj-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT026.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR02MB3784 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean Hi, On 6/7/21 8:41 PM, Jorge Ramirez-Ortiz, Foundries wrote: > On 07/06/21, Jorge Ramirez-Ortiz, Foundries wrote: >> hi Michal >> >> um, when we exchanged emails about enabling ECC support for MPSoC, I >> left with the understanding that there already was a DMA driver >> available in u-boot that I could use to initialize the memory. >> >> do you have something in the works or will I have to write such a >> driver? compatible would be 'xlnx,zynqmp-dma-1.0' > > alternatively, would it be acceptable - upstream - If I just init ECC > as done by FSBL (ie, without a proper DMA driver, just accessing the > controller)? There are 2 things here. The first thing that would be the best to do it proper framework which is likely dma where dma_memset should be likely added. The second that this code should land in SPL which can't be big that's why this feature should be very small. Based on above I think that would be good to have long term both of them in the tree. It means feel free to send short version and let's look at it and dma one should be hopefully pretty much using the same code via dma framework. Thanks, Michal