From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76AA7C77B7F for ; Wed, 17 May 2023 10:47:02 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7A96C866D2; Wed, 17 May 2023 12:47:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=collabora.com header.i=@collabora.com header.b="gxomZmEk"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7C420866DC; Wed, 17 May 2023 12:46:59 +0200 (CEST) Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E1E9B8621D for ; Wed, 17 May 2023 12:46:56 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=eugen.hristev@collabora.com Received: from [192.168.18.121] (unknown [46.8.172.197]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: ehristev) by madras.collabora.co.uk (Postfix) with ESMTPSA id 34F42660563D; Wed, 17 May 2023 11:46:56 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1684320416; bh=1zbemSkQTyN3PFBQXhUGM0v1kLrfwNeYb0oT7TxMzqE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=gxomZmEknrNXtM/fO8OGMIlcWgSfYkkIhVx7TZgRDcA4lsCgMN8Q5riLffjSN/2Pz SNYE7sbFuz6aywM6hskKrQs6IPF7EwKiLGpBUSD33K1HzvlWPwXI4pYtZKblwYp38x SQ/X5EKBcNfT2IPwy+FxYALHCc+HrXilXQswijj1rbAKvNY7KdHQV8SQI80Lp1CUVz TwR5oovzcIN4xZTVEbgTTPJX2xTvgM+L5aZlnlry89MREwC1Ev3wmSeoEkqsXm9QhP TzyvFjgFjiByiY4qbLtE+xhWS/q3eEfXPy602PiZZX08jB9bfVacj1SerZvcwMDZ8x DWd0g4miure3g== Message-ID: Date: Wed, 17 May 2023 13:46:53 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 2/2] configs: rock5b-rk3588: add rtl8169 driver Content-Language: en-US To: Tom Rini Cc: u-boot@lists.denx.de, joe.hershberger@ni.com, jonas@kwiboo.se, jagan@edgeble.ai, kever.yang@rock-chips.com References: <20230425130659.62361-1-eugen.hristev@collabora.com> <20230425130659.62361-2-eugen.hristev@collabora.com> <20230505220303.GA2499096@bill-the-cat> <225e8cbc-8694-2465-3e63-f1833a098d93@collabora.com> <20230515125246.GA3036637@bill-the-cat> <72d2bf6c-f1ab-8849-405b-ee013ed8d049@collabora.com> <20230515131616.GB2398826@bill-the-cat> From: Eugen Hristev In-Reply-To: <20230515131616.GB2398826@bill-the-cat> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 5/15/23 16:16, Tom Rini wrote: > On Mon, May 15, 2023 at 03:57:14PM +0300, Eugen Hristev wrote: >> On 5/15/23 15:52, Tom Rini wrote: >>> On Mon, May 15, 2023 at 03:36:24PM +0300, Eugen Hristev wrote: >>>> On 5/6/23 01:03, Tom Rini wrote: >>>>> On Tue, Apr 25, 2023 at 04:06:59PM +0300, Eugen Hristev wrote: >>>>>> Add the rtl8169 driver, which supports the rtl8125b device, which is >>>>>> connected on the pciE bus on this board. >>>>>> Enable also CONFIG_SYS_HAS_NONCACHED_MEMORY to have the descriptors stored. >>>>>> >>>>>> Signed-off-by: Eugen Hristev >>>>>> --- >>>>>> configs/rock5b-rk3588_defconfig | 2 ++ >>>>>> 1 file changed, 2 insertions(+) >>>>>> >>>>>> diff --git a/configs/rock5b-rk3588_defconfig b/configs/rock5b-rk3588_defconfig >>>>>> index a14fcd2ee924..bfa48227aee2 100644 >>>>>> --- a/configs/rock5b-rk3588_defconfig >>>>>> +++ b/configs/rock5b-rk3588_defconfig >>>>>> @@ -1,5 +1,6 @@ >>>>>> CONFIG_ARM=y >>>>>> CONFIG_SKIP_LOWLEVEL_INIT=y >>>>>> +CONFIG_SYS_HAS_NONCACHED_MEMORY=y >>>>>> CONFIG_COUNTER_FREQUENCY=24000000 >>>>>> CONFIG_ARCH_ROCKCHIP=y >>>>>> CONFIG_TEXT_BASE=0x00a00000 >>>>>> @@ -71,6 +72,7 @@ CONFIG_MMC_SDHCI_SDMA=y >>>>>> CONFIG_MMC_SDHCI_ROCKCHIP=y >>>>>> CONFIG_SPI_FLASH_MACRONIX=y >>>>>> CONFIG_ETH_DESIGNWARE=y >>>>>> +CONFIG_RTL8169=y >>>>>> CONFIG_GMAC_ROCKCHIP=y >>>>>> CONFIG_PCI=y >>>>>> CONFIG_PCIE_DW_ROCKCHIP=y >>>>> >>>>> Does this depend on some series I missed where PCI is enabled on this >>>>> config? >>>>> >>>> >>>> Hi Tom, >>>> >>>> the network device is connected on PCI express, that is right. I have a >>>> separate series for that. >>>> However, the network driver itself and the enabling of the network driver is >>>> somewhat independent, so I sent it as a separate series (this one ) >>>> I think the config patch can go through rockchip custodian tree. >>> >>> With 1/2 now applied this results in failure to build due to DM_PCI not >>> being enabled. >>> >> >> This is most strange. 1/2 are just changes in the driver. How does that >> cause a build failure ? >> The driver is not even selected for this config in 2/2, before the actual >> patch. >> Do you have the log of the failure so I can have a look ? > > I don't have the log handy right now, please re-test the config changes > on top of master and repost. > Hi Tom, I figured out the issue. My patch is indeed based on another patch that selects CONFIG_PCI. However, the rtl8169 driver depends on PCI, even if it does not have 'depends on PCI' in the Kconfig. So selecting it without PCI, well, the error. So I sent another patch : https://patchwork.ozlabs.org/project/uboot/patch/20230517104124.111075-1-eugen.hristev@collabora.com/ ... that should have the rtl8169 depend on PCI now. That being said, this current patch can be applied on kever's rockchip master branch on top of PCI series, but if it's to be applied on master, it should work on top of the 'rtl8169 depends on PCI' patch now. I hope it makes sense. Thanks