From: Frieder Schrempf <frieder.schrempf@kontron.de>
To: u-boot@lists.denx.de
Subject: [PATCH 1/4] Respect that some compression algos can be enabled separately for SPL
Date: Wed, 27 Jan 2021 08:57:33 +0100 [thread overview]
Message-ID: <ea84d79d-4d44-6c8e-44d0-abfd6056457c@kontron.de> (raw)
In-Reply-To: <CAJ+vNU1BsFaQWktzJxyhLZHSFpstmCwV1v7QeUwOUZABLVzK6Q@mail.gmail.com>
On 26.01.21 18:53, Tim Harvey wrote:
> On Sat, Jan 23, 2021 at 4:39 AM Stefano Babic <sbabic@denx.de> wrote:
>>
>> Hi Tim,
>>
>> there is a weird side effect with this patch, breaking m68k
>> architecture. For some reason, image.c is not compiled clean because gd
>> is not declared anymore.
>>
>> In file included from tools/common/image.c:1:
>> ./tools/../common/image.c: In function ?get_table_entry_id?:
>> ./tools/../common/image.c:982:41: error: ?gd? undeclared (first use in
>> this function)
>> 982 | if (t->sname && strcasecmp(t->sname + gd->reloc_off, name) == 0)
>> | ^~
>> ./tools/../common/image.c:982:41: note: each undeclared identifier is
>> reported only once for each functi
>>
>> Can you take a look ? Thanks !
>>
>
> Stefano,
>
> I have no idea what could cause this... must be something to do with
> including kconfig.h?
>
> What board/target would I build to reproduce this?
>
> Frieder, do you have any ideas?
I can't remember if I did a full test on all platforms when I wrote this
patch. Probably not.
And I have no idea what is causing this, nor do I currently have the
time to have a closer look, sorry.
BTW, this is a very good example for what I said earlier:
"I failed to do upstreaming work for U-Boot for quite some time. Mainly
because whenever I try to, I end up fixing/cleaning some weird U-Boot
code/behavior and spending way more time than I actually have available."
next prev parent reply other threads:[~2021-01-27 7:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 17:00 [PATCH 0/4] Add Gateworks Venice board support Tim Harvey
2021-01-13 17:00 ` [PATCH 1/4] Respect that some compression algos can be enabled separately for SPL Tim Harvey
2021-01-23 12:39 ` Stefano Babic
2021-01-26 17:53 ` Tim Harvey
2021-01-27 7:57 ` Frieder Schrempf [this message]
2021-01-27 13:19 ` Stefano Babic
2021-01-30 21:22 ` Stefano Babic
2021-02-04 17:31 ` Tim Harvey
2021-02-04 20:49 ` Stefano Babic
2021-02-05 1:37 ` Tim Harvey
2021-01-13 17:00 ` [PATCH 2/4] power: pmic: add driver for Monolithic Power mp5416 Tim Harvey
2021-01-14 22:08 ` Jaehoon Chung
2021-01-14 22:10 ` Tim Harvey
2021-01-13 17:00 ` [PATCH 3/4] arm: dts: imx8mm: add Gateworks i.MX8 Mini Dev kits Tim Harvey
2021-01-13 17:00 ` [PATCH 4/4] board: gateworks: imx8mm: Add Gateworks Venice board support Tim Harvey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea84d79d-4d44-6c8e-44d0-abfd6056457c@kontron.de \
--to=frieder.schrempf@kontron.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox