From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C51AC6FA86 for ; Thu, 22 Sep 2022 10:30:27 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 095F484CD9; Thu, 22 Sep 2022 12:30:25 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="kqyZMVuE"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 26AF684CD7; Thu, 22 Sep 2022 12:30:23 +0200 (CEST) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2080.outbound.protection.outlook.com [40.107.102.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5FA2384CCE for ; Thu, 22 Sep 2022 12:30:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=michal.simek@amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TCIaa23ZUU9stPZfROLECUg+ScKB1EYbgaJP8/c6cKumdxw0Lw1bOu/F82SlHzo2AgdDy+ioQ9aWi0deLIzQZyeUYCNwERgcgQT/DwuS9krRG9mnvb5oXaH3hO6U5esDnBfGrljiZM95n2F7xrRuQ5dYV/TaeCbn9v5UJnWputM/wFZD9Lvq0Nt27VF20M/6NbdJ3HEadWYo6J2kGJ6L7SiYvAAblD4ScFI28UWiw8S143uy3A04fbSnroH36HIL6hyaBXo56bwKhGx3D2XmJkOw2vxfH0FM5YvT32OZuw1Uzd0/ioLWSOx6Ua1aTwjF4pzLezKWKEI9NvhaSBpN0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mvFYWRiOYe68cCuONMjeP2pz0eReBboenlfsaI+UeCw=; b=W06/xtHnhohz8EjZw0mhnJNHaVp4bZccOyf5UwsX4MDhll2Gqc6DPIrEPtcxhgJEkgAM43d5C9bPIzC1HWpo6rZo6dkqSfQEmw4GhYA8Ry7Kzg8pojolwH+iCSjjLC4c/oGCk+1SfQN0X+KPqoDfrXv8oSeUslhuhpIs2fbd6uDOHLQUE0+qRCBzr2bzH36Uf3YUiX1ZowzXd4ws3RLuNZFXwL25jzD5VKRWoJFbGAa7agDBxCq2SUKlat6E+IVJM7PYnFRzc0E/kDNKj9iDaG0rxLYiH5fTCJ01G/wlIMjBa7Uw9BrV2w7bt+br2eRM9FH6zEL/+FYeXnj4zdo8dg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=thorsis.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mvFYWRiOYe68cCuONMjeP2pz0eReBboenlfsaI+UeCw=; b=kqyZMVuElDJ1hbRt16jfBh7Enb2QDbbBYmHjwCsdDaUb5CCdkejMCbZJQ00bgcMVHduyR1iuoXMdf/44hWrtHhabvppdJoThco6UhZ9u8gwHxt+iveW26vKPqTWqzTB9HHcxqOoVK18NsWCaRf6sFCGWu02RyUtSH1VNh/SEbhM= Received: from BN8PR04CA0042.namprd04.prod.outlook.com (2603:10b6:408:d4::16) by CO6PR12MB5473.namprd12.prod.outlook.com (2603:10b6:303:13e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.19; Thu, 22 Sep 2022 10:30:13 +0000 Received: from BN8NAM11FT019.eop-nam11.prod.protection.outlook.com (2603:10b6:408:d4:cafe::14) by BN8PR04CA0042.outlook.office365.com (2603:10b6:408:d4::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.18 via Frontend Transport; Thu, 22 Sep 2022 10:30:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT019.mail.protection.outlook.com (10.13.176.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5654.14 via Frontend Transport; Thu, 22 Sep 2022 10:30:12 +0000 Received: from [10.254.241.52] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 22 Sep 2022 05:30:10 -0500 Message-ID: Date: Thu, 22 Sep 2022 12:30:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: [PATCH v2 8/8] fpga: virtex2: Use logging feature instead of FPGA_DEBUG Content-Language: en-US To: Alexander Dahl , CC: Simon Glass References: <20220921132216.7089-1-ada@thorsis.com> <20220921132216.7089-9-ada@thorsis.com> From: Michal Simek In-Reply-To: <20220921132216.7089-9-ada@thorsis.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT019:EE_|CO6PR12MB5473:EE_ X-MS-Office365-Filtering-Correlation-Id: bfbf2757-3dcd-46bd-3c01-08da9c856ec6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: P6NzmIL2OjQN8uc4lWyh9LToOVSAVB07YKpsERWchqDe56+q9mAR1yIyrwnOuO8gnvjIQFSSpBibbd9TefWEcRF7DhQcKoP3sjNWNW7P6er+RsqZFcnzyAfviHqjiwap3g5avuJswHpV1o5SqJu8BfBcPizfaW+K95VDbJNKql2uBpdI99lyCbSR7jQm2NubCf7uF982qkxY20TRb86NbL+qcY07GYfffcihE4XmgL1f26oYnqIJTnThXHV77RPJ0aXhATWjTrm0KKygMAozC71hImsB/3xFRnIFtOVfhJyiCC3HARmyRvTf1beOOIIywmi+KKaQpSn17dnsaVjfySN0n0wXyVM9MjWjf30YnIsnuOqQ/uc8gQVLhjH0Cd6VMKkT0rg/CNZTam1gkSHvQ2pbSIDBQBsL+tjnJn+VCFj400aROh4dQqcNiphbMJKRSe0Qklcz4oBDKzMtLij6qpYtBkPyF1iKeGqlD6LIuX61MvCL9dhBPNGwzo8TOGDBSQgHONcSnqGm5U/+jmuhi0BYicHHCa2RE8KCjeFbkPWfocSNvsgO5dAyauH4gcOMsgiyuN7InZHgtfGe8We+0hxt7P/atP0PJoWXSUuwuw+o1VhEQFVgsW1czFY+UOw03zqzvq6aQZtC137Kj6JecVw1a3VhRym3+WER3fxvx7vjx7BENEkVlmrCk0d5cGwBzCVCTZAv1diL2VnucbGcPBqfFZgpl4EqfQDoNy6AzSUZkMS6YX4W6mXLUSIpdDfEoMew00kJpJS4mW9T9JIzRoHHpaIQ9agdNDb3HuWTdZ7fhmdfk/5JS8L3oeNXsJx/AQcfBcdrvAatvB+f8J/drA== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230022)(4636009)(396003)(136003)(376002)(39860400002)(346002)(451199015)(36840700001)(40470700004)(46966006)(81166007)(82740400003)(356005)(31696002)(36756003)(86362001)(31686004)(83380400001)(36860700001)(2616005)(2906002)(40460700003)(82310400005)(40480700001)(44832011)(41300700001)(478600001)(26005)(53546011)(16526019)(336012)(186003)(47076005)(426003)(110136005)(16576012)(316002)(70586007)(5660300002)(70206006)(8936002)(8676002)(4326008)(43740500002)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2022 10:30:12.8790 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bfbf2757-3dcd-46bd-3c01-08da9c856ec6 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT019.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5473 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 9/21/22 15:22, Alexander Dahl wrote: > Instead of using DEBUG or LOG_DEBUG the driver still had its own > definition for debug output. > > Signed-off-by: Alexander Dahl > --- > drivers/fpga/virtex2.c | 37 +++++++++++++++---------------------- > 1 file changed, 15 insertions(+), 22 deletions(-) > > diff --git a/drivers/fpga/virtex2.c b/drivers/fpga/virtex2.c > index 51b8d31205..fddf8ac4ce 100644 > --- a/drivers/fpga/virtex2.c > +++ b/drivers/fpga/virtex2.c > @@ -12,21 +12,14 @@ > * on spartan2.c (Rich Ireland, rireland@enterasys.com). > */ > > +#define LOG_CATEGORY UCLASS_FPGA > + > #include > #include > +#include > #include > #include > > -#if 0 > -#define FPGA_DEBUG > -#endif > - > -#ifdef FPGA_DEBUG > -#define PRINTF(fmt, args...) printf(fmt, ##args) > -#else > -#define PRINTF(fmt, args...) > -#endif > - > /* > * If the SelectMap interface can be overrun by the processor, define > * CONFIG_SYS_FPGA_CHECK_BUSY and/or CONFIG_FPGA_DELAY in the board > @@ -89,12 +82,12 @@ static int virtex2_load(xilinx_desc *desc, const void *buf, size_t bsize, > > switch (desc->iface) { > case slave_serial: > - PRINTF("%s: Launching Slave Serial Load\n", __func__); > + log_debug("%s: Launching Slave Serial Load\n", __func__); > ret_val = virtex2_ss_load(desc, buf, bsize); > break; > > case slave_selectmap: > - PRINTF("%s: Launching Slave Parallel Load\n", __func__); > + log_debug("%s: Launching Slave Parallel Load\n", __func__); > ret_val = virtex2_ssm_load(desc, buf, bsize); > break; > > @@ -111,12 +104,12 @@ static int virtex2_dump(xilinx_desc *desc, const void *buf, size_t bsize) > > switch (desc->iface) { > case slave_serial: > - PRINTF("%s: Launching Slave Serial Dump\n", __func__); > + log_debug("%s: Launching Slave Serial Dump\n", __func__); > ret_val = virtex2_ss_dump(desc, buf, bsize); > break; > > case slave_parallel: > - PRINTF("%s: Launching Slave Parallel Dump\n", __func__); > + log_debug("%s: Launching Slave Parallel Dump\n", __func__); > ret_val = virtex2_ssm_dump(desc, buf, bsize); > break; > > @@ -150,8 +143,8 @@ static int virtex2_slave_pre(xilinx_virtex2_slave_fns *fn, int cookie) > { > unsigned long ts; > > - PRINTF("%s:%d: Start with interface functions @ 0x%p\n", > - __func__, __LINE__, fn); > + log_debug("%s:%d: Start with interface functions @ 0x%p\n", > + __func__, __LINE__, fn); > > if (!fn) { > printf("%s:%d: NULL Interface function table!\n", > @@ -160,7 +153,7 @@ static int virtex2_slave_pre(xilinx_virtex2_slave_fns *fn, int cookie) > } > > /* Gotta split this one up (so the stack won't blow??) */ > - PRINTF("%s:%d: Function Table:\n" > + log_debug("%s:%d: Function Table:\n" > " base 0x%p\n" Above you are also aligning next lines which is not what you do here. The same issue is visible also in other patches. I think it will be good to also align it to have proper coding style. Thanks, Michal