From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8414EC4708F for ; Wed, 2 Jun 2021 03:03:53 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9BD26613C5 for ; Wed, 2 Jun 2021 03:03:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9BD26613C5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1C06C82B51; Wed, 2 Jun 2021 05:03:49 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="We/Xogb8"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D00C482E8D; Wed, 2 Jun 2021 05:03:47 +0200 (CEST) Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com [IPv6:2607:f8b0:4864:20::734]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1442D8200B for ; Wed, 2 Jun 2021 05:03:45 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qk1-x734.google.com with SMTP id u30so1026114qke.7 for ; Tue, 01 Jun 2021 20:03:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=xNwN6g/smDSp/X77m9V7xHF/qFKAm+gY7RF+bjvqa8o=; b=We/Xogb8Oz4oEgRLae3TZ59EJwYCrhK+ns9qhTkFnO6kcsT39JyfX0l3yok2rzVWua /w4AHsu+OL5hoOflvYrXFpF0ERRTErtPnUXcmoBGrFB8vfIePBn4H7HuhDL5lF++5ZAS BwlABBasu/cOfuhHfWHMFlQCxm64RngOiXN7v7xdpjxJ6/5Z3Klcp6SivC2Dqeen5EJr YU0Cn5zVmCRebPZGGTKpQ9BbySX3rSm11r34BW0rOKlIyVutWDFHLNFp4ydMIbLno7eX fmDG3nvdg43Qoax8Vu1Zul763LrT7DrqRGqdXRiWE+D1teVL1eMAmnkdIbzhY+bwYndH 9bZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xNwN6g/smDSp/X77m9V7xHF/qFKAm+gY7RF+bjvqa8o=; b=oqS0wPXBrd9pHBhJ3ENaV3yUayYFfRYnBetyy36K7RgJb7o0odrKwehC7alABDP2Gg cmSvoUnzATRyxwjww8SpUxP2F8NeJzYRxbdqk6TDB41zDQBT8fnHg9QQdhjt0I+/nxxJ gOdGBLGr/1m/QRr86nepUQLaDXzvzxaqE8g5GYtzHZgLlOeL3xejpJI2fb7BqaZQlibk FxG3HsLK8X86Kku5hb8NAkjsRj8iQguT98/6mfBcqpXeHhZPb2zH78ol65JKpSFcLx7C LozfXtDqS7HLUS44l30EIav3NUeTsICCxSFwgMOAr4xGL2Icrfyv3zlzHEPXkHBZ5+Ay HuMg== X-Gm-Message-State: AOAM530ALox3jwLRKLpvjtdYPaOLDhj6IYXr0EKF7mdYK1VUJgBAfW3L gQx6jVQ0PGOKe390LB+0tF0= X-Google-Smtp-Source: ABdhPJwxlnD1W4W+9Xg2PIYZeXJKl7zSAMq8m5IKjesq8ZHnXkAuF2EK3KTtivgWYkBJzjsZzZM9qg== X-Received: by 2002:a37:855:: with SMTP id 82mr6894659qki.25.1622603018783; Tue, 01 Jun 2021 20:03:38 -0700 (PDT) Received: from [192.168.1.201] (pool-74-96-87-9.washdc.fios.verizon.net. [74.96.87.9]) by smtp.googlemail.com with ESMTPSA id d12sm12822822qkn.126.2021.06.01.20.03.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Jun 2021 20:03:38 -0700 (PDT) Subject: Re: [[PATCH] colibri_imx6: add board_fit_config_name_match to support FIT in SPL To: Ming Liu Cc: u-boot@lists.denx.de, Sergio Prado , Max Krummenacher , Marcel Ziswiler References: <20210531070620.6780-1-liu.ming50@gmail.com> From: Sean Anderson Message-ID: Date: Tue, 1 Jun 2021 23:03:37 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean On 6/1/21 11:58 AM, Ming Liu wrote: > Hi, Sean: >=20 > Thanks for the comments, please see my answers as follows: >=20 > > Please use an errno. >=20 > Seems all other board are using '0' and '-1' as return value of board_f= it_config_name_match, shouldn't we keep consistent with them? *shrug* We return an int, so why not use an error code? Otherwise, we might as well return bool. >=20 > > Do you need to match "imx6-colibri", or could you use the default co= nfig? >=20 > I think so since imx6-colibri.its is the only present DTS file for this= board. >=20 > //Ming Liu >=20 So does this FIT only contain one config? I ask because if you just need the default config you can use the weak definition in common/common_fit.c. --Sean >=20 >=20 > Sean Anderson > =E6=96=BC = 2021=E5=B9=B45=E6=9C=8831=E6=97=A5 =E9=80=B1=E4=B8=80 =E4=B8=8B=E5=8D=884= :36=E5=AF=AB=E9=81=93=EF=BC=9A >=20 > On 5/31/21 3:06 AM, liu.ming50@gmail.com wrote: > > From: Ming Liu > > > > > Only one dtb is currently supported, so match with imx6-colibri.= > > > > Signed-off-by: Ming Liu > > > --- > > board/toradex/colibri_imx6/colibri_imx6.c | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/board/toradex/colibri_imx6/colibri_imx6.c b/board/t= oradex/colibri_imx6/colibri_imx6.c > > index c0e7754469..587d92a8e9 100644 > > --- a/board/toradex/colibri_imx6/colibri_imx6.c > > +++ b/board/toradex/colibri_imx6/colibri_imx6.c > > @@ -1081,6 +1081,16 @@ void board_init_f(ulong dummy) > > board_init_r(NULL, 0); > > } > > > > +#ifdef CONFIG_SPL_LOAD_FIT > > +int board_fit_config_name_match(const char *name) > > +{ > > + if (!strcmp(name, "imx6-colibri")) > > + return 0; > > + > > + return -1; >=20 > Please use an errno. >=20 > > +} > > +#endif > > + > > void reset_cpu(void) > > { > > } > > >=20 > Do you need to match "imx6-colibri", or could you use the default c= onfig? >=20 > --Sean >=20