From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE6CBC433F5 for ; Fri, 17 Dec 2021 23:11:30 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3034B83808; Sat, 18 Dec 2021 00:11:16 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=seco.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=secospa.onmicrosoft.com header.i=@secospa.onmicrosoft.com header.b="hod9RyNE"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8997983811; Sat, 18 Dec 2021 00:10:30 +0100 (CET) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20612.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e1b::612]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2BE5F8381E for ; Sat, 18 Dec 2021 00:10:14 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=seco.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sean.anderson@seco.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bSbByTplcEkQuSU1pbEVPie65OgSCt+8gCcVRJyJDMkODR69seSrGFNUa6hGrrQwx9JjBl6pYJJH6GulfoYMXbiHaUz8dVmLj0RZrYfHayEw3sQWzJpIrnSOjZejTD6XRRdMKANA/l6xp/7IrjnTjg7BuxM1LDLJnjvDMy9Z+sM2PRUIFC/ng0xEmZgrgiLn018pVcVEV64y4GjbvjDdDZJugWsEjVhaWhudY2+EyCUCAj8xeMHW0f0nmcRpMiSFFYPe7KcahUSzMdxEddoXuxv9q9Z09zHNk4I4FnpfZ4V134jJst3orOTkcUBhqsBmLCExNzPBqeVz34Na+FDWPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WpDbm6QkEd7n1aQwGcdKjTPgbQ0HdmGtAsEQ7q0MTVs=; b=kUx675w2KdruSR1qhg35k21RGVsYcH9Qfi16KKFLsP0tDjXxNsZkxp4hFLTeX1JRohp1EkrZDsKPf7RfK62vyOYfSVyKIf9RCRG7jMWXKr2Xe+DK2IASCRmzEL7awQ7J36q46RnP/FZajaNpw5zxKK0Xwp0MjhB/A7QZh7pqaAayYSiUzy/h4CIrWTwhPwVygIzQE/vGp0JYlLe3/iy2XZFULAja8DshiCJ/wsLomjlR4yyO0vlfXGl/qel6bBH+jI8Yk6HOZOZ+JZfZnvb8BlJB+M5aQ2sJZgBIOk5s5ZJekUaeoj4Oj2/9+wCkX+nkEXjQta3eQBVeV9uTADW+cg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=seco.com; dmarc=pass action=none header.from=seco.com; dkim=pass header.d=seco.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=secospa.onmicrosoft.com; s=selector2-secospa-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WpDbm6QkEd7n1aQwGcdKjTPgbQ0HdmGtAsEQ7q0MTVs=; b=hod9RyNEggzUPiBDlZc5gjDz2Va+YbggdZCAf9XSSA6u30b5+o4i/wKCNkJD4cvfDc9ar6uGV5e6RZL9hs/AaTZOL4ac74L4gnIU8BShXzaXjlSh7FTjhthv3VKMFmiGSFLw/m6MKdmZqLUFkyIg/n/EyrW/YS+7v7QNQflyyfA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=seco.com; Received: from DB7PR03MB4523.eurprd03.prod.outlook.com (2603:10a6:10:19::27) by DB7PR03MB3803.eurprd03.prod.outlook.com (2603:10a6:5:38::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Fri, 17 Dec 2021 23:10:12 +0000 Received: from DB7PR03MB4523.eurprd03.prod.outlook.com ([fe80::9093:a60b:46b7:32ee]) by DB7PR03MB4523.eurprd03.prod.outlook.com ([fe80::9093:a60b:46b7:32ee%4]) with mapi id 15.20.4778.019; Fri, 17 Dec 2021 23:10:12 +0000 Subject: Re: [PATCH 1/2] fastboot: fb_getvar: Add getvar_logical_blocksize for MXP mfgtool To: Angus Ainslie , u-boot@lists.denx.de Cc: Sean Anderson , Simon Glass , Oleh Kravchenko , Patrick Delaunay , Roman Stratiienko , Marek Szyprowski References: <20211217154200.326443-1-angus@akkea.ca> <20211217154200.326443-2-angus@akkea.ca> From: Sean Anderson Message-ID: Date: Fri, 17 Dec 2021 18:10:08 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 In-Reply-To: <20211217154200.326443-2-angus@akkea.ca> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BL1PR13CA0227.namprd13.prod.outlook.com (2603:10b6:208:2bf::22) To DB7PR03MB4523.eurprd03.prod.outlook.com (2603:10a6:10:19::27) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9d04ce64-5290-4f34-bd95-08d9c1b26106 X-MS-TrafficTypeDiagnostic: DB7PR03MB3803:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4303; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rSO/m+0HdAOPLI1XTOdCgisGWExIKoZp2EaUZpr02IMjahQXt/xxZUIS5ioZ/dKCjgjvA7ZCTmIvURP0/jIeHv34p2wIaOQuvnog0U3ZqvKbc+tyNCSMXzYizVX2MzNrlUBMfyRIuA1+H7+C65P2PuBTahU7+LbgD3+Vu/+JTPPjQQQN+BQ6ZfZtFVYJxjZkRPM5kSO2+GljA28hzL5Ij6JaV8VPW3gWzMtGHYIr6eqWHuWFPF8ttyhRBaCA4kir7Y7GqbcODNWGjX7Ay63pP3KsIlHIywwa/klr4ToI/Qs6idk8lQ6/1GZ1hhzFxLa4K9lqwdfA07NF8yL2utFK9TUaveS/Quqif4NlhPTDF9OWahpGD+Zc0W49vCfQmerAtYOC2YNpjMDUxoBJF21L5PzhmN7XUPSArkbyR0J2kBqnlXMyDH4RT+YAL6d0d7xkmLSoQN3meHEssJwt2tCNHZqSVDqVpkzAbjO2aig5bIw5AC0f2YT6ZP72pX8UnPni8dcYwziYi2TTTPZjGwdv6zC2kdWyMWrgSZeJuDp0Jco7Tzmz8/Mh3Wvk2oYXw0F5Ifp3X8Hy8yhfOUYYarDz6cJV0cLnZv+Uu+aqKGDO9aG9QBpOLrulPqXmUUJlp2A+vz/j+JNYYSggtCjnOl2VZsb8iCtATi6IfxC+soVVB/fu5FfMaSRlst/d+IbL14fPGs3GAS0lUXeKqXBNjYIHzPuKZhJEd87kPpUy+m5t23fcemncTmE8r7aPS/y9y7osx9tsrZsk6pB2Y0u9JOK87Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB7PR03MB4523.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(8936002)(6506007)(53546011)(2906002)(4326008)(316002)(508600001)(44832011)(38350700002)(54906003)(26005)(8676002)(6512007)(38100700002)(2616005)(31686004)(186003)(31696002)(36756003)(66556008)(83380400001)(86362001)(52116002)(66476007)(6666004)(6486002)(66946007)(5660300002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a1p2dmp3N1BvQTNSdjJlS1kvSVpYWks2WkNQWVVWZFlQRkdsUFhvWlU0ZUR1?= =?utf-8?B?YVFSRnIwV0lGakdJOUp0bllwaWZBdk16RmtxYXVNMHhJQ0RKNEdZZXNvNUMv?= =?utf-8?B?ZFl5TXhTRmVMeXdMbXRaNmU3blRwcFZVczFnNmhMZE85V1ZyY2pabXhEbjBH?= =?utf-8?B?eHRWM09pSmpNQ1dXQkFRVU4zTm01WDZGNlpLUkhuRkw0RmNDdmpRUU4vYWo3?= =?utf-8?B?cmIrUENXZ294dFRYMzVOUHlYd2M4Wi9nRWpRZ2lFYjd1SGl4eGkxV1BEVTZO?= =?utf-8?B?bmtkcnd1WnNVekxqR1NlaWF4a0xGREVsaURPaEw2emxXdFJsd2NLOFVqdGha?= =?utf-8?B?WjIyVmx6dmtYQWt4NVJNOFp1RTYwYzEvb3lyT3p3ZVNaRE8yaHpVWm9XTmUx?= =?utf-8?B?SldqMzc3K3lYS2pyRGV1OUpMVWJpWFNMcFVJR2pNRnpZdktOSlFNa0pyTTg2?= =?utf-8?B?eGRTU25uU1pyZ2pDb3FDSlREeEtJL3pHOGovNlY5S0hpMFdpalNTVklZRGdG?= =?utf-8?B?SDBlRlRTREZvOE56eTRJMytvYnhpR2JrTTV2NHo5Sjc4NmNUTFoyNWRKdGlL?= =?utf-8?B?TjFwazV1RWtyb0Npb3dOc0ZyKzRtekY3Y1NLVzZxZjVIV2hYOXJXVE1ocEtY?= =?utf-8?B?TUx2WGNWYzF1ekNhY25yb3VlekNiUWF6MUlLR20wOWs3dUxQekZsN0ZtVks2?= =?utf-8?B?dVo3RVFPY3pSYXdPelZmUHAvV01BVlJ5T2dtQnJqUDlydzZIR3NuQmJISDBx?= =?utf-8?B?aCs3ME9pZnZ0YjB3OHNiSVZxK2c3RWNuR2tkandNamgzM1pjd2FuZ1Q2d1hL?= =?utf-8?B?RVBCVzJpYlVPdHFNeFRmdXczSEhVUHpWRVZTNjR6VzJuSzA4aUIyWTNYZnJH?= =?utf-8?B?Q2xpQnArcDlnNXREaHkveTU3V204aUxMN1FwbkFDQ2hkSExvQjVLTWY1VVh1?= =?utf-8?B?MG53aTRGc0dJRm0zbUJ1ZHh1ZHUxN2RrZS9iQmRTakJWZDYvOHhZM1dwSjhh?= =?utf-8?B?aUhNd3hxSCtGTHZJTDVHdDJjeHB2NkV1bUZKQ1RYZXNEQkRaVWNoZkhncjNP?= =?utf-8?B?Z0pxdmQ1ZWZDeldUYS9MbEg1NFlrczRlamFPV3BGSFNNTzY1WUdaWmZuamVL?= =?utf-8?B?RXNjVzZmRGdleFBqQnpKNENZTTJMVDEwSWYzYlREa25FUWZiUlowck1QeFVD?= =?utf-8?B?Znl0UTRncEpnWmRJOEJIVWo2TjJOTVJVSDdyU2YxY01oRkdKeEFKK2thME1L?= =?utf-8?B?Y1lQL1Zjek9JbVQvY3JTSnZpNmZtaUFaUnJKbEFpVy9YMXluQitjV21TMXFC?= =?utf-8?B?cktKUEFrQ0NYaW5VL0ZBUUN5WWJkdVhnRXVUSHk4SjQrRVhYcWdpem1qWVVI?= =?utf-8?B?U3BjVmhwMUc1SWdGN09XRjN5SWI3L0pCaVBrT0tFM0dIUTQvYW9PNFc0eS9w?= =?utf-8?B?czFNMnlBVm8zb3B4bUJFUCtkcm1pblBGTXIwS0tqV2lMZVZCU2pEckI5MEpZ?= =?utf-8?B?UlRMRHhlRUpTRFFhc0pCcUdCeWloTFNXZk9vK3NQSlJURjk4NzN2VXA2Rmti?= =?utf-8?B?UFNhWVdwU2NHajNVMU5HS1I2WmEzQyt5aWUvclFmd0RDR0QzeUxtMCtqWUVL?= =?utf-8?B?QStwZk5KcG1waVpvSnc2Vm1kbk02ZW4yME5BZVlFdndIRlhtd2xxUUtqa2ZU?= =?utf-8?B?N2Z5eXp3Ujh6T2U4cUh0VHdDT0xXVmI3ckN0VzBPYzNxYjhCWHBBSkRMYlIz?= =?utf-8?B?aTdtMnUwS0JUVjVSZlRlei8vMDYyVzAyNGpzVm1oTFhCUzk0QmxDdkFGaEQv?= =?utf-8?B?aGVVak90bVNUY0ZiNW9PNWpkenpBTXJkYmxiV01OTnc2a1N4VXUyR2NyR3Jw?= =?utf-8?B?YUlPdjRDeDFtM3dLbFREMUROUGJXY2VwaXdmcjU1N2tGaVMwZWFKTmpUZWpT?= =?utf-8?B?WGVMZWZPT1AxdWZKOHBiaisyMVd4WU92aExIb2RlbURLQlZaL01Uck9FZWY2?= =?utf-8?B?RlhMcFZnOWQ0bnlMblhFeGlCYk5wN2dTMkxWank0UEdaaEVMUG5Ub3ViVTVp?= =?utf-8?B?elh4QTMxUVd5bmlZVEdNaXNTajNmTSt4TDlJYTN4QjNLWGp6c3NqLzFuNUl6?= =?utf-8?B?cWpXWGppNU9kQVVFNFlvTUp5SUI5Skhxb0dIMmVhT1VZTmZaQXZTWUQ4VzJr?= =?utf-8?Q?SnaEBImq+EgNsfHnTqUExus=3D?= X-OriginatorOrg: seco.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9d04ce64-5290-4f34-bd95-08d9c1b26106 X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4523.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Dec 2021 23:10:12.6656 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yWWDXOn6rAh+HlBUbRzLIRGnEXeSZM+xemu6MLJHhGER8Rla6CQFkqE3wonTpLnQZZYvCCwiOf0Wcs4tojglJA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR03MB3803 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Angus, On 12/17/21 10:41 AM, Angus Ainslie wrote: > uuu uses the blocksize to determine the upload size Can you please elaborate on this more? > > Signed-off-by: Angus Ainslie > --- > drivers/fastboot/fb_getvar.c | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/drivers/fastboot/fb_getvar.c b/drivers/fastboot/fb_getvar.c > index d43f2cfee6..ff5f0d3d40 100644 > --- a/drivers/fastboot/fb_getvar.c > +++ b/drivers/fastboot/fb_getvar.c > @@ -31,6 +31,7 @@ static void getvar_partition_type(char *part_name, char *response); > static void getvar_partition_size(char *part_name, char *response); > #endif > static void getvar_is_userspace(char *var_parameter, char *response); > +static void getvar_logical_blocksize(char *var_parameter, char *response); > > static const struct { > const char *variable; > @@ -81,6 +82,9 @@ static const struct { > }, { > .variable = "is-userspace", > .dispatch = getvar_is_userspace > + }, { > + .variable = "logical-block-size", > + .dispatch = getvar_logical_blocksize > } > }; > > @@ -140,6 +144,29 @@ static void getvar_downloadsize(char *var_parameter, char *response) > fastboot_response("OKAY", response, "0x%08x", fastboot_buf_size); > } > > +static int fb_get_block_size(void) > +{ > + int dev_no = 0; > + struct blk_desc *dev_desc; > + > + dev_desc = blk_get_dev("mmc", 0); And what if your block device is not mmc 0? This code is not specific to fastboot mmc. What about nand? > + > + if (!dev_desc) { > + printf("** Block device %s %d not supported\n", > + "mmc", 0); > + return 0; Why return 0? This should result in an error fastboot_response. > + } > + return dev_desc->blksz; > +} > + > +static void getvar_logical_blocksize(char *var_parameter, char *response) > +{ > + u32 blksz; > + > + blksz = fb_get_block_size(); > + fastboot_response("OKAY", response, "0x%08x", blksz); Can we combine these functions? --Sean > +} > + > static void getvar_serialno(char *var_parameter, char *response) > { > const char *tmp = env_get("serial#"); >