public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Vyacheslav V. Mitrofanov" <v.v.mitrofanov@yadro.com>
To: "u-boot@lists.denx.de" <u-boot@lists.denx.de>,
	"emohandesi@linux.microsoft.com" <emohandesi@linux.microsoft.com>
Cc: "sjg@chromium.org" <sjg@chromium.org>,
	"joe.hershberger@ni.com" <joe.hershberger@ni.com>,
	"rfried.dev@gmail.com" <rfried.dev@gmail.com>,
	"saproj@gmail.com" <saproj@gmail.com>
Subject: Re: [PATCH 2/2] net: ipv6: network protocol structures should be packed
Date: Fri, 19 May 2023 07:12:34 +0000	[thread overview]
Message-ID: <ebfa800e583f4437795b296c238df0cf934ed26d.camel@yadro.com> (raw)
In-Reply-To: <1684434279-1065-3-git-send-email-emohandesi@linux.microsoft.com>

On Thu, 2023-05-18 at 11:24 -0700, emohandesi@linux.microsoft.com
wrote:
> From: Ehsan Mohandesi <emohandesi@linux.microsoft.com>
> 
> The structure icmp6_ra_prefix_info needs to be packed because it is
> read
> from a network stream.
> 
> Signed-off-by: Ehsan Mohandesi <emohandesi@linux.microsoft.com>
> ---
>  include/net6.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/net6.h b/include/net6.h
> index beafc05..1e766aa 100644
> --- a/include/net6.h
> +++ b/include/net6.h
> @@ -204,7 +204,7 @@ struct icmp6_ra_prefix_info {
>          * be initialized to zero by the sender and ignored by the
> receiver.
>          */
>         struct in6_addr prefix;
> -};
> +} __packed;
> 
>  extern struct in6_addr const net_null_addr_ip6;        /* NULL IPv6
> address */
>  extern struct in6_addr net_gateway6;   /* Our gateways IPv6 address
> */
> --
> 1.8.3.1
> 
> 
Reviewed-by: Viacheslav Mitrofanov <v.v.mitrofanov@yadro.com>

  reply	other threads:[~2023-05-19  7:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-18 18:24 [PATCH 0/2] IPv6 Network Discovery Boundary Variable and Packed Structure emohandesi
2023-05-18 18:24 ` [PATCH 1/2] net: ipv6: router advertisement message length should be within limits emohandesi
2023-05-19  7:09   ` Vyacheslav V. Mitrofanov
2023-06-10 10:44   ` Ramon Fried
2023-07-27 20:46   ` Tom Rini
2023-05-18 18:24 ` [PATCH 2/2] net: ipv6: network protocol structures should be packed emohandesi
2023-05-19  7:12   ` Vyacheslav V. Mitrofanov [this message]
2023-06-10 10:45   ` Ramon Fried
2023-07-27 20:46   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ebfa800e583f4437795b296c238df0cf934ed26d.camel@yadro.com \
    --to=v.v.mitrofanov@yadro.com \
    --cc=emohandesi@linux.microsoft.com \
    --cc=joe.hershberger@ni.com \
    --cc=rfried.dev@gmail.com \
    --cc=saproj@gmail.com \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox