public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Vignesh R <vigneshr@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC] tiny-printf: Add support for %p format
Date: Fri, 7 Apr 2017 23:42:56 +0530	[thread overview]
Message-ID: <ec2b44bb-433c-9eea-ef93-8088ec0ea025@ti.com> (raw)
In-Reply-To: <20170407151051.GI19897@bill-the-cat>



On 4/7/2017 8:40 PM, Tom Rini wrote:
> On Fri, Apr 07, 2017 at 03:20:34PM +0530, Vignesh R wrote:
> 
>> Add support for %p, %pa[p], %pM, %pm and %pI4 formats to tiny-printf.
>> %pM and %pI4 are widely used by SPL networking stack and is required if
>> networking support is desired in SPL.
>>
>> Before this patch:
>> $ size spl/u-boot-spl
>>    text	   data	    bss	    dec	    hex	filename
>>   99325	   4899	 218584	 322808	  4ecf8	spl/u-boot-spl
>>
>> After this patch (with CONFIG_SPL_NET_SUPPORT):
>> $ size spl/u-boot-spl
>>    text	   data	    bss	    dec	    hex	filename
>>   99714	   4899	 218584	 323197	  4ee7d	spl/u-boot-spl
>>
>> So, this patch adds ~390 bytes to code size.
>>
>> If CONFIG_SPL_NET_SUPPORT is not enabled then only %p, %pa, %pap are
>> supported, this adds ~90 bytes to code size.
> 
> Why do we need %p/%pa/%pap?  I'm fine with adding %pM/%pm/%pI4 under
> SPL_NET_SUPPORT as you've done.
> 

Ok, I can drop support for %p/%pa/%pap. Its just that, I see debug()
prints in SPL code that use them. If the agreement is not to worry them,
I am fine with it.

  reply	other threads:[~2017-04-07 18:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-07  9:50 [U-Boot] [RFC] tiny-printf: Add support for %p format Vignesh R
2017-04-07 15:10 ` Tom Rini
2017-04-07 18:12   ` Vignesh R [this message]
2017-04-07 21:24     ` Tom Rini
2017-04-09 19:27     ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ec2b44bb-433c-9eea-ef93-8088ec0ea025@ti.com \
    --to=vigneshr@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox