From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heinrich Schuchardt Date: Tue, 20 Nov 2018 23:08:54 +0100 Subject: [U-Boot] [U-Boot, 1/1] fs: fat: validate sector and cluster size In-Reply-To: <20181120203318.GH11247@bill-the-cat> References: <20181031204636.15149-1-xypron.glpk@gmx.de> <20181120145603.GV11247@bill-the-cat> <198d9503-defd-6c2e-0588-a47a41f2a1ba@gmx.de> <20181120203318.GH11247@bill-the-cat> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 11/20/18 9:33 PM, Tom Rini wrote: > On Tue, Nov 20, 2018 at 09:29:34PM +0100, Heinrich Schuchardt wrote: > >> On 11/20/18 3:56 PM, Tom Rini wrote: >>> On Wed, Oct 31, 2018 at 09:46:36PM +0100, Heinrich Schuchardt wrote: >>> >>>> In the rest of the FAT driver we want to be able to rely on the fact that >>>> the cluster size is a power of two. So let's check that both the sector >>>> size and the number of sectors per cluster are valid. >>>> >>>> Signed-off-by: Heinrich Schuchardt >>> >>> This breaks a number of tests under test/py/tests/test_fs/test_basic.py >>> as seen under 'make tests'. >>> >> >> Hello Tom, >> >> I am not able to reproduce your observation based on commit >> d73d81fd85e4a030ade42c4b2d13466d45090aa3 (master HEAD). See test output >> below. > [snip] >> test/py/tests/test_fs/test_basic.py >> sssssssssssssssssssssssssssssssssssssss > > OK, my fault for being imprecise. These tests here are the ones that > fail and you have them being skipped. > r make tests is building sandbox. Why are the tests skipped? I did not set them to skipped explicitly. The tests make reference to a file system. Where is it built? Regards Heinrich