From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC6D6C7EE23 for ; Wed, 1 Mar 2023 19:29:56 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B94D485237; Wed, 1 Mar 2023 20:29:54 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.b="PPOz3gZ2"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 822E8855D9; Wed, 1 Mar 2023 20:29:53 +0100 (CET) Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 75EBB843B5 for ; Wed, 1 Mar 2023 20:29:50 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=afd@ti.com Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 321JTmNU104660; Wed, 1 Mar 2023 13:29:48 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1677698988; bh=jdsRe9SXz5D5zfuN9U1kNzxCJAqBd/iO9e1q449yhdQ=; h=Date:Subject:To:References:From:In-Reply-To; b=PPOz3gZ22luToriJdaioMcH8aLxNyiRE6RpzrQTZ+bqZF8l8dDI31+kUY315MZzL2 ZFtjOelFzjhltkYHpa0W5wV889FE3N8txKEhh7gb2JUvZuKwlatt7IPo86VJhARUt6 J/Ur9KrIZduyuwZ5EO1KQ5eA9Sz8EUAK/zTgoWSE= Received: from DLEE101.ent.ti.com (dlee101.ent.ti.com [157.170.170.31]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 321JTmqZ032313 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 1 Mar 2023 13:29:48 -0600 Received: from DLEE101.ent.ti.com (157.170.170.31) by DLEE101.ent.ti.com (157.170.170.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Wed, 1 Mar 2023 13:29:48 -0600 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE101.ent.ti.com (157.170.170.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Wed, 1 Mar 2023 13:29:48 -0600 Received: from [10.249.33.186] (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 321JTlIw018930; Wed, 1 Mar 2023 13:29:48 -0600 Message-ID: Date: Wed, 1 Mar 2023 13:29:47 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH V7 01/15] board: siemens: iot2050: Split the build for PG1 and PG2 Content-Language: en-US To: Jan Kiszka , U-Boot Mailing List References: <6b4e3ad5fcb37bab55d5ad7e0d9fa7d934bfd580.1677608363.git.jan.kiszka@siemens.com> <35946e9b-061d-930b-835b-a5eee10e2f57@siemens.com> <5887e5b6-a0cf-7f57-bed4-34b7fa8b97d5@siemens.com> From: Andrew Davis In-Reply-To: <5887e5b6-a0cf-7f57-bed4-34b7fa8b97d5@siemens.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 3/1/23 1:21 PM, Jan Kiszka wrote: > On 01.03.23 19:34, Andrew Davis wrote: >> On 3/1/23 12:29 PM, Jan Kiszka wrote: >>> On 01.03.23 18:26, Andrew Davis wrote: >>>> On 2/28/23 12:19 PM, Jan Kiszka wrote: >>>>> From: Su Baocheng >>>>> >>>>> Due to different signature keys, the PG1 and the PG2 boards can no >>>>> longer use the same FSBL (tiboot3). This makes it impossible anyway to >>>>> maintaine a single flash.bin for both variants, so we can also split >>>>> the >>>>> build. >>>>> >>>> >>>> Having two defconfigs just to make the small changes needed will be >>>> more burden than it saves. Keeping them in sync and having your >>>> integration >>>> layer do two different builds just adds more work than it is worth IMHO. >>>> >>>> We (TI) are going in that direction for our HS boards and combining the >>>> defconfigs back together now. The solution is to have the one defconfig >>>> build both images, one for HS and one for non-HS. For you looks like you >>>> are already calling the two PG boot images differently so this should >>>> work >>>> (seboot_pg1.bin and seboot_pg2.bin). Just add a new full entry in >>>> boot-image.dtsi for each (vs that #ifdef check changing the output >>>> name). >>> >>> How should that work? Will we somehow get two flash.bin out of a single >>> build then? >>> >> >> Yes if you add two enteries in your image.dtsi file. Then your integration >> selects the right named one for the board, instead of selecting the right >> defconfig for the board and doing a completely new build. > > Something like this? > > binman: binman { > multiple-images; > }; > > &binman { > flash-pg1 { > filename = "flash-pg1.bin" > ... > }; > > flash-pg2 { > filename = "flash-pg2.bin" > ... > }; > }; > Yes. > How to avoid duplicating the common nodes of flash-pg1/pg2? > We just duplicate the contents for both today in our files. Maybe the common content can be put in an include file and included inline in both nodes? Andrew