From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thirupathaiah Annapureddy <thiruan@linux.microsoft.com>
Date: Thu, 20 Aug 2020 14:09:55 -0700
Subject: [PATCH] arm: dts: fix ast2500-evb inclusion for correct target
In-Reply-To: <f000a1a2756248179370866622e39950@TWMBX02.aspeed.com>
References: <20200818005343.30574-1-thiruan@linux.microsoft.com>
 <b17b0729-19c3-bbe1-1db5-28ed9bb4ba16@linux.microsoft.com>
 <f000a1a2756248179370866622e39950@TWMBX02.aspeed.com>
Message-ID: <ed096bf2-dd52-eefc-7c31-2541c0de5ce5@linux.microsoft.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Ryan,

Thanks for reviewing the patch. Please see my comment(s):

On 8/19/2020 7:06 PM, Ryan Chen wrote:
> Hi
>> -----Original Message-----
>> From: Thirupathaiah Annapureddy [mailto:thiruan at linux.microsoft.com]
>> Sent: Thursday, August 20, 2020 8:16 AM
>> To: u-boot at lists.denx.de
>> Cc: Maxim Sloyko <maxims@google.com>; Marek Vasut <marex@denx.de>;
>> ChiaWei Wang <chiawei_wang@aspeedtech.com>; Ryan Chen
>> <ryan_chen@aspeedtech.com>
>> Subject: Re: [PATCH] arm: dts: fix ast2500-evb inclusion for correct target
>>
>> Adding Ryan and Chiawei to the list.
>>
>> On 8/17/2020 5:53 PM, Thirupathaiah Annapureddy wrote:
>>> Include ast2500-evb.dtb for CONFIG_TARGET_EVB_AST2500 instead of for
>>> all aspeed targets.
> 
> There should not have to many Kconfig for ASPEED platform. 
When you build U-Boot, you have to provide a platform specific defconfig
as the target. ex: evb-ast2500_defconfig.
defconfig specifies the platform specific device tree file.
ex: CONFIG_DEFAULT_DEVICE_TREE="ast2500-evb"

I do not see any reason to make other device trees (ex: ast2600a0-evb.dtb)
when we are building for evb-ast2500.

> I prefer use following to build all all ASPEED platform. Like following. 
> dtb-$(CONFIG_ARCH_ASPEED) += \
>         ast2400-evb.dtb \
>         ast2500-evb.dtb \
>         ast2600a0-evb.dtb \
>         ast2600a0-ncsi.dtb \
>         ast2600a1-evb.dtb \
>         ast2600a1-ncsi.dtb \
>         ast2600-fpga.dtb \
>         ast2600-rainier.dtb \
>         ast2600-slt.dtb \
>         ast2600-tacoma.dtb
>  
>>>
>>> Signed-off-by: Thirupathaiah Annapureddy <thiruan@linux.microsoft.com
>>> ---
>>>  arch/arm/dts/Makefile | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile index
>>> 7e29b9096b..d019f26983 100644
>>> --- a/arch/arm/dts/Makefile
>>> +++ b/arch/arm/dts/Makefile
>>> @@ -938,7 +938,7 @@ dtb-$(CONFIG_ARCH_BCM6858) += \
>>>
>>>  dtb-$(CONFIG_TARGET_BCMNS3) += ns3-board.dtb
>>>
>>> -dtb-$(CONFIG_ARCH_ASPEED) += ast2500-evb.dtb
>>> +dtb-$(CONFIG_TARGET_EVB_AST2500) += ast2500-evb.dtb
>>>
>>>  dtb-$(CONFIG_ARCH_STI) += stih410-b2260.dtb
>>>
>>>
> 

Best Regards,
Thiru