From: yanhong wang <yanhong.wang@starfivetech.com>
To: Andreas Schwab <schwab@suse.de>
Cc: <u-boot@lists.denx.de>, Rick Chen <rick@andestech.com>,
Leo <ycliang@andestech.com>, Lukasz Majewski <lukma@denx.de>,
Sean Anderson <seanga2@gmail.com>,
Lee Kuan Lim <kuanlim.lee@starfivetech.com>,
"Jianlong Huang" <jianlong.huang@starfivetech.com>,
Emil Renner Berthing <kernel@esmil.dk>
Subject: Re: [PATCH v4 17/17] configs: starfive: add starfive_visionfive2_defconfig
Date: Mon, 27 Mar 2023 09:59:16 +0800 [thread overview]
Message-ID: <ed0a6d80-8736-8f32-044b-0537b792e2dd@starfivetech.com> (raw)
In-Reply-To: <mvmy1nnx40v.fsf@suse.de>
On 2023/3/23 16:31, Andreas Schwab wrote:
> On Mär 22 2023, yanhong wang wrote:
>
>> On 2023/3/21 21:51, Andreas Schwab wrote:
>>> On Mär 21 2023, yanhong wang wrote:
>>>
>>>> Except for CONFIG_DEFAULT_DEVICE_TREE and CONFIG_DEFAULT_FDT_FILE,
>>>> 1.2a and 1.3b versions use the same config.
>>>>
>>>> Version 1.3b uses the following configuration:
>>>> CONFIG_DEFAULT_DEVICE_TREE="jh7110-starfive-visionfive-2-v1.3b"
>>>> CONFIG_DEFAULT_FDT_FILE="starfive/jh7110-starfive-visionfive-2-v1.3b.dtb"
>>>>
>>>> Version 1.2a uses the following configuration:
>>>> CONFIG_DEFAULT_DEVICE_TREE="jh7110-starfive-visionfive-2-v1.2a"
>>>> CONFIG_DEFAULT_FDT_FILE="starfive/jh7110-starfive-visionfive-2-v1.2a.dtb"
>>>>
>>>> Is it necessary to separate the configs for 1.2a and 1.3b as separate defconfig files?
>>>
>>> It makes a difference for when ethernet support is added.
>>>
>>
>> The difference between 1.2a and 1.3b versions is mainly in ethernet, so the definition of
>> dts is separated. Defconfig file in addition to the differences mentioned above, the others
>> are the same. Your suggestion is to define defconfig file separately, is that right?
>
> Yes, a 1.2a board will need to use the 1.2a device tree to get a working
> ethernet, IIUC.
>
Okay, I will define the defconfig for 1.2A and 1.3B separately in the next version.
prev parent reply other threads:[~2023-03-27 1:59 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 2:53 [PATCH v4 00/17] Basic StarFive JH7110 RISC-V SoC support Yanhong Wang
2023-03-16 2:53 ` [PATCH v4 01/17] riscv: cpu: jh7110: Add support for jh7110 SoC Yanhong Wang
2023-03-16 2:53 ` [PATCH v4 02/17] cache: starfive: Add StarFive JH7110 support Yanhong Wang
2023-03-16 2:53 ` [PATCH v4 03/17] dt-bindings: reset: Add StarFive JH7110 reset definitions Yanhong Wang
2023-03-16 2:53 ` [PATCH v4 04/17] reset: starfive: jh7110: Add reset driver for StarFive JH7110 SoC Yanhong Wang
2023-03-16 2:53 ` [PATCH v4 05/17] dt-bindings: clock: Add StarFive JH7110 clock definitions Yanhong Wang
2023-03-16 2:53 ` [PATCH v4 06/17] clk: starfive: Add StarFive JH7110 clock driver Yanhong Wang
2023-03-16 2:53 ` [PATCH v4 07/17] dt-bindings: pinctrl: Add StarFive JH7110 pinctrl definitions Yanhong Wang
2023-03-16 2:53 ` [PATCH v4 08/17] pinctrl: starfive: Add StarFive JH7110 driver Yanhong Wang
2023-03-16 2:53 ` [PATCH v4 09/17] ram: starfive: add ddr driver Yanhong Wang
2023-03-16 2:53 ` [PATCH v4 10/17] board: starfive: add StarFive VisionFive v2 board support Yanhong Wang
2023-03-22 1:58 ` Leo Liang
2023-03-28 7:06 ` yanhong wang
2023-03-16 2:53 ` [PATCH v4 11/17] riscv: cpu: jh7110: Add Kconfig for StarFive JH7110 SoC Yanhong Wang
2023-03-16 2:53 ` [PATCH v4 12/17] board: starfive: Add Kconfig for StarFive VisionFive v2 Board Yanhong Wang
2023-03-16 2:53 ` [PATCH v4 13/17] board: starfive: Add TARGET_STARFIVE_VISIONFIVE2 to Kconfig Yanhong Wang
2023-03-16 2:53 ` [PATCH v4 14/17] riscv: dts: jh7110: Add initial StarFive JH7110 device tree Yanhong Wang
2023-03-22 22:04 ` Conor Dooley
2023-03-28 7:49 ` yanhong wang
2023-03-16 2:53 ` [PATCH v4 15/17] riscv: dts: jh7110: Add initial u-boot " Yanhong Wang
2023-03-16 2:53 ` [PATCH v4 16/17] riscv: dts: jh7110: Add initial StarFive VisionFive v2 board " Yanhong Wang
2023-03-20 21:25 ` Conor Dooley
2023-03-22 1:37 ` yanhong wang
2023-03-22 9:37 ` Conor Dooley
2023-03-16 2:53 ` [PATCH v4 17/17] configs: starfive: add starfive_visionfive2_defconfig Yanhong Wang
2023-03-20 14:28 ` Andreas Schwab
2023-03-21 2:39 ` yanhong wang
2023-03-21 13:51 ` Andreas Schwab
2023-03-22 1:22 ` yanhong wang
2023-03-23 8:31 ` Andreas Schwab
2023-03-27 1:59 ` yanhong wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed0a6d80-8736-8f32-044b-0537b792e2dd@starfivetech.com \
--to=yanhong.wang@starfivetech.com \
--cc=jianlong.huang@starfivetech.com \
--cc=kernel@esmil.dk \
--cc=kuanlim.lee@starfivetech.com \
--cc=lukma@denx.de \
--cc=rick@andestech.com \
--cc=schwab@suse.de \
--cc=seanga2@gmail.com \
--cc=u-boot@lists.denx.de \
--cc=ycliang@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox