From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1681AC74A5B for ; Mon, 27 Mar 2023 01:59:29 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4942585E45; Mon, 27 Mar 2023 03:59:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=starfivetech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 5025085BBE; Mon, 27 Mar 2023 03:59:25 +0200 (CEST) Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by phobos.denx.de (Postfix) with ESMTP id D532C85E45 for ; Mon, 27 Mar 2023 03:59:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=starfivetech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=yanhong.wang@starfivetech.com Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 0B0CB24E1EC; Mon, 27 Mar 2023 09:59:18 +0800 (CST) Received: from EXMBX073.cuchost.com (172.16.6.83) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 27 Mar 2023 09:59:18 +0800 Received: from [192.168.120.49] (171.223.208.138) by EXMBX073.cuchost.com (172.16.6.83) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 27 Mar 2023 09:59:17 +0800 Message-ID: Date: Mon, 27 Mar 2023 09:59:16 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v4 17/17] configs: starfive: add starfive_visionfive2_defconfig Content-Language: en-US To: Andreas Schwab CC: , Rick Chen , Leo , Lukasz Majewski , Sean Anderson , Lee Kuan Lim , "Jianlong Huang" , Emil Renner Berthing References: <20230316025332.3297-1-yanhong.wang@starfivetech.com> <20230316025332.3297-18-yanhong.wang@starfivetech.com> <25a31500-01c2-86c0-77fc-d8ba68c81a5d@starfivetech.com> <2a2021ee-2129-52e3-c570-a5d2e1bf8a66@starfivetech.com> From: yanhong wang In-Reply-To: Content-Type: text/plain; charset="UTF-8" X-Originating-IP: [171.223.208.138] X-ClientProxiedBy: EXCAS061.cuchost.com (172.16.6.21) To EXMBX073.cuchost.com (172.16.6.83) X-YovoleRuleAgent: yovoleflag Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 2023/3/23 16:31, Andreas Schwab wrote: > On M=C3=A4r 22 2023, yanhong wang wrote: >=20 >> On 2023/3/21 21:51, Andreas Schwab wrote: >>> On M=C3=A4r 21 2023, yanhong wang wrote: >>>=20 >>>> Except for CONFIG_DEFAULT_DEVICE_TREE and CONFIG_DEFAULT_FDT_FILE,=20 >>>> 1.2a and 1.3b versions use the same config.=20 >>>> >>>> Version 1.3b uses the following configuration:=20 >>>> CONFIG_DEFAULT_DEVICE_TREE=3D"jh7110-starfive-visionfive-2-v1.3b= "=20 >>>> CONFIG_DEFAULT_FDT_FILE=3D"starfive/jh7110-starfive-visionfive-2= -v1.3b.dtb" >>>> >>>> Version 1.2a uses the following configuration:=20 >>>> CONFIG_DEFAULT_DEVICE_TREE=3D"jh7110-starfive-visionfive-2-v1.2a= " >>>> CONFIG_DEFAULT_FDT_FILE=3D"starfive/jh7110-starfive-visionfive-2= -v1.2a.dtb" >>>> >>>> Is it necessary to separate the configs for 1.2a and 1.3b as separat= e defconfig files? >>>=20 >>> It makes a difference for when ethernet support is added. >>>=20 >> >> The difference between 1.2a and 1.3b versions is mainly in ethernet, s= o the definition of=20 >> dts is separated. Defconfig file in addition to the differences mentio= ned above, the others=20 >> are the same. Your suggestion is to define defconfig file separately, = is that right? >=20 > Yes, a 1.2a board will need to use the 1.2a device tree to get a workin= g > ethernet, IIUC. >=20 Okay, I will define the defconfig for 1.2A and 1.3B separately in the nex= t version.