Re: [RFC PATCH v1 9/9] tools: Add tool to create Renesas SPKG images

Sean Anderson
2022-08-09T17:15:55Z

Hi Ralph,

On 8/9/22 11:54 AM, Ralph Siemsen wrote:
> Hi Pali,
>
> On Tuesday 09 August 2022 15:03:48 Pali Rohár wrote:
>>
>> Hello! You can use for example config file, like it has kwbimage.c which
>> is integrated into mkimage and has support for NAND ECC settings.
>
> Thank you, I was unaware of this config file approach. From a quick
> look at doc/README.kwbimage it seems quite reasonable for
> device-specific parameters.
>
> On Tue, Aug 9, 2022 at 9:07 AM Pali Rohár <pali@kernel.org> wrote:
>>
>> Or another option could be to extend mkimage tool to accept new argument
>> for specifying NAND settings. As we can see more image formats have
>> support for it, so some abstraction in mkimage makes sense here.
>
> In principle I agree. But practically speaking I see two problems:
> 1) mkimage already has far too many options
> 2) covering all possible vendor-specific values/encodings of NAND
> parameters would be quite a task
>
> So I am inclined to keep it simple for now, and try using a config file.

The traditional way to handle this is to specify a config file with -n.
See e.g. mtk_image

--Sean