[U-Boot] [PATCH] mvgbe: remove setting of ethaddr within the driver

Wolfgang Denk
2011-11-08T22:52:56Z

Dear Michael Walle,

In message <201111082330.40253.michael@walle.cc> you wrote:
>
> > There are more clever ways than just to clear the environment. We have
> > "env export" and "env import", so you can create one or more backup
> > copies or user proviles. Instead of clearing the environment, you
> > could also load one such previously saved user profile, which then
> > would contain the MAC address.
>
> thanks for the hint, but there is only 512kb flash on this board (with 64k
> sectors). I don't think there is enough room for a second copy of the
> environment.

You don't need a separate sector. How bis is your environment/ I bet
if fits easily in 4 KiB or so - just find an unused part of a sector,
and put it there. Yes, upating it will be more complicated, as you
hav eto read that sector into RAM, replace the larst part, and write it
back, but resource-restricted systems require efficient use of memory.

> i think there are more boards like this, esp. since there is this mac
> randomization code within the mvgbe driver.

I don't want to have that in mainline.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The Buddha, the Godhead, resides quite as comfortably in the circuits
of a digital computer or the gears of a cycle transmission as he does
at the top of a mountain or in the petals of a flower.
- R. Pirsig, "Zen and the Art of Motorcycle Maintenance"