[U-Boot] [PATCH] mvgbe: remove setting of ethaddr within the driver

Holger Brunck
2011-11-10T17:00:33Z

On 11/10/2011 05:30 PM, Valentin Longchamp wrote:
> On 11/10/2011 04:53 PM, Wolfgang Denk wrote:
>> In message <20111110142152.GC29864@kw.sim.vm.gnt> you wrote:
>>>
>>> I suspect a lot of Marvell boards from being in the same case.
>>
>> Argh... I was not aware that the scope of damage already done was that
>> big.
>>
>
> On the Keymile boards (for marvell boards, km_kirkwood) we have an EEPROM that
> stores the ethaddr for each board, so we should not be affected by the removal
> of this "feature" (the driver setting ethaddr).
>

I gave it a try on km_kirkwood. What happens on keymile boards is that we get
the warning:
Warning: failed to set MAC address
if we initially start the board without an environment saved previously.

And this is better than writing a random mac adress into the HW, I guess...

Fortunately our boards in case of an initial boot are configuring different
things e.g. the correct ethaddr, do a saveenv and a reboot. And afterwards
everything is ok.

So yes for our boards it's ok to remove this code.

Best regards
Holger