[U-Boot] [PATCH] mvgbe: remove setting of ethaddr within the driver

Wolfgang Denk
2011-11-16T20:26:54Z

Dear Michael Walle,

In message <201111162115.33330.michael@walle.cc> you wrote:
>
> > Could you please revise your assessment? I would really appreciate if
> > we could clean this up.
> Regarding Prafulla's NAK?

Yes - I'd really appreciate if Prafulla woudl withdraw his NAK, and
agree on a cleanup. But he remains silent for a week or so...

> Let me sum up this thread once again:
> - consens is found that the driver should be cleaned up (removing the
> randomization code)
> - at least the keymile boards are ok with that. but there may be plenty of
> other boards which rely on this (broken?) behaviour.

The problem is this "may be". We don't know it, and we will never
find out. And even if we find such configurations, we have no
information if any user actually needs this feature. The only way to
really find out is by removing this stuff now. If anybody complains
then, we can discuss with him approaches to fix this again, in a clean
way.

> - besides the fact that a driver must not touch the environment, the mvgbe
> driver also fails to do this correctly for boards which has only the second
> port enabled.
> - Prafulla NAKed because only removing the code will leave some boards in a
> non-working state.
>
> i'm willing make a patch to move the randomization functionality to some
> generic place, but only if it is not NAKed by you beforehand. i dont have any
> time to waste ;)

Please don't move the broken code around. Let's remove it.

Let's give Prafulla another 2 or 3 days time to respond. If we don;t
hear from him, we go ahead.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Be careful what you wish for. You never know who will be listening.
- Terry Pratchett, _Soul Music_