public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Quentin Schulz <quentin.schulz@cherry.de>
To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>,
	Simon Glass <sjg@chromium.org>, Tom Rini <trini@konsulko.com>
Cc: Kory Maincent <kory.maincent@bootlin.com>,
	Mattijs Korpershoek <mkorpershoek@kernel.org>,
	Peng Fan <peng.fan@nxp.com>,
	Marek Vasut <marek.vasut+renesas@mailbox.org>,
	Martin Schwan <m.schwan@phytec.de>, Anshul Dalal <anshuld@ti.com>,
	George Chan <gchan9527@gmail.com>,
	u-boot@lists.denx.de
Subject: Re: [PATCH 1/1] boot: don't select non-existent CONFIG_VPL_CRYPTO
Date: Wed, 25 Feb 2026 09:37:44 +0100	[thread overview]
Message-ID: <ee169196-69a3-4003-8531-0ffa4e76bf6b@cherry.de> (raw)
In-Reply-To: <20260225073711.51688-1-heinrich.schuchardt@canonical.com>

Hi Heinrich,

On 2/25/26 8:37 AM, Heinrich Schuchardt wrote:
> Symbol CONFIG_VPL_CRYPTO does not exist.

Correct but I have a hunch this was based off of SPL_FIT_SIGNATURE which 
does require crypto support, so I'm assuming VPL would too.

But this symbol indeed never existed, and even if it did, it wouldn't 
compile anything else as far as I can tell since drivers/crypto is 
enabled by default in proper and only if CONFIG_SPL_CRYPTO is set for 
SPL, and only SPL (checking for !TPL and !VPL)... so something feels 
unfinished with VPL here to me.

I'm not sure we're improving anything there but I don't think it makes 
things worse, as such

Fixes: 4218456b3fac ("vbe: Add Kconfig options for VPL")

Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>

Thanks!
Quentin

  reply	other threads:[~2026-02-25  8:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-25  7:37 [PATCH 1/1] boot: don't select non-existent CONFIG_VPL_CRYPTO Heinrich Schuchardt
2026-02-25  8:37 ` Quentin Schulz [this message]
2026-02-25  9:06   ` Heinrich Schuchardt
2026-02-25 12:21     ` Heinrich Schuchardt
2026-02-26 14:53       ` Quentin Schulz
2026-02-26 23:44         ` Simon Glass
2026-03-10 20:45 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ee169196-69a3-4003-8531-0ffa4e76bf6b@cherry.de \
    --to=quentin.schulz@cherry.de \
    --cc=anshuld@ti.com \
    --cc=gchan9527@gmail.com \
    --cc=heinrich.schuchardt@canonical.com \
    --cc=kory.maincent@bootlin.com \
    --cc=m.schwan@phytec.de \
    --cc=marek.vasut+renesas@mailbox.org \
    --cc=mkorpershoek@kernel.org \
    --cc=peng.fan@nxp.com \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox