From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1CF70C0015E for ; Tue, 1 Aug 2023 11:58:02 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BAC9B86BFD; Tue, 1 Aug 2023 13:57:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1690891070; bh=ISmuyYfeB4Ka90GY13G9Z8XNQNvgpQL9T45/CwcMDmc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=FdNQuH0ZWZcmp2Lvc1ZKjbwQTcwbzvVwropi8JVHEtObnGgVx67ujfsuO4O361hCm gE28MxyRnL05mYOSHbcRjz2olcvMhUy+aaBpdzkhDhRWL9LMg/XmZVtw3nf6Su4Zo7 +0LS9xFCXkRYkf0EAYzCkH5wQVHcmYnyoXxWDtuTZsmnyqwjOPwTavKZ6a3WIH79J5 bOb62iPcISq9qO+PBgGb26UL8t7jS56PaFhFeP7U9dMipDmgaBDCtdcr+hO6megdgf A3YJ72s4Na/h7qwfTKsTamt9NNpUGoHdBfjcdUog7f3nLhuN6fKth4CzsbbYK7k0ij SZo8V6WEUsZGg== Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id E6CDA86BAF; Tue, 1 Aug 2023 13:57:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1690891068; bh=ISmuyYfeB4Ka90GY13G9Z8XNQNvgpQL9T45/CwcMDmc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=CuKbd1kyHWrwbdJrLn4ZiaGMbkv5VT9X0goFZjWX0LFUYoDJZ7BAr6ZOOBNZUpleM 3HWErLTlIyT0QaIbfcxoB3pqFqThAsOwBu5ASojDuujqo/QYoaCg62VO6anJ5ftfeY 4RSn2cVhmWrIFJm55qphhkWMJ5VmSOaFZ9hRkrgtg3+19JAXzCr7iO+zz4qjBpjB5A IO9yEAvQUkJry4fhGxQ/AikTcvlQ4GWphngWbTBfNcht2n0HsRImp8sPrwzU6PhXaw vm+hCZK7H80Kiy5ii9LPWv22L0wRdxqlPyu3HVpRDCNd8qH/omi122OAxznhYTsmyg +0MlsVfDZzd4Q== Message-ID: Date: Tue, 1 Aug 2023 13:44:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH v2 03/10] usb: dwc3: gadget: Don't send unintended link state change Content-Language: en-US To: Eugen Hristev , kever.yang@rock-chips.com, u-boot@lists.denx.de Cc: jonas@kwiboo.se, jagan@edgeble.ai, kernel@collabora.com, Venkatesh Yadav Abbarapu References: <20230801072811.10354-1-eugen.hristev@collabora.com> <20230801072811.10354-4-eugen.hristev@collabora.com> From: Marek Vasut In-Reply-To: <20230801072811.10354-4-eugen.hristev@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 8/1/23 09:28, Eugen Hristev wrote: > From: Venkatesh Yadav Abbarapu > > [ Nguyen/Felipe/Greg: Ported from Linux kernel commit > 5b738211fb59 ("usb: dwc3: gadget: Don't send > unintended link state change") ] > > DCTL.ULSTCHNGREQ is a write-only field. When doing a read-modify-write > to DCTL, the driver must make sure that there's no unintended link state > change request from whatever is read from DCTL.ULSTCHNGREQ. Set link > state change to no-action when the driver writes to DCTL. > > Signed-off-by: Venkatesh Yadav Abbarapu > --- > Not to be merged, I know Marek does not apply any patches to DWC3. NAK. The statement above is not true, see patch 02/10 .