From: Sean Anderson <seanga2@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH v1 3/8] spi: dw: Rename "cs-gpio" to "cs-gpios"
Date: Thu, 2 Apr 2020 08:33:27 -0400 [thread overview]
Message-ID: <eee2db49-e01a-7ece-bf2e-6fb435ffe39e@gmail.com> (raw)
In-Reply-To: <CAMty3ZCqrt5RC0M9HLSjQLV-yKAknoKAxGaGsE3d6oA8MpTcmQ@mail.gmail.com>
On 4/2/20 8:17 AM, Jagan Teki wrote:
> On Fri, Mar 6, 2020 at 12:49 AM Sean Anderson <seanga2@gmail.com> wrote:
>>
>> This property is named differently than other SPI drivers with the same
>> property, as well as the property as used in Linux.
>>
>> Signed-off-by: Sean Anderson <seanga2@gmail.com>
>> ---
>>
>> arch/arc/dts/axs10x_mb.dtsi | 3 ++-
>> arch/arc/dts/hsdk.dts | 3 ++-
>> drivers/spi/designware_spi.c | 10 +++-------
>
> Better separate the dts changes and add sha1 from Linux if it synced.
>
This is not from a specific patch; I just noticed that it was different
and changed it. I think it is clearer to include dts changes with the
code change. That way if someone is reviewing the device tree, it is
obvious why the change was made. Splitting the changes would also make
the code not run properly for the intermediate commit. This can be
annoying when bisecting. However, if you would still like it split, I
can do that.
--Sean
next prev parent reply other threads:[~2020-04-02 12:33 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 19:19 [PATCH v1 0/8] riscv: Add SPI support for Kendryte K210 Sean Anderson
2020-03-05 19:19 ` [PATCH v1 1/8] doc: Fix typo in FIT documentation Sean Anderson
2020-03-22 1:52 ` Marek Vasut
2020-03-23 13:58 ` Tom Rini
2020-03-05 19:19 ` [PATCH v1 2/8] spi: dw: Add device tree properties for fields in CTRL0 Sean Anderson
2020-03-22 1:51 ` Marek Vasut
2020-03-22 2:36 ` Sean Anderson
2020-03-22 3:04 ` Marek Vasut
2020-03-22 3:08 ` Sean Anderson
2020-03-22 3:13 ` Marek Vasut
2020-03-22 3:33 ` Sean Anderson
2020-03-22 4:22 ` Marek Vasut
2020-03-05 19:19 ` [PATCH v1 3/8] spi: dw: Rename "cs-gpio" to "cs-gpios" Sean Anderson
2020-04-02 12:17 ` Jagan Teki
2020-04-02 12:33 ` Sean Anderson [this message]
2020-03-05 19:19 ` [PATCH v1 4/8] spi: dw: Use generic function to read reg address Sean Anderson
2020-04-02 12:24 ` Jagan Teki
2020-04-02 12:32 ` Sean Anderson
2020-03-05 19:19 ` [PATCH v1 5/8] spi: dw: Speed up transfer loops Sean Anderson
2020-03-22 1:49 ` Marek Vasut
2020-03-22 3:54 ` Sean Anderson
2020-03-05 19:19 ` [PATCH v1 6/8] spi: dw: Add mem_ops Sean Anderson
2020-03-05 22:15 ` Eugeniy Paltsev
2020-03-06 0:48 ` Sean Anderson
2020-03-06 17:03 ` Eugeniy Paltsev
2020-03-06 20:36 ` Sean Anderson
2020-03-06 21:20 ` Sean Anderson
2020-03-12 16:01 ` Eugeniy Paltsev
2020-03-05 19:19 ` [PATCH v1 7/8] riscv: Add device tree bindings for SPI Sean Anderson
2020-03-22 1:55 ` Marek Vasut
2020-03-22 2:39 ` Sean Anderson
2020-03-05 19:19 ` [PATCH v1 8/8] riscv: Add support for SPI on Kendryte K210 Sean Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eee2db49-e01a-7ece-bf2e-6fb435ffe39e@gmail.com \
--to=seanga2@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox