From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Anderson Date: Thu, 2 Apr 2020 08:33:27 -0400 Subject: [PATCH v1 3/8] spi: dw: Rename "cs-gpio" to "cs-gpios" In-Reply-To: References: <20200305191925.959494-1-seanga2@gmail.com> <20200305191925.959494-4-seanga2@gmail.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 4/2/20 8:17 AM, Jagan Teki wrote: > On Fri, Mar 6, 2020 at 12:49 AM Sean Anderson wrote: >> >> This property is named differently than other SPI drivers with the same >> property, as well as the property as used in Linux. >> >> Signed-off-by: Sean Anderson >> --- >> >> arch/arc/dts/axs10x_mb.dtsi | 3 ++- >> arch/arc/dts/hsdk.dts | 3 ++- >> drivers/spi/designware_spi.c | 10 +++------- > > Better separate the dts changes and add sha1 from Linux if it synced. > This is not from a specific patch; I just noticed that it was different and changed it. I think it is clearer to include dts changes with the code change. That way if someone is reviewing the device tree, it is obvious why the change was made. Splitting the changes would also make the code not run properly for the intermediate commit. This can be annoying when bisecting. However, if you would still like it split, I can do that. --Sean