From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87DAEC38142 for ; Mon, 23 Jan 2023 08:37:37 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 139A58576E; Mon, 23 Jan 2023 09:36:46 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="WC7+1Vnq"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 42A838574F; Mon, 23 Jan 2023 09:31:30 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2057.outbound.protection.outlook.com [40.107.237.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B571E85753 for ; Mon, 23 Jan 2023 09:30:18 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=michal.simek@amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PesrFpLjfDgMx7b5vj7Cok0sRiSZUP6Mm5IKs5Ox8Ss6FWDXNnXeRDutThc3UUSO6s3m7x5Ylrjg2/z8qFBC8wnlGVpr8FhwLlVsueUfNjpvIp+HFmo3iNpD0VxRh4bzIyrVIIxq918xITQXKMFPikYGPIpMCz6c1sg3ZFBu86VPSPE4c9oN3E2fHzzBLcKDDUpQlPLTerwSDLVFtczOUlhNQ1tgAqGVXE6w/i5/3ipgm47xRyciiktQUb/H5DTjbmnXFy4UP1EBA3bGpazN1xz79mLfw3anFn/rWlmpJ7VEvAO2DYZuS038RrOciLkTJVYlS9C8Pr2w3O78FnSW4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d3UOyRzvhWTRo4OOyKtcbPrOIxtRJ8CMzoHGeMJm/UI=; b=ETJqdUyfnfqZV/9D+GDffwwLEKF/1hkknfh5olpXdykcTgWB8seNrBCXybIDwKJk64DBfe4KM5fFsBOUNulvUx+Bv6BwxdQW02dg87hEGR8+SJn1ylXtpf0WbpXVou8od8xiBsnCUllB0a4nNvGzbQIAH2Nl6PE/qGc8Uz0AtIzR4cWl+eErh3Om0NSpvBMwOYPGtHavaoucKe/xcrV87MTah2u0pLCRbCkOM0qrMRNpIweXztwP3e0PribZfwzPmkDoi4CszawRT2HMuvlsLeLNiWuMYxi3sdSQ1V/YD25H9aDBlEIolfXaoAdplLOwIHMNbCFKwF4wKlVbhBE7Zw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=gmail.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d3UOyRzvhWTRo4OOyKtcbPrOIxtRJ8CMzoHGeMJm/UI=; b=WC7+1VnqWLEIEVkVJDjMqhGSC1+H6X1l8CLgRMqn51nwZ7q0gQcQuD3GReEwrRU2fb4YYGQc3XS3akl/ETalZlA+KyjJTnCemljmF3yv53oVbCmqGZKlj4cIyaZzkc7gNYaXV4Wj1+omytsv69f7IHKLhcHHPlvqyLQ972Syjow= Received: from MW4PR03CA0179.namprd03.prod.outlook.com (2603:10b6:303:8d::34) by CY5PR12MB6372.namprd12.prod.outlook.com (2603:10b6:930:e::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.33; Mon, 23 Jan 2023 08:30:11 +0000 Received: from CO1NAM11FT041.eop-nam11.prod.protection.outlook.com (2603:10b6:303:8d:cafe::3e) by MW4PR03CA0179.outlook.office365.com (2603:10b6:303:8d::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.33 via Frontend Transport; Mon, 23 Jan 2023 08:30:10 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT041.mail.protection.outlook.com (10.13.174.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6023.16 via Frontend Transport; Mon, 23 Jan 2023 08:30:10 +0000 Received: from [10.254.241.50] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 23 Jan 2023 02:30:06 -0600 Message-ID: Date: Mon, 23 Jan 2023 09:30:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-US To: Ovidiu Panait , CC: Alper Nebi Yasak , Andrew Davis , Michal Simek , Simon Glass , Stefan Roese References: <20230122180255.1246963-1-ovpanait@gmail.com> From: Michal Simek Subject: Re: [PATCH] microblaze: spl: drop boot_linux and disable falcon mode by default In-Reply-To: <20230122180255.1246963-1-ovpanait@gmail.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT041:EE_|CY5PR12MB6372:EE_ X-MS-Office365-Filtering-Correlation-Id: 9d4fe54d-f11b-4d4e-309a-08dafd1c0aaa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: r3IlMMXlIhsmbvhrluwhHlyyilAdJlB0IKWk8emM/Dc4SohQCBcwsSFC9plIFa6S8eLcrVuWTyVJdmhRk7GNKYKQDl2c/FX9EP1ipch2HiMpF0gVHlXbyXu4+xOmMKmk7TXlb4Nxsw03yK9F9vfoCxa3284HdGGxufTDQrtl5bBUB6dvjjKIcXkcwt8gVmYuBAkkf1Kfz1qhw+rjsxYuJYNRo3DbscgVAdwVURY7K38/seI2emdbBKT0ZhYWisaR7DEWXCxtIB/lNaExYgpoWdgU7EQLDmScwGB0bgY7uWdjkimYpAgJVmn1Bz3CvEICzeeCV3hpOWESLp/eOx5/UUkbTQadoDCFRg3iviEepZ3SHkr4i/EWTVUPyGB7YPGJhcXjATEO9KvsP6F2zYh0rnTG6p7D2QOJbG8Mo24WYZanhbL6L6T8dT5Yq0xA/MR3lFxHoamWdE7SFflrEzNqvn4hzipQvX+BQv+4sFf18ke7R53dN51i1BgUO4rm/AQespyPW99ALriVbK2DamqGRZM8M4gAXKySouuhNKt87g4kEtAoE5jVHgSFvnW9T1K+JifgnfiumEzmTWp0tlLkKgnOp+AlK4WXN4SHMGH3QmGYZr6IS5EfLyfWjmkqqtGv92E/hst1dDXtrIA12giGoCn94nsEZPg1tqMhdoq4RZaBqf587ShFzWrwgJCLi29xYJ9uBizCAbCdODmqWd5p3wklrLRQ2AwTIQGyzUrJ33/CPl0tsRVK6nMadfAYSLqVmc2iq1KrkFSAxPPxEB8hVg== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230022)(4636009)(396003)(136003)(39860400002)(346002)(376002)(451199015)(36840700001)(40470700004)(46966006)(36860700001)(83380400001)(31696002)(82740400003)(5660300002)(86362001)(81166007)(356005)(2906002)(41300700001)(44832011)(8936002)(82310400005)(4326008)(40480700001)(40460700003)(8676002)(186003)(53546011)(16526019)(26005)(47076005)(426003)(336012)(316002)(16576012)(70206006)(2616005)(54906003)(70586007)(110136005)(478600001)(31686004)(36756003)(36900700001)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2023 08:30:10.4465 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9d4fe54d-f11b-4d4e-309a-08dafd1c0aaa X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT041.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6372 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 1/22/23 19:02, Ovidiu Panait wrote: > Make spl_start_uboot() available only if CONFIG_SPL_OS_BOOT is enabled this is one patch > and drop boot_linux, as the variable is not assigned anywhere. This is another patch. > > Also, disable CONFIG_SPL_OS_BOOT in defconfig so that a > microblaze-generic_defconfig build will still boot into u-boot proper, as > it does currently. This is third patch. > > Signed-off-by: Ovidiu Panait > --- > > arch/microblaze/cpu/spl.c | 11 ++--------- > common/spl/Kconfig | 2 ++ > configs/microblaze-generic_defconfig | 3 --- > 3 files changed, 4 insertions(+), 12 deletions(-) > > diff --git a/arch/microblaze/cpu/spl.c b/arch/microblaze/cpu/spl.c > index cea6d56f16..eaa095ba99 100644 > --- a/arch/microblaze/cpu/spl.c > +++ b/arch/microblaze/cpu/spl.c > @@ -14,8 +14,6 @@ > #include > #include > > -bool boot_linux; > - > void board_boot_order(u32 *spl_boot_list) > { > spl_boot_list[0] = BOOT_DEVICE_NOR; > @@ -41,17 +39,12 @@ void __noreturn jump_to_image_linux(struct spl_image_info *spl_image) > > image_entry(NULL, 0, (ulong)spl_image->arg); > } > -#endif /* CONFIG_SPL_OS_BOOT */ > > int spl_start_uboot(void) > { > -#ifdef CONFIG_SPL_OS_BOOT > - if (boot_linux) > - return 0; > -#endif > - > - return 1; > + return 0; > } > +#endif /* CONFIG_SPL_OS_BOOT */ > > int do_reset(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]) > { > diff --git a/common/spl/Kconfig b/common/spl/Kconfig > index 3c2af453ab..de6d8c3a18 100644 > --- a/common/spl/Kconfig > +++ b/common/spl/Kconfig > @@ -1081,6 +1081,7 @@ config SYS_SPL_ARGS_ADDR > hex "Address in memory to load 'args' file for Falcon Mode to" > depends on SPL_OS_BOOT > default 0x88000000 if ARCH_OMAP2PLUS > + default 0x2a000000 if MICROBLAZE I prefer not to do it because on microblaze all these addresses are just examples anyway. It means don't need to record current values there. > help > Address in memory where the 'args' file, typically a device tree > will be loaded in to memory. > @@ -1092,6 +1093,7 @@ config SYS_NAND_SPL_KERNEL_OFFS > config SYS_OS_BASE > hex "addr, where OS is found" > depends on SPL_OS_BOOT && SPL_NOR_SUPPORT > + default 0x2c060000 if MICROBLAZE Same here. > help > Specify the address, where the OS image is found, which > gets booted. > diff --git a/configs/microblaze-generic_defconfig b/configs/microblaze-generic_defconfig > index be34941805..438540fbe4 100644 > --- a/configs/microblaze-generic_defconfig > +++ b/configs/microblaze-generic_defconfig > @@ -33,9 +33,6 @@ CONFIG_SPL_SYS_MALLOC_SIMPLE=y > # CONFIG_SPL_SHARES_INIT_SP_ADDR is not set > CONFIG_SPL_STACK=0x100000 > CONFIG_SPL_NOR_SUPPORT=y > -CONFIG_SPL_OS_BOOT=y > -CONFIG_SYS_SPL_ARGS_ADDR=0x2a000000 > -CONFIG_SYS_OS_BASE=0x2c060000 This is fine just to remove these addresses. > CONFIG_SYS_MAXARGS=15 > CONFIG_SYS_CBSIZE=512 > CONFIG_SYS_PBSIZE=544 Thanks, Michal