public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Sam Edwards <cfsworks@gmail.com>
To: u-boot@lists.denx.de
Subject: Re: [RFC PATCH v1 2/3] spi: sunxi: Add support for R329/D1/R528/T113 SPI controller
Date: Tue, 23 May 2023 18:14:55 -0600	[thread overview]
Message-ID: <ef71dd88-37a0-78f7-8705-bbc77a61ff36@gmail.com> (raw)
In-Reply-To: <20230519134010.3102343-3-bigunclemax@gmail.com>

Hi Maxim,

By any chance do you happen to know when in sunxi history the SPI 
controller grew QuadSPI/DualSPI support? It'd probably be feature creep 
to have in this patch series, but since they don't look too hard to 
implement, I might be interested in taking a stab at supporting them.

On 5/19/23 07:40, Maxim Kiselev wrote:
> These SoCs have two SPI controllers that are quite similar to the SPI
> on previous Allwinner SoCs. The main difference is that new SoCs
> don't have a clock divider (SPI_CCR register) inside SPI IP.
> 
> Instead SPI sample mode should be configured depending on the input clock.
> 
> For now SPI input clock source selection is not supported by this driver,
> and only HOSC@24MHz can be used as input clock. Therefore, according to
> the, manual we could change the SPI sample mode from delay half
> cycle(default) to normal.
> 
> This patch adds a quirk for this kind of SPI controllers
> 
> Signed-off-by: Maxim Kiselev <bigunclemax@gmail.com>

Tested-by: Sam Edwards <CFSworks@gmail.com>

Cheers,
Sam

  reply	other threads:[~2023-05-24  0:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-19 13:40 [RFC PATCH v1 0/3] Allwinner R329/D1/R528/T113s SPI support Maxim Kiselev
2023-05-19 13:40 ` [RFC PATCH v1 1/3] sunxi: SPL SPI: Add SPI boot support for the Allwinner R528/T113 SoCs Maxim Kiselev
2023-06-05 21:07   ` Sam Edwards
2023-05-19 13:40 ` [RFC PATCH v1 2/3] spi: sunxi: Add support for R329/D1/R528/T113 SPI controller Maxim Kiselev
2023-05-24  0:14   ` Sam Edwards [this message]
2023-05-24 12:50     ` Maksim Kiselev
2023-05-19 13:40 ` [RFC PATCH v1 3/3] riscv: dts: allwinner: d1: Add SPI controllers node Maxim Kiselev
2023-05-24  0:09   ` Sam Edwards

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ef71dd88-37a0-78f7-8705-bbc77a61ff36@gmail.com \
    --to=cfsworks@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox