Re: [PATCH] rockchip: rk3308: Drop unused rk_board_init()

Quentin Schulz
2024-11-06T13:49:09Z

Hi Jonas,

On 11/2/24 9:45 PM, Jonas Karlman wrote:
> Nothing is calling the function rk_board_init() and the io-domain driver
> can handle the functions intended purpose based on information from DT.
>
> Cleanup by removing the unused rk_board_init() function and re-sort
> included headers.
>
> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>

git log -p -S rk_board_init

only returns one match and it's the introducing commit in which this
function seemingly is never called.

I'm really wondering why this wasn't shown as a warning by GCC?

Since this is the IO domain for storage medium on RK3308, shouldn't we
make sure the IO domain is enabled in SPL for fallback mechanism (i.e.
proper isn't found on the same storage medium as the one used for
loading SPL)?

The IODOMAIN isn't even enabled in proper for the EVB and the ROC-CC
board. And there isn't an IODOMAIN symbol for SPL in Kconfig AFAICT?

Not that this commit would change anything, so:

Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>

Thanks!
Quentin