From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 81740C001DC for ; Wed, 26 Jul 2023 16:41:57 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E1A57860A6; Wed, 26 Jul 2023 18:41:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.b="jhzkI9og"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 51A5D8474B; Wed, 26 Jul 2023 18:41:54 +0200 (CEST) Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C390A8639D for ; Wed, 26 Jul 2023 18:41:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=afd@ti.com Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 36QGfh0D002070; Wed, 26 Jul 2023 11:41:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1690389703; bh=wO7ZIxkfo72YLYWG3xf7+hVwG1I/US+jcQOO82VwQUk=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=jhzkI9ogAYMq1khw9vF/gtT/m9kiJ2exXcuXFwnglAiel81MLCLsltEjL+etXwSDG Wyh5feW1yiv6yXfOr7hHLcaSfSpDLtaxWnf3JLHcn4d5tmUCYK1jEyiqpkfctgl2eU zw3PDMEcvm3gsT574f3fS5pA4Uldu81D6ohN2kq0= Received: from DLEE102.ent.ti.com (dlee102.ent.ti.com [157.170.170.32]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 36QGfh5q089088 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 26 Jul 2023 11:41:43 -0500 Received: from DLEE107.ent.ti.com (157.170.170.37) by DLEE102.ent.ti.com (157.170.170.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Wed, 26 Jul 2023 11:41:42 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE107.ent.ti.com (157.170.170.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Wed, 26 Jul 2023 11:41:42 -0500 Received: from [10.250.32.114] (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 36QGfg9o006214; Wed, 26 Jul 2023 11:41:42 -0500 Message-ID: Date: Wed, 26 Jul 2023 11:41:42 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 6/6] doc: board: ti: Add beagleplay documentation Content-Language: en-US To: Tom Rini CC: Nishanth Menon , Neha Malcom Francis , Bryan Brattlof , Praneeth Bajjuri , Robert Nelson , Vignesh R , References: <20230725185253.2123433-1-nm@ti.com> <20230725185253.2123433-7-nm@ti.com> <20230725213552.GJ3630934@bill-the-cat> <20230725220015.i5dctounavfnsobg@wrinkle> <20230725224539.GM3630934@bill-the-cat> <20230726162147.GT3630934@bill-the-cat> From: Andrew Davis In-Reply-To: <20230726162147.GT3630934@bill-the-cat> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 7/26/23 11:21 AM, Tom Rini wrote: > On Wed, Jul 26, 2023 at 09:59:16AM -0500, Andrew Davis wrote: >> On 7/25/23 5:45 PM, Tom Rini wrote: >>> On Tue, Jul 25, 2023 at 05:00:15PM -0500, Nishanth Menon wrote: >>>> On 17:35-20230725, Tom Rini wrote: >>>>> On Tue, Jul 25, 2023 at 01:52:53PM -0500, Nishanth Menon wrote: >>>>> >>>> [...] >>>> >>>>>> + >>>>>> +Build procedure: >>>>>> +---------------- >>>>>> +1. Trusted Firmware-A: >>>>>> + >>>>>> +.. code-block:: bash >>>>>> + >>>>>> + $ make CROSS_COMPILE=aarch64-none-linux-gnu- ARCH=aarch64 PLAT=k3 \ >>>>>> + TARGET_BOARD=lite SPD=opteed >>>>>> + >>>>>> +2. OP-TEE: >>>>>> + >>>>>> +.. code-block:: bash >>>>>> + >>>>>> + $ make PLATFORM=k3 CFG_ARM64_core=y CROSS_COMPILE=arm-none-linux-gnueabihf- \ >>>>>> + CROSS_COMPILE64=aarch64-none-linux-gnu- >>>>> >>>>> So, we have some generic wording on how to build TF-A and OP-TEE up in >>>>> doc/board/ti/k3.rst. It should be made clearer if needed that unless >>>>> otherwise indicated, top of tree is expected to be used for TF-A/OP-TEE >>>>> and ti-linux-firmware for the ti-linux-firmware repo. Then just state >>>>> that TF-A should be which of {lite|generic|j784s4} as it is a $family >>>>> device. And we then drop much of the duplication here. >>>> >>>> Also, Robert pointed out I missed K3_PM_SYSTEM_SUSPEND=1 :( >>> >>> Ugh, how many platforms is that variable valid for? >>> >> None soon :) >> >> I'm getting rid of that flag in TF-A. There is a bug blocking me right now, >> but after that it will be automatic. Not sure if it is worth documenting a >> flag that is going away.. > > OK. But, automatic how? What I'm getting at, from both a documentation > standpoint and also how I run my labs standpoint, is that it seems like > instead of having a set of TF-A and OP-TEE binaries for each TI K3 > platform I have, I really need just 3 different TF-A builds (well, in > reality I don't have the J784s4 stuff so just 2) and a single OP-TEE > build. > If you don't have the flag K3_PM_SYSTEM_SUSPEND=1 today then some LPM modes in Linux will be unavailable, that would be the only problem, not sure if that matters to your testing. You will need one OP-TEE per platform, for TF-A we combine some platforms into groups (generic: AM65,J7* ; lite: AM64*,AM62*). Depending on features we add in the future, even this grouping may also go away at some point, so it will match OP-TEE (one TF-A build per platform). Andrew