From: Niklaus Giger <niklaus.giger@member.fsf.org>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Add first Netstal board HCU4
Date: Fri, 06 Apr 2007 18:22:28 +0200 [thread overview]
Message-ID: <ev5s44$qoo$2@sea.gmane.org> (raw)
In-Reply-To: 200704041740.00521.sr@denx.de
Hi Stefan
Here it is. bzipped because of the size limitation. I reworked it
slightly and tried harder to follow the Linux kernel coding style.
I used the following commands for my workflow (Could not find a clear
entry in the WiKi for a simple example tailored to the u-boot).
$ git clone http://source.denx.net/git/u-boot.git u-boot.git
$ cd u-boot.git
Then I added the following lines to .git/config
>[user]
>name???=???????"Niklaus Giger"
>email??=???????"niklaus.giger at netstal.com"
<added/edited some files>
$ git add <for each new directory or file>
Used "git status" to check whether I added all new files correcty.
Used "git diff origin --check" to look for trailing/superfluous
whitespaces.
Used "git diff origin -p --summary origin" to preview my changes.
Once I was satisfied, I preceeded with
$ git-commit --all --signoff -m "Add first Netstal board HCU4: Second
try"
$ git-format-patch origin
$ mv 0001-Add-first-Netstal-board-HCU4-Second-try.patch \
Add-first-Netstal-board-HCU4-Second-try.patch
$ gzip Add-first-Netstal-board-HCU4-Second-try.patch
Is this a good workflow?
>>> Stefan Roese<sr@denx.de> 04.04.07 17:40:00 >>>
>Hi Niklaus,
>
>sorry for the delay. Could you please resubmit the HCU4 patch against
the
>current top-of-git repository? I promise to review it now quickly.
I will be absent from office the next two weeks, but will have a look at
your comments sooner.
Best regards
--
Niklaus Giger
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Add-first-Netstal-board-HCU4-Second-try.patch.gz
Type: application/x-gzip
Size: 15319 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20070406/9494f8bf/attachment.bin
next prev parent reply other threads:[~2007-04-06 16:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-09 20:37 [U-Boot-Users] [PATCH] Add first Netstal board HCU4 Niklaus Giger
2007-02-10 7:59 ` Stefan Roese
2007-02-10 9:01 ` Niklaus Giger
2007-02-10 19:15 ` Stefan Roese
2007-02-12 18:13 ` [U-Boot-Users] Antw: " Niklaus Giger
2007-02-12 19:25 ` Stefan Roese
2007-02-14 17:10 ` Niklaus Giger
2007-04-04 15:30 ` Stefan Roese
2007-04-06 16:16 ` Niklaus Giger
2007-04-06 16:58 ` Stefan Roese
2007-04-06 19:31 ` Wolfgang Denk
2007-04-06 19:39 ` Wolfgang Denk
2007-04-10 6:55 ` Stefan Roese
2007-04-10 8:30 ` Stefan Roese
2007-04-04 15:40 ` [U-Boot-Users] " Stefan Roese
2007-04-06 16:22 ` Niklaus Giger [this message]
2007-04-10 12:36 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='ev5s44$qoo$2@sea.gmane.org' \
--to=niklaus.giger@member.fsf.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox