public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/7] arm: socfpga: Convert FPGA configuration to Kconfig method.
Date: Tue, 9 May 2017 09:58:16 +0200	[thread overview]
Message-ID: <f00ee906-e591-e76c-286c-aef10347af50@denx.de> (raw)
In-Reply-To: <1494306178.11021.26.camel@intel.com>

On 05/09/2017 07:02 AM, Chee, Tien Fong wrote:
> On Isn, 2017-05-08 at 11:57 +0200, Marek Vasut wrote:
>> On 05/08/2017 05:02 AM, Chee, Tien Fong wrote:
>>>
>>> On Jum, 2017-05-05 at 13:11 +0200, Marek Vasut wrote:
>>>>
>>>> On 05/05/2017 12:26 PM, tien.fong.chee at intel.com wrote:
>>>>>
>>>>>
>>>>> From: Tien Fong Chee <tien.fong.chee@intel.com>
>>>>>
>>>>> Convert Macro #define configuration to Kconfig method. All FPGA
>>>>> devices
>>>>> enable configuration based on CONFIG_FPGA_ALTERA.
>>>>>
>>>>> Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com>
>>>>> ---
>>>>>  drivers/fpga/Kconfig             |    5 ++++-
>>>>>  drivers/fpga/Makefile            |    3 +--
>>>>>  include/altera.h                 |    2 +-
>>>>>  include/configs/socfpga_common.h |    3 ---
>>>>>  4 files changed, 6 insertions(+), 7 deletions(-)
>>>>>
>>>>> diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
>>>>> index a760944..fc4ea0d 100644
>>>>> --- a/drivers/fpga/Kconfig
>>>>> +++ b/drivers/fpga/Kconfig
>>>>> @@ -2,12 +2,15 @@ menu "FPGA support"
>>>>>  
>>>>>  config FPGA
>>>>>  	bool
>>>>> +	help
>>>>> +	  Enable FPGA driver build.
>>>> Separate patch please , also this is not driver, but framework .
>>>> There's
>>>> not just drivers here IMO.
>>>>
>>> ohh...okay, so you prefer i revert the changes, or better
>>> explanation
>>> in separate patch? if for later,what is your suggestion? Thanks.
>> Turning this whole FPGA subsystem into Kconfig should be a separat
>> patch. There's a script for that too and you need to convert and
>> build
>> test all the boards which define CONFIG_FPGA .
>>
> Okay, this patch is specific for turning whole FPGA sybsytem into
> Kconfig. I will use moveconfig.py for this. thanks.
>>>
>>>>
>>>>>
>>>>>  config FPGA_ALTERA
>>>>>  	bool "Enable Altera FPGA drivers"
>>>>> +	default y if TARGET_SOCFPGA_GEN5 && CMD_FPGA
>>>> Should be selected by arch code, drop this.
>>>>
>>> just for clarity, are you means defconfig == "selected by arch
>>> code"?
>> I mean arch/arm/mach-socfpga/Kconfig
>>
> With moveconfig.py, i think this change is not required.

So, who will enable FPGA_ALTERA ?

[...]

-- 
Best regards,
Marek Vasut

  reply	other threads:[~2017-05-09  7:58 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-05 10:26 [U-Boot] [PATCH 0/7] Add Intel Arria 10 SoC FPGA driver tien.fong.chee at intel.com
2017-05-05 10:26 ` [U-Boot] [PATCH 1/7] arm: socfpga: Remove unused passing parameter of socfpga_bridges_reset tien.fong.chee at intel.com
2017-05-05 11:09   ` Marek Vasut
2017-05-08  4:17     ` Chee, Tien Fong
2017-05-08  9:52       ` Marek Vasut
2017-05-09  4:23         ` Chee, Tien Fong
2017-05-09  7:56           ` Marek Vasut
2017-05-10  8:34             ` Chee, Tien Fong
2017-05-05 10:26 ` [U-Boot] [PATCH 2/7] arm: socfpga: Convert FPGA configuration to Kconfig method tien.fong.chee at intel.com
2017-05-05 11:11   ` Marek Vasut
2017-05-08  3:02     ` Chee, Tien Fong
2017-05-08  9:57       ` Marek Vasut
2017-05-09  5:02         ` Chee, Tien Fong
2017-05-09  7:58           ` Marek Vasut [this message]
2017-05-10  8:28             ` Chee, Tien Fong
2017-05-11  4:09               ` Chee, Tien Fong
2017-05-11 11:47                 ` Marek Vasut
2017-05-05 10:26 ` [U-Boot] [PATCH 3/7] arm: socfpga: Restructure FPGA driver in the preparation to support A10 tien.fong.chee at intel.com
2017-05-05 11:13   ` Marek Vasut
2017-05-08  4:39     ` Chee, Tien Fong
2017-05-08 10:16       ` Marek Vasut
2017-05-09  4:00         ` Chee, Tien Fong
2017-05-05 10:26 ` [U-Boot] [PATCH 4/7] arm: socfpga: Move FPGA manager driver to FPGA driver tien.fong.chee at intel.com
2017-05-05 10:26 ` [U-Boot] [PATCH 5/7] arm: socfpga: Move the FPGA driver header from arch to include directory tien.fong.chee at intel.com
2017-05-05 10:26 ` [U-Boot] [PATCH 6/7] arm: socfpga: Add Arria10 FPGA manager program assembly driver tien.fong.chee at intel.com
2017-05-05 11:14   ` Marek Vasut
2017-05-08  4:03     ` Chee, Tien Fong
2017-05-05 10:26 ` [U-Boot] [PATCH 7/7] arm: socfpga: Add FPGA driver support for Arria 10 tien.fong.chee at intel.com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f00ee906-e591-e76c-286c-aef10347af50@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox