From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Mon, 29 Apr 2019 13:06:57 +0200 Subject: [U-Boot] [PATCH 4/8] spi: Kconfig: Mark MXS_SPI has BROKEN In-Reply-To: References: <20190428204801.9578-1-jagan@amarulasolutions.com> <20190428204801.9578-5-jagan@amarulasolutions.com> <6fe0f6a5-bd72-9871-2384-ccb5f231a01f@denx.de> <7e708e0b-9b2c-1870-ab72-5e991358832f@denx.de> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 4/29/19 1:02 PM, Jagan Teki wrote: > On Mon, Apr 29, 2019 at 4:28 PM Marek Vasut wrote: >> >> On 4/29/19 12:40 PM, Jagan Teki wrote: >>> On Mon, Apr 29, 2019 at 3:24 PM Marek Vasut wrote: >>>> >>>> On 4/28/19 10:47 PM, Jagan Teki wrote: >>>>> Mark MXS_SPI has BROKEN, this so the resulting build shows >>>>> warning for broken configuration enabled and associated code >>>>> will remove in v2019.07 release. >>>> >>>> But the code is not broken, it works fine, right ? >>> >>> Yes the code work fine, but dm conversion not done yet. Now the >>> CONFIG_BROKEN can mark the driver configs which doesn't convert dm >> >> That makes no sense, if the code works, it works and thus it is NOT >> broken. Find some other way to flag it as non-DM-converted, not this hack. > > np, It depends on whether we consider non-dm code(for legacy SPI > drivers) is broken or not, let Tom comment on this. Again, the code works, it's not broken. That's very clear. DM conversion is a separate matter, so let's not overload CONFIG_BROKEN for such things. The Makefile warning seems sufficient to me. -- Best regards, Marek Vasut