From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 15D6CC433F5 for ; Fri, 14 Jan 2022 15:35:10 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CEEA4833A2; Fri, 14 Jan 2022 16:35:08 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1642174509; bh=LkDZxdXNUGoDppC1rSs1N3wSEWawspQSyTVNTLBOMY4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=aSuaOWxvwJgMZ5+bo3CSL5dtxvrNGZVdpuuT83WzZo7YmaVeuiNdAxp6Zz1b+BAnW aRucuj+Tp9m9hgHU8v09tZGUO2/AejbQfYayWsLbPO9EE5n69dq1hLzIDcyNnwvmgP ev9AnXw9DXy1iXbHZeiLP6FeKw6BGVm9fzuPirEJ+Oo8wV1Q62cIZ43CoLTTFf5fwA 6WgimMwdJLcTYhJiNYvEqKWlh77kwQKev6X9iVVX+IpFcxsi1H2G2GVzgWFFgteTda RxuXu7itouF3yvWzRGFtMLrNpWhNTSdjvN0inbcPaDeUVRtv7gfwNao7ZNCAmoZlIL zA/NhBVHtehLA== Received: by phobos.denx.de (Postfix, from userid 109) id 93C548341A; Fri, 14 Jan 2022 16:35:07 +0100 (CET) Received: from mout-u-204.mailbox.org (mout-u-204.mailbox.org [IPv6:2001:67c:2050:1::465:204]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 334E983394 for ; Fri, 14 Jan 2022 16:35:04 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:105:465:1:3:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-204.mailbox.org (Postfix) with ESMTPS id 4Jb52v53F8zQkH3; Fri, 14 Jan 2022 16:35:03 +0100 (CET) Message-ID: Date: Fri, 14 Jan 2022 16:34:58 +0100 MIME-Version: 1.0 Subject: Re: [PATCH] mtd: nand: pxa3xx: use marvell, prefix for custom DT properties Content-Language: en-US To: Pierre Bourdon , u-boot@lists.denx.de Cc: Baruch Siach , Konstantin Porotchkin References: <20211225044629.1322122-1-delroth@gmail.com> From: Stefan Roese In-Reply-To: <20211225044629.1322122-1-delroth@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 12/25/21 05:46, Pierre Bourdon wrote: > The DT properties for the "enable-arbiter" and "keep-config" config > knobs were previously named inconsistently: > > - The u-boot driver used "nand-enable-arbiter" and "nand-keep-config" > names, without Marvell prefixes. > > - The Linux driver uses "marvell,nand-keep-config" ("enable-arbiter" > does not exist anymore in recent kernels, but it also used to be > "marvell,nand-enable-arbiter"). > > - The device trees almost all use "marvell," prefixed names, except for > one single instance of "nand-enable-arbiter" without vendor prefix. > > This commit standardizes on the vendor prefixed version, making the > u-boot driver read from DT props "marvell,nand-enable-arbiter" and > "marvell,nand-keep-config". The one device tree using the unprefixed > version is also changed to use the new naming. > > This has the side effect of making the previously no-op "marvell," > config knobs already present in some DTs actually do something. This was > likely the original intention of the DT authors, but note that this > commit was not tested on every single impacted board. > > Signed-off-by: Pierre Bourdon Applied to u-boot-marvell/master Thanks, Stefan > --- > arch/arm/dts/armada-cp110.dtsi | 2 +- > drivers/mtd/nand/raw/pxa3xx_nand.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/dts/armada-cp110.dtsi b/arch/arm/dts/armada-cp110.dtsi > index abf1e4ea08..ddc10d2374 100644 > --- a/arch/arm/dts/armada-cp110.dtsi > +++ b/arch/arm/dts/armada-cp110.dtsi > @@ -231,7 +231,7 @@ > #address-cells = <1>; > #size-cells = <0>; > clocks = <&CP110_LABEL(syscon0) 1 2>; > - nand-enable-arbiter; > + marvell,nand-enable-arbiter; > num-cs = <1>; > nand-ecc-strength = <8>; > nand-ecc-step-size = <512>; > diff --git a/drivers/mtd/nand/raw/pxa3xx_nand.c b/drivers/mtd/nand/raw/pxa3xx_nand.c > index 8ff58a7038..3a9c9ca508 100644 > --- a/drivers/mtd/nand/raw/pxa3xx_nand.c > +++ b/drivers/mtd/nand/raw/pxa3xx_nand.c > @@ -1862,10 +1862,10 @@ static int pxa3xx_nand_probe_dt(struct udevice *dev, struct pxa3xx_nand_info *in > return -EINVAL; > } > > - if (dev_read_bool(dev, "nand-enable-arbiter")) > + if (dev_read_bool(dev, "marvell,nand-enable-arbiter")) > pdata->enable_arbiter = 1; > > - if (dev_read_bool(dev, "nand-keep-config")) > + if (dev_read_bool(dev, "marvell,nand-keep-config")) > pdata->keep_config = 1; > > /* > Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de