From: Angelo Dureghello <angelo@kernel-space.org>
To: Tom Rini <trini@konsulko.com>
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH 4/7] m68k: Remove common.h usage
Date: Fri, 13 Oct 2023 23:40:34 +0200 [thread overview]
Message-ID: <f088dc6a-e38c-4dae-7ab4-1d716b9a4d86@kernel-space.org> (raw)
In-Reply-To: <20231013205510.GV3119521@bill-the-cat>
Hi Tom,
sorry, applied all now, it works, i can boot properly.
Thanks.
Acked-by: Angelo Dureghello <angelo@kernel-space.org>
On 13/10/23 10:55 PM, Tom Rini wrote:
> On Fri, Oct 13, 2023 at 10:53:04PM +0200, Angelo Dureghello wrote:
>> Hi Tom,
>>
>>
>> On 13/10/23 1:03 AM, Tom Rini wrote:
>>> We can remove common.h from most cases of the code here, and only a few
>>> places need an additional header instead.
>>>
>>> Signed-off-by: Tom Rini <trini@konsulko.com>
>>> ---
>>> Cc: Angelo Dureghello <angelo@kernel-space.org>
>>> ---
>>> arch/m68k/cpu/mcf523x/cpu.c | 1 -
>>> arch/m68k/cpu/mcf523x/cpu_init.c | 1 -
>>> arch/m68k/cpu/mcf523x/interrupts.c | 1 -
>>> arch/m68k/cpu/mcf523x/speed.c | 1 -
>>> arch/m68k/cpu/mcf52x2/cpu.c | 1 -
>>> arch/m68k/cpu/mcf52x2/cpu_init.c | 3 +--
>>> arch/m68k/cpu/mcf52x2/interrupts.c | 1 -
>>> arch/m68k/cpu/mcf52x2/speed.c | 1 -
>>> arch/m68k/cpu/mcf530x/cpu.c | 1 -
>>> arch/m68k/cpu/mcf530x/cpu_init.c | 1 -
>>> arch/m68k/cpu/mcf530x/interrupts.c | 1 -
>>> arch/m68k/cpu/mcf530x/speed.c | 1 -
>>> arch/m68k/cpu/mcf532x/cpu.c | 1 -
>>> arch/m68k/cpu/mcf532x/cpu_init.c | 1 -
>>> arch/m68k/cpu/mcf532x/interrupts.c | 1 -
>>> arch/m68k/cpu/mcf532x/speed.c | 1 -
>>> arch/m68k/cpu/mcf5445x/cpu.c | 1 -
>>> arch/m68k/cpu/mcf5445x/cpu_init.c | 1 -
>>> arch/m68k/cpu/mcf5445x/dspi.c | 1 -
>>> arch/m68k/cpu/mcf5445x/interrupts.c | 1 -
>>> arch/m68k/cpu/mcf5445x/speed.c | 1 -
>>> arch/m68k/cpu/mcf5445x/start.S | 1 -
>>> arch/m68k/include/asm/immap.h | 1 +
>>> arch/m68k/include/asm/immap_520x.h | 1 +
>>> arch/m68k/include/asm/immap_5235.h | 1 +
>>> arch/m68k/include/asm/immap_5272.h | 1 +
>>> arch/m68k/include/asm/immap_5275.h | 1 +
>>> arch/m68k/include/asm/immap_5282.h | 1 +
>>> arch/m68k/include/asm/immap_5301x.h | 1 +
>>> arch/m68k/include/asm/immap_5307.h | 2 ++
>>> arch/m68k/include/asm/immap_5329.h | 1 +
>>> arch/m68k/include/asm/immap_5441x.h | 1 +
>>> arch/m68k/lib/bdinfo.c | 3 ++-
>>> arch/m68k/lib/bootm.c | 1 -
>>> arch/m68k/lib/cache.c | 2 +-
>>> arch/m68k/lib/fec.c | 2 +-
>>> arch/m68k/lib/interrupts.c | 2 +-
>>> arch/m68k/lib/time.c | 1 -
>>> arch/m68k/lib/traps.c | 1 -
>>> 39 files changed, 17 insertions(+), 30 deletions(-)
>>>
>>
>> building for mcf5307 i get this error
>>
>> In file included from arch/m68k/lib/bootm.c:7:
>> include/bootstage.h:225:1: error: unknown type name 'ulong'; did you mean
>> 'long'?
>> 225 | ulong timer_get_boot_us(void);
>> | ^~~~~
>
> Did you apply the whole series? The first few patches fix some global
> issues.
>
--
Angelo Dureghello
w: www.kernel-space.org
e: angelo@kernel-space.org
next prev parent reply other threads:[~2023-10-13 21:47 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-12 23:03 [PATCH 1/7] checkpatch.pl: Make common.h check boarder Tom Rini
2023-10-12 23:03 ` [PATCH 2/7] include: Add <linux/types.h> in a few places Tom Rini
2023-10-13 15:14 ` Simon Glass
2023-10-24 23:15 ` Tom Rini
2023-10-12 23:03 ` [PATCH 3/7] arc: Remove common.h usage Tom Rini
2023-10-13 9:21 ` Alexey Brodkin
2023-10-24 23:15 ` Tom Rini
2023-10-12 23:03 ` [PATCH 4/7] m68k: " Tom Rini
2023-10-13 15:14 ` Simon Glass
2023-10-13 15:17 ` Tom Rini
2023-10-13 16:57 ` Simon Glass
2023-10-13 20:53 ` Angelo Dureghello
2023-10-13 20:55 ` Tom Rini
2023-10-13 21:40 ` Angelo Dureghello [this message]
2023-10-24 23:16 ` Tom Rini
2023-10-12 23:03 ` [PATCH 5/7] microblaze: " Tom Rini
2023-10-13 7:11 ` Michal Simek
2023-10-24 23:16 ` Tom Rini
2023-10-12 23:03 ` [PATCH 6/7] mips: " Tom Rini
2023-10-24 23:16 ` Tom Rini
2023-10-12 23:03 ` [PATCH 7/7] riscv: " Tom Rini
[not found] ` <SEZPR03MB8064C345D63766D2E86B2184C1D2A@SEZPR03MB8064.apcprd03.prod.outlook.com>
2023-10-13 8:52 ` Rick Chen
2023-10-24 23:16 ` Tom Rini
2023-10-13 15:15 ` [PATCH 1/7] checkpatch.pl: Make common.h check boarder Simon Glass
2023-10-13 15:16 ` Tom Rini
2023-10-13 15:49 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f088dc6a-e38c-4dae-7ab4-1d716b9a4d86@kernel-space.org \
--to=angelo@kernel-space.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox