U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Quentin Schulz <quentin.schulz@cherry.de>
To: Sam Edwards <cfsworks@gmail.com>,
	Joshua Riek <jjriek@verizon.net>, Tom Rini <trini@konsulko.com>,
	Kever Yang <kever.yang@rock-chips.com>
Cc: Jonas Karlman <jonas@kwiboo.se>,
	Eugen Hristev <eugen.hristev@collabora.com>,
	Christopher Obbard <chris.obbard@collabora.com>,
	u-boot@lists.denx.de, Florian Klink <flokli@flokli.de>
Subject: Re: [PATCH v3] configs: rk3588-turing-rk1: disable SPI flash by default
Date: Fri, 3 May 2024 18:26:04 +0200	[thread overview]
Message-ID: <f0e18185-d2da-4813-ae02-5725e0ee0a79@cherry.de> (raw)
In-Reply-To: <20240502200729.77955-1-CFSworks@gmail.com>

Hi Sam,

On 5/2/24 10:07 PM, Sam Edwards wrote:
> While the Turing RK1 board has a pad on the PCB for SPI flash, it is
> not populated at the factory: supporting SPI flash boot is a user
> modification, not an out-of-the-box feature. The defconfig for this
> board should therefore not be enabling the SPI flash image nor SPI
> support in the SPL, as it causes confusion among downstream users as to
> whether the SPI image needs to be distributed.
> 
> Fixes: 153ac950a599 ("board: rockchip: Add the Turing RK1 SoM")
> Suggested-by: Florian Klink <flokli@flokli.de>
> Signed-off-by: Sam Edwards <CFSworks@gmail.com>
> Acked-by: Joshua Riek <jjriek@verizon.net>
> Reviewed-by: Jonas Karlman <jonas@kwiboo.se>

Reviewed=by: Quentin Schulz <quentin.schulz@cherry.de>

Thanks,
Quentin

  reply	other threads:[~2024-05-03 16:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-02 20:07 [PATCH v3] configs: rk3588-turing-rk1: disable SPI flash by default Sam Edwards
2024-05-03 16:26 ` Quentin Schulz [this message]
2024-05-07  3:28 ` Kever Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f0e18185-d2da-4813-ae02-5725e0ee0a79@cherry.de \
    --to=quentin.schulz@cherry.de \
    --cc=cfsworks@gmail.com \
    --cc=chris.obbard@collabora.com \
    --cc=eugen.hristev@collabora.com \
    --cc=flokli@flokli.de \
    --cc=jjriek@verizon.net \
    --cc=jonas@kwiboo.se \
    --cc=kever.yang@rock-chips.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox