From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 197E4C54EE9 for ; Thu, 8 Sep 2022 11:21:00 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DC30D84ACE; Thu, 8 Sep 2022 13:20:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="b6gZPPsz"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id EBE4F847EF; Thu, 8 Sep 2022 13:20:56 +0200 (CEST) Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 13FD284AEC for ; Thu, 8 Sep 2022 13:20:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jh80.chung@gmail.com Received: by mail-pl1-x632.google.com with SMTP id s14so7917670plr.4 for ; Thu, 08 Sep 2022 04:20:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=bTpExoFQOCIzZStd41Jd59m1mAupYt5ARez2VM/J1fk=; b=b6gZPPszthDXfm9uDXMTciuUg9vRm2dUCD90ldmg/JxfhNvn/Q72bwCvLf3ORCsS5y NxAVLfGs3ZPIfm6wWKMidCf2mNnzDqJFeLEs920xM55DIK9H9XRddlKvA6dt1/ON6EsR implPEaROBkggUvWP3a3lhgeLL0/MOmH8vZNvmLW0xSNKJI9T9GePzs43rk4zLzKLlHN 6CQnIAY8xmcBhmM5unIe8e/IeVncmOJtriYxrlA4og6mBoo9E2NwjKrRYdG1gmIbt1UO tkjwzoVfsGn6xxuTLds6fgiDKjRP+DBduwS5ybTfA2e/aqVqfNtGnid73VJ431vuN/VW sVWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=bTpExoFQOCIzZStd41Jd59m1mAupYt5ARez2VM/J1fk=; b=h76W6jznXROFSvUy9W2hBkmUYYUEAJsO99nNHLCY3E3sggt5aMv3kTHOdNsY/OVsk8 Hj+XVNJ2JTwgm3jmE1UPQ0nIrU/hr4fByTLdpAM/IxUMWjoQv7Dw7D5BK0THC7qPhXNg q8ydJI4o8Nr82IC3IkgdF7neTgKxXwgUOh62eO8FokAZP5BYbtmbJfik9pCzOVoWIblw Vq2ygXXpRuYKlkqJ3eqFZERE1WGlSRS63mQ8l68Wt64PoLTDDmwI8PCZS+GTjRBbLNLB kKKHM+6uxhOraxzhdmk2fr6cJQpIsI0nedf6jN9bwn6cANzIPmXxhzU9OS0m98XhqGfE Oclg== X-Gm-Message-State: ACgBeo3wb6Yx4PeMEXA59KtsAeiKlSMXTv9HSJ0w6LdAtqUAnOt2FZV1 aEOkicgpa62fXvXq5moIeoo= X-Google-Smtp-Source: AA6agR5V4/xrc8KVtwPNlQH4c4OR8GKjl9fR6KmxwHNU7xXKnY3QijaxpAQK2BiFmFJkRKLcGoneaA== X-Received: by 2002:a17:90b:4c8d:b0:1f5:409b:b017 with SMTP id my13-20020a17090b4c8d00b001f5409bb017mr3802980pjb.52.1662636052121; Thu, 08 Sep 2022 04:20:52 -0700 (PDT) Received: from [192.168.0.19] ([183.99.112.216]) by smtp.gmail.com with ESMTPSA id a3-20020a621a03000000b0053e7495a395sm3731963pfa.122.2022.09.08.04.20.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Sep 2022 04:20:51 -0700 (PDT) Message-ID: Date: Thu, 8 Sep 2022 20:20:48 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] mmc: ftsdc010: make command timeout 250 ms as in the comment Content-Language: en-US To: Sergei Antonov , u-boot@lists.denx.de Cc: jh80.chung@samsung.com, peng.fan@nxp.com, yamada.masahiro@socionext.com, sjg@chromium.org, rick@andestech.com References: <20220902074010.1171646-1-saproj@gmail.com> From: Jaehoon Chung In-Reply-To: <20220902074010.1171646-1-saproj@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi On 9/2/22 16:40, Sergei Antonov wrote: > Get rid of discrepancy beween comment /* 250 ms */ and code > which shifts by 4 thus dividing by 16. > So change code to shift by 2 and make the timeout value 250 ms. > > Signed-off-by: Sergei Antonov Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > drivers/mmc/ftsdc010_mci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/ftsdc010_mci.c b/drivers/mmc/ftsdc010_mci.c > index 570d54cf9d8f..cabb747fbbdb 100644 > --- a/drivers/mmc/ftsdc010_mci.c > +++ b/drivers/mmc/ftsdc010_mci.c > @@ -30,7 +30,7 @@ > #include > #include > > -#define CFG_CMD_TIMEOUT (CONFIG_SYS_HZ >> 4) /* 250 ms */ > +#define CFG_CMD_TIMEOUT (CONFIG_SYS_HZ >> 2) /* 250 ms */ > #define CFG_RST_TIMEOUT CONFIG_SYS_HZ /* 1 sec reset timeout */ > > #if CONFIG_IS_ENABLED(OF_PLATDATA)