From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A62EC433EF for ; Mon, 20 Dec 2021 10:12:47 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8541F8310B; Mon, 20 Dec 2021 11:12:45 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1639995165; bh=sO4BOaSBbqTbdx/XjVJ44CR+Xd9hf641YM2AilJqOmw=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Reply-To:From; b=NBiQkf63oHnw9WyVLu7e79fAMJLRfgOMiKeH2ygxmJCK3i7eIQYkVj+eh/e9zLQu9 WMIVrv5Zi8tY/Qac0RZL3qOhAn3hQJOToENBRg7onxwz6KzVxjSqpIEOupGG1A8p6A Gn+hQ/ExD1DQey3SIjt0La9Oi4Iu+DD8YBTYRc43XA5HWP1qD4/QHyKiSN2szIt8mX vbu/lnB1EMUomlHqsKDrrrmJNSUjFGhg33Rj3aYZdykMJEVPSW+NhO0YFFB52TI7nK RCP0mA/2y6Wk9lNonNaaQQrDjT2Nk4a/SeV66ehxIgPA4/RZbV4V43S5OD6gRN3f9a L+cSX85p4chIA== Received: from [192.168.1.107] (82-131-202-6.pool.digikabel.hu [82.131.202.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: hs@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 366B180EEE; Mon, 20 Dec 2021 11:12:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1639995163; bh=sO4BOaSBbqTbdx/XjVJ44CR+Xd9hf641YM2AilJqOmw=; h=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From; b=F5WB58IYhTCGAHpykWrKBlYDrJFIuHlumOwkE/V7VEfJ0z5greUNlpAT18lN1hB6/ 68JJJ7RRZXKRiAKaZ084z/pCzoLYpZnobvd0NgxukPz+NDTtqGyDf3TJhgcEvXaIx0 0F6vepna89b07CQ9coCQXUWGy41L68rsbl4wtLWOXYYsxr/o4JVc4oYMrTIvvAKYpp tQ1zcxwIBqnSd6QkuVUWp6LH3YRFZghnAw8bftRtbXUZmO/pv82T6TAnqbNuzHuXPM SeKQl+VD/nRfiQEYjHvT0MhKrs6WGy9CjXs7DJxic1K7wFS0/2Z8tX0T384J6szyte 9OdJUePlSr94A== Subject: Re: [PATCH] i2c: mvtwsi: Swab the register address if its size is > 1 To: Stefan Roese , u-boot@lists.denx.de Cc: Samuel Holland , Baruch Siach , =?UTF-8?Q?Pali_Roh=c3=a1r?= , =?UTF-8?Q?Marek_Beh=c3=ban?= References: <20211118081841.861158-1-sr@denx.de> <3542e49a-aedf-406c-8927-a47fff172f92@denx.de> From: Heiko Schocher Message-ID: Date: Mon, 20 Dec 2021 11:12:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <3542e49a-aedf-406c-8927-a47fff172f92@denx.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: hs@denx.de Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hello Stefan, On 18.12.21 14:42, Stefan Roese wrote: > Hi Heiko, > > On 11/18/21 09:18, Stefan Roese wrote: >> Testing on Armada XP with an EEPROM using register address with size >> of 2 has shown, that the register address bytes are sent to the I2C >> EEPROM in the incorrect order. This patch swabs the address bytes so >> that the correct address is transferred to the I2C device. >> >> BTW: This worked without any issues before migrating Armada XP to >> DM I2C. >> >> Signed-off-by: Stefan Roese >> Cc: Heiko Schocher >> Cc: Samuel Holland >> Cc: Baruch Siach >> Cc: Pali Rohár >> Cc: Marek Behún >> --- >> It would be good if other users of this I2C driver could test this change >> with e.g. I2C EEPROM devices using 2 bytes (or more) for addressing. > > Could you and other please take a look at this? Would be great, if this > could be pulled in the next merge window. Applied to u-boot-i2c master Thanks! bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs@denx.de