From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Mon, 14 Nov 2016 15:31:13 +0100
Subject: [U-Boot] [PATCH] socfpga: add support for Terasic DE1-SoC board
In-Reply-To: <20161114151748.1e3faf3b@crub>
References: <1479131620-26313-1-git-send-email-agust@denx.de>
 <13284026-c271-d273-9b26-10be1497248a@denx.de> <20161114151748.1e3faf3b@crub>
Message-ID: <f18200fc-6174-e74d-1582-d91f2d7cf4d9@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 11/14/2016 03:17 PM, Anatolij Gustschin wrote:
> Hi,
> 
> On Mon, 14 Nov 2016 15:07:31 +0100
> Marek Vasut marex at denx.de wrote:
> ...
>>> +#undef CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_PARTITION
>>> +#define CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_PARTITION	2  
>>
>> Why is this needed ? Just start U-Boot from partition 1 as all the other
>> SoCFPGAs do , esp. since this is a devkit, please keep it consistent.
> 
> It is not really needed. I used the original Terasic SD-Card,
> its raw partition is 2. OK, will remove it.

Thanks!

>> Looks great otherwise :)
> 
> Thanks for review!

I'll pick V2 for the next release then. Thanks!

-- 
Best regards,
Marek Vasut